fdo-mirrors/NetworkManager
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/NetworkManager/NetworkManager.git synced 2025-12-27 12:50:09 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions
NetworkManager/src/ppp
History
Alfonso Sánchez-Beato a251712a72 core/pppd-plugin: wait to recover port settings before notifying death 
pppd restores the previous settings for the serial port it uses right
before exiting. It is especially important to do so because otherwise
ModemManager is not able to recover the port as it can receive a hangup
event from the port due to CLOCAL not being restored.  However, there is
currently a race condition that produces this issue. This is because
when PHASE_DEAD is notified, pppd still has not restored the port
settings - it does that a bit later, in the die() function.

This patch delays notifying PHASE_DEAD until when the exitnotify() hook
is called by pppd: when this happens the port settings have already been
restored.

There were previously efforts to fix this in commit fe090c34b7, so
PHASE_DEAD was used instead of PHASE_DISCONNECT to notify MM that the
port was disconnected, but that still early to ensure that the port
settings are restored.

The MM traces seen when the bug is triggered are:

ModemManager[2158]: <warn>  (ttyACM1): could not re-acquire serial port lock: (5) Input/output error
ModemManager[2158]: <warn>  Couldn't load Operator Code: 'Cannot run sequence: 'Could not open serial device ttyACM1: it has been forced close'

https://mail.gnome.org/archives/networkmanager-list/2019-June/msg00014.html
2019-06-14 13:29:45 +02:00
..
meson.build build/meson: rename "nm_core_dep" to "libnm_core_dep" 2019-04-18 20:13:49 +02:00
nm-ppp-manager-call.c all: drop emacs file variables from source files 2019-06-11 10:04:00 +02:00
nm-ppp-manager-call.h all: drop emacs file variables from source files 2019-06-11 10:04:00 +02:00
nm-ppp-manager.c all: drop emacs file variables from source files 2019-06-11 10:04:00 +02:00
nm-ppp-manager.h all: drop emacs file variables from source files 2019-06-11 10:04:00 +02:00
nm-ppp-plugin-api.h all: drop emacs file variables from source files 2019-06-11 10:04:00 +02:00
nm-ppp-plugin.ver ppp: split ppp manager into a plugin 2016-12-06 11:08:11 +01:00
nm-ppp-status.h all: drop emacs file variables from source files 2019-06-11 10:04:00 +02:00
nm-pppd-plugin.c core/pppd-plugin: wait to recover port settings before notifying death 2019-06-14 13:29:45 +02:00
nm-pppd-plugin.h all: drop emacs file variables from source files 2019-06-11 10:04:00 +02:00