NetworkManager/clients
Thomas Haller bbfd366805 cli: cleanup _get_fcn_vlan_xgress_priority_map()
- merge the pointless helper function vlan_priorities_to_string()
  into the only caller _get_fcn_vlan_xgress_priority_map().

- minor cleanups, like setting out-is-default if num==0, not
  based on whether we have a non-empty string. There is not difference
  in practice, because nm_setting_vlan_get_priority() never fails.
  Hence they are identical. But nm_setting_vlan_get_priority() has
  an API that allows it to fail, so we should declare the default
  depending on the number of vlan priorities.

- don't allocate the temporary GString instance if we won't need it.

- only append the delimiter if needed, and not truncate it afterwards.
  It might have even worse performance this way, but it feels more
  correct to me.

- also cache the result of nm_setting_vlan_get_num_priorities().
  NMSettingVlan's implementation is horrible and uses a GSList to
  track the list of priorities. This makes it relatively expensive
  to call get-num-priorities repeatedly (and pointless).
2019-04-18 18:49:00 +02:00
..
cli cli: fix crash in split_required_fields_for_con_show() 2019-04-16 16:00:32 +02:00
common cli: cleanup _get_fcn_vlan_xgress_priority_map() 2019-04-18 18:49:00 +02:00
tests clients: disable asan leak detection in client tests 2019-04-12 11:19:58 +02:00
tui clients: only ask secrets for settings that require them 2019-04-02 11:20:28 +02:00
meson.build build: meson: Add trailing commas 2018-12-20 13:50:34 +01:00
nm-online.c nm-online: sort options in man page and program help 2018-11-05 09:32:20 +01:00