NetworkManager/tui
Dan Winship bbc6434e96 tui: fix selection bugs after deleting a connection
nmt_newt_listbox_clear() did not reset active and active_key, which in
the case of NmtEditConnectionList meant that after the connection list
was rebuilt, the selection would appear to be in the same place, but
active_key would still point to the connection that used to be in that
row, rather than the one currently in that row, so if you immediately
hit Edit or Delete, you'd get unexpected results. (It also meant that
it was possible for the selection to land on a header row instead of a
connection row.)

This was particularly bad in the case of the Delete button, since
active_key would be left pointing to a freed NMConnection in that
case.

Fix NmtNewtListbox, and then add code to NmtEditConnectionList to
preserve the selection itself when rebuilding the list.
2014-03-21 13:32:24 -04:00
..
newt tui: fix selection bugs after deleting a connection 2014-03-21 13:32:24 -04:00
Makefile.am libnm-util, libnm-glib: add versioned deprecation/availability macros 2014-02-13 11:24:37 -05:00
nm-editor-bindings.c libnm-util: add a missing GValue transform needed by nmtui 2014-01-16 09:19:06 -05:00
nm-editor-bindings.h libnm-util: add a missing GValue transform needed by nmtui 2014-01-16 09:19:06 -05:00
nm-editor-utils.c nmtui: initial import of nmtui 2013-12-13 16:00:51 +01:00
nm-editor-utils.h nmtui: initial import of nmtui 2013-12-13 16:00:51 +01:00
nmt-address-list.c nmtui: initial import of nmtui 2013-12-13 16:00:51 +01:00
nmt-address-list.h nmtui: initial import of nmtui 2013-12-13 16:00:51 +01:00
nmt-connect-connection-list.c tui: handle Wi-Fi networks with multiple APs correctly 2014-02-17 15:30:04 -05:00
nmt-connect-connection-list.h tui: implement deactivation in "nmtui connect" 2014-01-16 09:19:07 -05:00
nmt-device-entry.c tui: fix the "Device" entry on currently-active virtual devices 2013-12-17 12:51:18 -05:00
nmt-device-entry.h nmtui: initial import of nmtui 2013-12-13 16:00:51 +01:00
nmt-edit-connection-list.c tui: fix selection bugs after deleting a connection 2014-03-21 13:32:24 -04:00
nmt-edit-connection-list.h nmtui: initial import of nmtui 2013-12-13 16:00:51 +01:00
nmt-editor-page.c nmtui: initial import of nmtui 2013-12-13 16:00:51 +01:00
nmt-editor-page.h nmtui: initial import of nmtui 2013-12-13 16:00:51 +01:00
nmt-editor.c tui: don't expand editor form to fullscreen horizontally 2014-02-17 15:30:04 -05:00
nmt-editor.h nmtui: initial import of nmtui 2013-12-13 16:00:51 +01:00
nmt-ip-entry.c nmtui: initial import of nmtui 2013-12-13 16:00:51 +01:00
nmt-ip-entry.h nmtui: initial import of nmtui 2013-12-13 16:00:51 +01:00
nmt-mac-entry.c nmtui: initial import of nmtui 2013-12-13 16:00:51 +01:00
nmt-mac-entry.h nmtui: initial import of nmtui 2013-12-13 16:00:51 +01:00
nmt-mtu-entry.c nmtui: initial import of nmtui 2013-12-13 16:00:51 +01:00
nmt-mtu-entry.h nmtui: initial import of nmtui 2013-12-13 16:00:51 +01:00
nmt-page-bond.c nmtui: initial import of nmtui 2013-12-13 16:00:51 +01:00
nmt-page-bond.h nmtui: initial import of nmtui 2013-12-13 16:00:51 +01:00
nmt-page-bridge-port.c nmtui: initial import of nmtui 2013-12-13 16:00:51 +01:00
nmt-page-bridge-port.h nmtui: initial import of nmtui 2013-12-13 16:00:51 +01:00
nmt-page-bridge.c nmtui: initial import of nmtui 2013-12-13 16:00:51 +01:00
nmt-page-bridge.h nmtui: initial import of nmtui 2013-12-13 16:00:51 +01:00
nmt-page-device.c nmtui: initial import of nmtui 2013-12-13 16:00:51 +01:00
nmt-page-device.h nmtui: initial import of nmtui 2013-12-13 16:00:51 +01:00
nmt-page-ethernet.c nmtui: initial import of nmtui 2013-12-13 16:00:51 +01:00
nmt-page-ethernet.h nmtui: initial import of nmtui 2013-12-13 16:00:51 +01:00
nmt-page-grid.c nmtui: initial import of nmtui 2013-12-13 16:00:51 +01:00
nmt-page-grid.h nmtui: initial import of nmtui 2013-12-13 16:00:51 +01:00
nmt-page-infiniband.c tui: properly initialize InfiniBand transport-mode 2014-02-13 18:28:30 +01:00
nmt-page-infiniband.h nmtui: initial import of nmtui 2013-12-13 16:00:51 +01:00
nmt-page-ip4.c tui: properly initialize the IP4 and IP6 settings on new connections 2014-01-30 11:43:15 -05:00
nmt-page-ip4.h nmtui: initial import of nmtui 2013-12-13 16:00:51 +01:00
nmt-page-ip6.c tui: properly initialize the IP4 and IP6 settings on new connections 2014-01-30 11:43:15 -05:00
nmt-page-ip6.h nmtui: initial import of nmtui 2013-12-13 16:00:51 +01:00
nmt-page-main.c nmtui: initial import of nmtui 2013-12-13 16:00:51 +01:00
nmt-page-main.h nmtui: initial import of nmtui 2013-12-13 16:00:51 +01:00
nmt-page-team-port.c nmtui: initial import of nmtui 2013-12-13 16:00:51 +01:00
nmt-page-team-port.h nmtui: initial import of nmtui 2013-12-13 16:00:51 +01:00
nmt-page-team.c nmtui: initial import of nmtui 2013-12-13 16:00:51 +01:00
nmt-page-team.h nmtui: initial import of nmtui 2013-12-13 16:00:51 +01:00
nmt-page-vlan.c nmtui: initial import of nmtui 2013-12-13 16:00:51 +01:00
nmt-page-vlan.h nmtui: initial import of nmtui 2013-12-13 16:00:51 +01:00
nmt-page-wifi.c nmtui: initial import of nmtui 2013-12-13 16:00:51 +01:00
nmt-page-wifi.h nmtui: initial import of nmtui 2013-12-13 16:00:51 +01:00
nmt-password-dialog.c nmtui: initial import of nmtui 2013-12-13 16:00:51 +01:00
nmt-password-dialog.h nmtui: initial import of nmtui 2013-12-13 16:00:51 +01:00
nmt-password-fields.c nmtui: initial import of nmtui 2013-12-13 16:00:51 +01:00
nmt-password-fields.h nmtui: initial import of nmtui 2013-12-13 16:00:51 +01:00
nmt-route-editor.c nmtui: initial import of nmtui 2013-12-13 16:00:51 +01:00
nmt-route-editor.h nmtui: initial import of nmtui 2013-12-13 16:00:51 +01:00
nmt-route-entry.c nmtui: initial import of nmtui 2013-12-13 16:00:51 +01:00
nmt-route-entry.h nmtui: initial import of nmtui 2013-12-13 16:00:51 +01:00
nmt-route-table.c tui: add nmt_newt_text_width() 2014-01-16 09:19:07 -05:00
nmt-route-table.h nmtui: initial import of nmtui 2013-12-13 16:00:51 +01:00
nmt-secret-agent.c tui: fix build 2014-01-16 14:54:39 -05:00
nmt-secret-agent.h nmtui: initial import of nmtui 2013-12-13 16:00:51 +01:00
nmt-slave-list.c nmtui: initial import of nmtui 2013-12-13 16:00:51 +01:00
nmt-slave-list.h nmtui: initial import of nmtui 2013-12-13 16:00:51 +01:00
nmt-utils.c nmtui: initial import of nmtui 2013-12-13 16:00:51 +01:00
nmt-utils.h nmtui: initial import of nmtui 2013-12-13 16:00:51 +01:00
nmt-widget-list.c tui: fix a crash when creating a new connection 2014-01-30 11:43:15 -05:00
nmt-widget-list.h nmtui: initial import of nmtui 2013-12-13 16:00:51 +01:00
nmtui-connect.c tui: handle Esc correctly from toplevel windows 2014-02-17 15:30:04 -05:00
nmtui-connect.h nmtui: initial import of nmtui 2013-12-13 16:00:51 +01:00
nmtui-edit.c tui: handle Esc correctly from toplevel windows 2014-02-17 15:30:04 -05:00
nmtui-edit.h nmtui: initial import of nmtui 2013-12-13 16:00:51 +01:00
nmtui-hostname.c tui: rename nmt_newt_error_dialog() to nmt_newt_message_dialog() 2014-01-16 09:19:06 -05:00
nmtui-hostname.h nmtui: initial import of nmtui 2013-12-13 16:00:51 +01:00
nmtui.c trivial: fix variable shadowing 2014-01-17 10:26:42 -06:00
nmtui.h nmtui: initial import of nmtui 2013-12-13 16:00:51 +01:00
vpn-helpers.c nmtui: initial import of nmtui 2013-12-13 16:00:51 +01:00
vpn-helpers.h nmtui: initial import of nmtui 2013-12-13 16:00:51 +01:00