fdo-mirrors/NetworkManager
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/NetworkManager/NetworkManager.git synced 2026-01-06 05:00:15 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions
NetworkManager/libnm-core
History
Lubomir Rintel bb45adeda0 setting-vpn: whatever is in vpn.secrets always is a secrets 
Even when there's no <secret>-flags key for it in vpn-data.

This is essentially to fix regression in the way openconnect uses the VPN
secrets:

Openconnect auth helper is essentially a web browser that fills in an arbitrary
HTML (or XML) form that's used to get the session cookie. The actual secret the
service needs is the cookie itself.

However, what needs to be remembered includes the form data. What data can be
in the form is installation dependent and can not be known in advance. Thus the
flags for it can't be currently set in the connection. The auth helper is not
capable of setting the flags either, because it can only return secrets.

Prior to 1424f249e we treated vpn.secrets without the flags as system secrets
and store them in the connection. Since that commit we just filter them away,
which broke user configurations.

This restores the behavior or treating everyting in vpn.secrets as secrets and
falling back to system secrets.

Another way would be to find a way to flag the secrets, perhaps by
extending the auth helper protocol to be able to store non-secret
properties too.

https://bugzilla.gnome.org/show_bug.cgi?id=768737
https://bugzilla.redhat.com/show_bug.cgi?id=1332491

(cherry picked from commit 9b96bfaa72)
2016-10-12 12:54:43 +02:00
..
tests libnm-core/tests: fix compiler warning about unused variable 2016-08-31 14:27:56 +02:00
crypto.c libnm-core: empty key is not a pkcs12 file 2016-04-20 10:49:34 +02:00
crypto.h all: make use of new header file "nm-default.h" 2015-08-05 15:32:40 +02:00
crypto_gnutls.c all: cleanup includes and let "nm-default.h" include "config.h" 2016-02-19 17:53:25 +01:00
crypto_nss.c all: cleanup includes and let "nm-default.h" include "config.h" 2016-02-19 17:53:25 +01:00
Makefile.am docs: include the D-Bus enums reference with the API documentation 2016-04-22 17:14:14 +02:00
Makefile.libnm-core shared: include "nm-shared-utils.h" 2016-03-26 12:10:53 +01:00
nm-connection-private.h libnm-core: make nm_setting_verify() take an NMConnection 2014-10-28 17:17:17 -04:00
nm-connection.c libnm-core: ip-config: normalize may-fail for disabled IP methods 2016-07-06 10:12:27 +02:00
nm-connection.h libnm-core: add NMSettingVxlan 2015-12-09 16:36:46 +01:00
nm-core-internal.h libnm/vpn: search VPN plugin in NMPLUGINDIR 2016-04-19 15:16:07 +02:00
nm-core-types-internal.h libnm: internally expose NMVlanQosMapping struct in "nm-core-internal.h" 2015-11-02 13:57:02 +01:00
nm-core-types.h libnm-core: add NMSettingVxlan 2015-12-09 16:36:46 +01:00
nm-dbus-interface.h libnm-core: don't link to NMDevice type from the D-Bus spec 2016-04-22 17:14:13 +02:00
nm-dbus-utils.c all: cleanup includes and let "nm-default.h" include "config.h" 2016-02-19 17:53:25 +01:00
nm-errors.c all: cleanup includes and let "nm-default.h" include "config.h" 2016-02-19 17:53:25 +01:00
nm-errors.h manager: add Reload() D-Bus command 2016-06-10 11:14:38 +02:00
nm-keyfile-internal.h all: make use of new header file "nm-default.h" 2015-08-05 15:32:40 +02:00
nm-keyfile-reader.c libnm-core: remove special handling of missing VLAN_FLAGS 2016-02-29 18:11:17 +01:00
nm-keyfile-utils.c all: cleanup includes and let "nm-default.h" include "config.h" 2016-02-19 17:53:25 +01:00
nm-keyfile-utils.h libnm/keyfile/trivial: rename VPN_SECRETS_GROUP define to NM_KEYFILE_GROUP_VPN_SECRETS 2016-02-14 11:14:35 +01:00
nm-keyfile-writer.c all: cleanup includes and let "nm-default.h" include "config.h" 2016-02-19 17:53:25 +01:00
nm-property-compare.c all: cleanup includes and let "nm-default.h" include "config.h" 2016-02-19 17:53:25 +01:00
nm-property-compare.h all: make use of new header file "nm-default.h" 2015-08-05 15:32:40 +02:00
nm-setting-8021x.c libnm-core: nm-setting-8021x: treat some empty properties as NULL 2016-03-16 17:32:17 +01:00
nm-setting-8021x.h docs: libnm: add doc comment to types 2016-05-07 15:34:30 +02:00
nm-setting-adsl.c all: cleanup includes and let "nm-default.h" include "config.h" 2016-02-19 17:53:25 +01:00
nm-setting-adsl.h docs: libnm: add doc comment to types 2016-05-07 15:34:30 +02:00
nm-setting-bluetooth.c all: cleanup includes and let "nm-default.h" include "config.h" 2016-02-19 17:53:25 +01:00
nm-setting-bluetooth.h docs: libnm: add doc comment to types 2016-05-07 15:34:30 +02:00
nm-setting-bond.c libnm-core: implement option matching for NMSettingBond 2016-03-29 18:10:05 +02:00
nm-setting-bond.h docs: libnm: add doc comment to types 2016-05-07 15:34:30 +02:00
nm-setting-bridge-port.c all: cleanup includes and let "nm-default.h" include "config.h" 2016-02-19 17:53:25 +01:00
nm-setting-bridge-port.h docs: libnm: add doc comment to types 2016-05-07 15:34:30 +02:00
nm-setting-bridge.c man,libnm-core: fix typos 2016-03-30 12:03:36 +02:00
nm-setting-bridge.h docs: libnm: add doc comment to types 2016-05-07 15:34:30 +02:00
nm-setting-cdma.c all: cleanup includes and let "nm-default.h" include "config.h" 2016-02-19 17:53:25 +01:00
nm-setting-cdma.h docs: libnm: add doc comment to types 2016-05-07 15:34:30 +02:00
nm-setting-connection.c libnm-core: allow strict and relaxed error behavior for _nm_setting_new_from_dbus() 2016-03-26 12:10:54 +01:00
nm-setting-connection.h libnm: add 'lldp' property to NMSettingConnection 2015-10-12 14:44:19 +02:00
nm-setting-dcb.c all: cleanup includes and let "nm-default.h" include "config.h" 2016-02-19 17:53:25 +01:00
nm-setting-dcb.h docs: libnm: add doc comment to types 2016-05-07 15:34:30 +02:00
nm-setting-generic.c all: cleanup includes and let "nm-default.h" include "config.h" 2016-02-19 17:53:25 +01:00
nm-setting-generic.h docs: libnm: add doc comment to types 2016-05-07 15:34:30 +02:00
nm-setting-gsm.c all: cleanup includes and let "nm-default.h" include "config.h" 2016-02-19 17:53:25 +01:00
nm-setting-gsm.h docs: libnm: add doc comment to types 2016-05-07 15:34:30 +02:00
nm-setting-infiniband.c man,libnm-core: fix typos 2016-03-30 12:03:36 +02:00
nm-setting-infiniband.h docs: libnm: add doc comment to types 2016-05-07 15:34:30 +02:00
nm-setting-ip-config.c libnm-core: remove gateway when never-default=yes in NMSettingIPConfig 2016-07-06 10:00:41 +02:00
nm-setting-ip-config.h libnm-core: add dns-priority to NMSettingIPConfig 2016-06-10 11:14:36 +02:00
nm-setting-ip-tunnel.c libnm-core: fix memory leak in nm-setting-ip-tunnel.c 2016-03-09 23:16:23 +01:00
nm-setting-ip-tunnel.h docs: libnm: add doc comment to types 2016-05-07 15:34:30 +02:00
nm-setting-ip4-config.c libnm-core: ip-config: normalize may-fail for disabled IP methods 2016-07-06 10:12:27 +02:00
nm-setting-ip4-config.h docs: libnm: add doc comment to types 2016-05-07 15:34:30 +02:00
nm-setting-ip6-config.c libnm-core: ip-config: normalize may-fail for disabled IP methods 2016-07-06 10:12:27 +02:00
nm-setting-ip6-config.h docs: libnm: add doc comment to types 2016-05-07 15:34:30 +02:00
nm-setting-macvlan.c libnm-core: remove trailing quote from message in nm-setting-macvlan.c 2016-03-30 00:33:20 +02:00
nm-setting-macvlan.h docs: libnm: add doc comment to types 2016-05-07 15:34:30 +02:00
nm-setting-olpc-mesh.c all: cleanup includes and let "nm-default.h" include "config.h" 2016-02-19 17:53:25 +01:00
nm-setting-olpc-mesh.h docs: libnm: add doc comment to types 2016-05-07 15:34:30 +02:00
nm-setting-ppp.c all: cleanup includes and let "nm-default.h" include "config.h" 2016-02-19 17:53:25 +01:00
nm-setting-ppp.h docs: libnm: add doc comment to types 2016-05-07 15:34:30 +02:00
nm-setting-pppoe.c all: cleanup includes and let "nm-default.h" include "config.h" 2016-02-19 17:53:25 +01:00
nm-setting-pppoe.h docs: libnm: add doc comment to types 2016-05-07 15:34:30 +02:00
nm-setting-private.h libnm-core: allow strict and relaxed error behavior for _nm_setting_new_from_dbus() 2016-03-26 12:10:54 +01:00
nm-setting-serial.c all: cleanup includes and let "nm-default.h" include "config.h" 2016-02-19 17:53:25 +01:00
nm-setting-serial.h docs: libnm: add doc comment to types 2016-05-07 15:34:30 +02:00
nm-setting-team-port.c all: cleanup includes and let "nm-default.h" include "config.h" 2016-02-19 17:53:25 +01:00
nm-setting-team-port.h docs: libnm: add doc comment to types 2016-05-07 15:34:30 +02:00
nm-setting-team.c all: cleanup includes and let "nm-default.h" include "config.h" 2016-02-19 17:53:25 +01:00
nm-setting-team.h docs: libnm: add doc comment to types 2016-05-07 15:34:30 +02:00
nm-setting-tun.c all: cleanup includes and let "nm-default.h" include "config.h" 2016-02-19 17:53:25 +01:00
nm-setting-tun.h docs: libnm: add doc comment to types 2016-05-07 15:34:30 +02:00
nm-setting-vlan.c libnm-core: allow strict and relaxed error behavior for _nm_setting_new_from_dbus() 2016-03-26 12:10:54 +01:00
nm-setting-vlan.h docs: libnm: add doc comment to types 2016-05-07 15:34:30 +02:00
nm-setting-vpn.c setting-vpn: whatever is in vpn.secrets always is a secrets 2016-10-12 12:54:43 +02:00
nm-setting-vpn.h docs: libnm: add doc comment to types 2016-05-07 15:34:30 +02:00
nm-setting-vxlan.c all: cleanup includes and let "nm-default.h" include "config.h" 2016-02-19 17:53:25 +01:00
nm-setting-vxlan.h docs: libnm: add doc comment to types 2016-05-07 15:34:30 +02:00
nm-setting-wimax.c all: cleanup includes and let "nm-default.h" include "config.h" 2016-02-19 17:53:25 +01:00
nm-setting-wimax.h docs: libnm: add doc comment to types 2016-05-07 15:34:30 +02:00
nm-setting-wired.c man,libnm-core: fix typos 2016-03-30 12:03:36 +02:00
nm-setting-wired.h docs: libnm: add doc comment to types 2016-05-07 15:34:30 +02:00
nm-setting-wireless-security.c all: cleanup includes and let "nm-default.h" include "config.h" 2016-02-19 17:53:25 +01:00
nm-setting-wireless-security.h docs: libnm: add doc comment to types 2016-05-07 15:34:30 +02:00
nm-setting-wireless.c man,libnm-core: fix typos 2016-03-30 12:03:36 +02:00
nm-setting-wireless.h docs: libnm: add doc comment to types 2016-05-07 15:34:30 +02:00
nm-setting.c all: replace nm_unauto() by g_steal_pointer() 2016-05-12 14:35:14 +02:00
nm-setting.h libnm: add nm_setting_verify_secrets() and nm_connection_verify_secrets() 2015-11-20 10:35:10 +01:00
nm-simple-connection.c libnm-core: add _nm_simple_connection_new_from_dbus() function 2016-03-26 12:10:54 +01:00
nm-simple-connection.h docs: libnm: add doc comment to types 2016-05-07 15:34:30 +02:00
nm-utils-private.h libnm: expose strv utils function in internal header nm-core-internal.h 2015-07-02 15:50:04 +02:00
nm-utils.c libnm: don't require initialized @out_encrypted argument in nm_utils_file_is_private_key() 2016-05-13 14:26:52 +02:00
nm-utils.h libnm-core: add nm_utils_enum_get_values() 2015-12-01 17:39:40 +01:00
nm-version.h version: remove NM_AVAILABLE_IN_1_4 macros and add NM_AVAILABLE_IN_1_2_4 2016-06-10 02:25:53 +02:00
nm-vpn-dbus-interface.h dbus: remove the telepathy annotations 2016-04-05 14:37:51 +02:00
nm-vpn-editor-plugin.c all: replace nm_unauto() by g_steal_pointer() 2016-05-12 14:35:14 +02:00
nm-vpn-editor-plugin.h libnm/vpn: search VPN plugin in NMPLUGINDIR 2016-04-19 15:16:07 +02:00
nm-vpn-plugin-info.c libnm/vpn: search VPN plugin in NMPLUGINDIR 2016-04-19 15:16:07 +02:00
nm-vpn-plugin-info.h docs: libnm: add doc comment to types 2016-05-07 15:34:30 +02:00