mirror of
https://gitlab.freedesktop.org/NetworkManager/NetworkManager.git
synced 2026-05-22 12:28:11 +02:00
Fix a few problems... No plugin should return secrets in the GetSettings method, which some plugins did. When that was committed in the commit "system-settings: don't return secrets in the settings", it broke those plugins that didn't implement GetSecrets. Each plugin can actually use the same code for GetSettings and GetSecrets, so implement those generically in the NMExportedConnection class and remove plugin-specific implementations that all did the same thing.
186 lines
5.3 KiB
C
186 lines
5.3 KiB
C
/* -*- Mode: C; tab-width: 4; indent-tabs-mode: t; c-basic-offset: 4 -*- */
|
|
/* NetworkManager system settings service
|
|
*
|
|
* This program is free software; you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License as published by
|
|
* the Free Software Foundation; either version 2 of the License, or
|
|
* (at your option) any later version.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License along
|
|
* with this program; if not, write to the Free Software Foundation, Inc.,
|
|
* 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
|
|
*
|
|
* (C) Copyright 2008 Novell, Inc.
|
|
*/
|
|
|
|
#include <string.h>
|
|
#include <glib/gstdio.h>
|
|
#include <gio/gio.h>
|
|
#include <NetworkManager.h>
|
|
#include "nm-suse-connection.h"
|
|
#include "parser.h"
|
|
#include "nm-system-config-error.h"
|
|
|
|
G_DEFINE_TYPE (NMSuseConnection, nm_suse_connection, NM_TYPE_SYSCONFIG_CONNECTION)
|
|
|
|
#define NM_SUSE_CONNECTION_GET_PRIVATE(o) (G_TYPE_INSTANCE_GET_PRIVATE ((o), NM_TYPE_SUSE_CONNECTION, NMSuseConnectionPrivate))
|
|
|
|
typedef struct {
|
|
GFileMonitor *monitor;
|
|
guint monitor_id;
|
|
|
|
const char *iface;
|
|
NMDeviceType dev_type;
|
|
char *filename;
|
|
} NMSuseConnectionPrivate;
|
|
|
|
static void
|
|
file_changed (GFileMonitor *monitor,
|
|
GFile *file,
|
|
GFile *other_file,
|
|
GFileMonitorEvent event_type,
|
|
gpointer user_data)
|
|
{
|
|
NMExportedConnection *exported = NM_EXPORTED_CONNECTION (user_data);
|
|
NMSuseConnectionPrivate *priv = NM_SUSE_CONNECTION_GET_PRIVATE (exported);
|
|
NMConnection *new_connection;
|
|
GHashTable *new_settings;
|
|
|
|
switch (event_type) {
|
|
case G_FILE_MONITOR_EVENT_CHANGES_DONE_HINT:
|
|
new_connection = parse_ifcfg (priv->iface, priv->dev_type);
|
|
if (new_connection) {
|
|
GError *error = NULL;
|
|
|
|
new_settings = nm_connection_to_hash (new_connection);
|
|
if (nm_connection_replace_settings (nm_exported_connection_get_connection (exported), new_settings, &error))
|
|
nm_exported_connection_signal_updated (exported, new_settings);
|
|
else {
|
|
g_warning ("%s: '%s' / '%s' invalid: %d",
|
|
__func__,
|
|
error ? g_type_name (nm_connection_lookup_setting_type_by_quark (error->domain)) : "(none)",
|
|
(error && error->message) ? error->message : "(none)",
|
|
error ? error->code : -1);
|
|
g_clear_error (&error);
|
|
nm_exported_connection_signal_removed (exported);
|
|
}
|
|
|
|
g_hash_table_destroy (new_settings);
|
|
g_object_unref (new_connection);
|
|
} else
|
|
nm_exported_connection_signal_removed (exported);
|
|
break;
|
|
case G_FILE_MONITOR_EVENT_DELETED:
|
|
nm_exported_connection_signal_removed (exported);
|
|
break;
|
|
default:
|
|
break;
|
|
}
|
|
}
|
|
|
|
NMSuseConnection *
|
|
nm_suse_connection_new (const char *iface, NMDeviceType dev_type)
|
|
{
|
|
NMConnection *connection;
|
|
GFile *file;
|
|
GFileMonitor *monitor;
|
|
NMSuseConnection *exported;
|
|
NMSuseConnectionPrivate *priv;
|
|
|
|
g_return_val_if_fail (iface != NULL, NULL);
|
|
|
|
connection = parse_ifcfg (iface, dev_type);
|
|
if (!connection)
|
|
return NULL;
|
|
|
|
exported = (NMSuseConnection *) g_object_new (NM_TYPE_SUSE_CONNECTION,
|
|
NM_EXPORTED_CONNECTION_CONNECTION, connection,
|
|
NULL);
|
|
g_object_unref (connection);
|
|
if (!exported)
|
|
return NULL;
|
|
|
|
priv = NM_SUSE_CONNECTION_GET_PRIVATE (exported);
|
|
|
|
priv->iface = g_strdup (iface);
|
|
priv->dev_type = dev_type;
|
|
priv->filename = g_strdup_printf (SYSCONFDIR "/sysconfig/network/ifcfg-%s", iface);
|
|
|
|
file = g_file_new_for_path (priv->filename);
|
|
monitor = g_file_monitor_file (file, G_FILE_MONITOR_NONE, NULL, NULL);
|
|
g_object_unref (file);
|
|
|
|
if (monitor) {
|
|
priv->monitor_id = g_signal_connect (monitor, "changed", G_CALLBACK (file_changed), exported);
|
|
priv->monitor = monitor;
|
|
}
|
|
|
|
return exported;
|
|
}
|
|
|
|
static gboolean
|
|
update (NMExportedConnection *exported,
|
|
GHashTable *new_settings,
|
|
GError **err)
|
|
{
|
|
g_set_error (err, NM_SYSCONFIG_SETTINGS_ERROR,
|
|
NM_SYSCONFIG_SETTINGS_ERROR_UPDATE_NOT_SUPPORTED,
|
|
"%s", "Please use YaST to change this connection.");
|
|
|
|
return FALSE;
|
|
}
|
|
|
|
static gboolean
|
|
do_delete (NMExportedConnection *exported, GError **err)
|
|
{
|
|
g_set_error (err, NM_SYSCONFIG_SETTINGS_ERROR,
|
|
NM_SYSCONFIG_SETTINGS_ERROR_DELETE_NOT_SUPPORTED,
|
|
"%s", "Please use YaST to remove this connection.");
|
|
|
|
return FALSE;
|
|
}
|
|
|
|
/* GObject */
|
|
|
|
static void
|
|
nm_suse_connection_init (NMSuseConnection *connection)
|
|
{
|
|
}
|
|
|
|
static void
|
|
finalize (GObject *object)
|
|
{
|
|
NMSuseConnectionPrivate *priv = NM_SUSE_CONNECTION_GET_PRIVATE (object);
|
|
|
|
if (priv->monitor) {
|
|
if (priv->monitor_id)
|
|
g_signal_handler_disconnect (priv->monitor, priv->monitor_id);
|
|
|
|
g_file_monitor_cancel (priv->monitor);
|
|
g_object_unref (priv->monitor);
|
|
}
|
|
|
|
g_free (priv->filename);
|
|
|
|
G_OBJECT_CLASS (nm_suse_connection_parent_class)->finalize (object);
|
|
}
|
|
|
|
static void
|
|
nm_suse_connection_class_init (NMSuseConnectionClass *suse_connection_class)
|
|
{
|
|
GObjectClass *object_class = G_OBJECT_CLASS (suse_connection_class);
|
|
NMExportedConnectionClass *connection_class = NM_EXPORTED_CONNECTION_CLASS (suse_connection_class);
|
|
|
|
g_type_class_add_private (suse_connection_class, sizeof (NMSuseConnectionPrivate));
|
|
|
|
/* Virtual methods */
|
|
object_class->finalize = finalize;
|
|
|
|
connection_class->update = update;
|
|
connection_class->do_delete = do_delete;
|
|
}
|