NetworkManager/libnm-core
Dan Winship aeb3d093f6 libnm-core: clean up NMConnectionError
Rename NM_CONNECTION_ERROR_UNKNOWN to NM_CONNECTION_ERROR_FAILED,
following GError best practices.

Replace NM_CONNECTION_ERROR_CONNECTION_SETTING_NOT_FOUND ("no
NMSettingConnection") with a more generic
NM_CONNECTION_ERROR_MISSING_SETTING. Use that new code in a few places
that had previously been using NM_CONNECTION_ERROR_SETTING_NOT_FOUND,
which was supposed to mean "the setting that you asked about doesn't
exist", not "the connection is invalid because it's missing a required
setting".

Clarify that NM_CONNECTION_ERROR_INVALID_SETTING can be used for any
"invalid or inappropriate NMSetting", not just a "conflicting" one.
(But fix a case in nm_connection_update_secrets() that was returning
INVALID_SETTING when it should have been return-if-failing instead.)

For both MISSING_SETTING and INVALID_SETTING, always prefix the error
message with "setting-name: ", just like we do with the various
NMSetting MISSING_PROPERTY and INVALID_PROPERTY errors. And make sure
that the error message is marked for localization.

Drop NM_CONNECTION_ERROR_CONNECTION_TYPE_INVALID, which is pretty
pointless; it was only used in the case where connection.type was the
name of a valid setting type that is not a base setting type. Instead,
just return NM_SETTING_CONNECTION_ERROR_INVALID_PROPERTY for
connection.type in this case (which is what the code already did when
connection.type was completely unrecognized).
2014-10-22 08:29:07 -04:00
..
tests libnm-core: clean up NMConnectionError 2014-10-22 08:29:07 -04:00
crypto.c libnm-core: replace GByteArray with pointer + length in some APIs 2014-09-04 09:20:11 -04:00
crypto.h libnm-core: replace GByteArray with pointer + length in some APIs 2014-09-04 09:20:11 -04:00
crypto_gnutls.c libnm-core: replace GByteArray with pointer + length in some APIs 2014-09-04 09:20:11 -04:00
crypto_nss.c libnm-core: replace GByteArray with pointer + length in some APIs 2014-09-04 09:20:11 -04:00
Makefile.am libnm: port to GDBus 2014-09-18 11:51:09 -04:00
Makefile.libnm-core libnm-core: change connection hash tables to variants in API 2014-09-18 11:51:09 -04:00
nm-connection.c libnm-core: clean up NMConnectionError 2014-10-22 08:29:07 -04:00
nm-connection.h libnm-core: clean up NMConnectionError 2014-10-22 08:29:07 -04:00
nm-core-internal.h libnm-util: add _nm_setting_get_property() function 2014-10-12 21:17:17 +02:00
nm-dbus-interface.h all: fix up multiple-include-guard defines 2014-08-16 10:17:14 -04:00
nm-property-compare.c libnm-core: change connection hash tables to variants in API 2014-09-18 11:51:09 -04:00
nm-property-compare.h libnm-core: change connection hash tables to variants in API 2014-09-18 11:51:09 -04:00
nm-setting-8021x.c libnm: make use of GParamSpecFlags and GParamSpecEnum 2014-10-03 09:36:28 -04:00
nm-setting-8021x.h libnm-core: change DBUS_TYPE_G_UCHAR_ARRAY properties to G_TYPE_BYTES 2014-09-04 09:20:11 -04:00
nm-setting-adsl.c libnm: make use of GParamSpecFlags and GParamSpecEnum 2014-10-03 09:36:28 -04:00
nm-setting-adsl.h all: fix up multiple-include-guard defines 2014-08-16 10:17:14 -04:00
nm-setting-bluetooth.c libnm-core: change connection hash tables to variants in API 2014-09-18 11:51:09 -04:00
nm-setting-bluetooth.h libnm-core: change all mac-address properties to G_TYPE_STRING 2014-09-04 09:20:10 -04:00
nm-setting-bond.c libnm: add bonding option "lacp_rate" to NMSettingBond 2014-10-02 16:36:03 +02:00
nm-setting-bond.h libnm: add bonding option "lacp_rate" to NMSettingBond 2014-10-02 16:36:03 +02:00
nm-setting-bridge-port.c libnm-core: clean up NMConnectionError 2014-10-22 08:29:07 -04:00
nm-setting-bridge-port.h all: fix up multiple-include-guard defines 2014-08-16 10:17:14 -04:00
nm-setting-bridge.c libnm-core: change connection hash tables to variants in API 2014-09-18 11:51:09 -04:00
nm-setting-bridge.h libnm-core: change all mac-address properties to G_TYPE_STRING 2014-09-04 09:20:10 -04:00
nm-setting-cdma.c libnm: make use of GParamSpecFlags and GParamSpecEnum 2014-10-03 09:36:28 -04:00
nm-setting-cdma.h all: fix up multiple-include-guard defines 2014-08-16 10:17:14 -04:00
nm-setting-connection.c libnm-core: clean up NMConnectionError 2014-10-22 08:29:07 -04:00
nm-setting-connection.h libnm: add NMSettingConnection:autoconnect-priority setting 2014-10-12 20:13:17 +02:00
nm-setting-dcb.c libnm: make use of GParamSpecFlags and GParamSpecEnum 2014-10-03 09:36:28 -04:00
nm-setting-dcb.h libnm: make use of GParamSpecFlags and GParamSpecEnum 2014-10-03 09:36:28 -04:00
nm-setting-generic.c libnm-core: simplify _nm_register_setting(), register error types too 2014-09-04 09:18:44 -04:00
nm-setting-generic.h all: fix up multiple-include-guard defines 2014-08-16 10:17:14 -04:00
nm-setting-gsm.c libnm: make use of GParamSpecFlags and GParamSpecEnum 2014-10-03 09:36:28 -04:00
nm-setting-gsm.h libnm-core: drop previously-deprecated NMSetting properties 2014-09-04 09:17:37 -04:00
nm-setting-infiniband.c libnm-core: change connection hash tables to variants in API 2014-09-18 11:51:09 -04:00
nm-setting-infiniband.h libnm-core: change all mac-address properties to G_TYPE_STRING 2014-09-04 09:20:10 -04:00
nm-setting-ip4-config.c libnm-core: change connection hash tables to variants in API 2014-09-18 11:51:09 -04:00
nm-setting-ip4-config.h libnm-core: improve NMSettingIP4Config / NMSettingIP6Config property types 2014-09-04 09:20:11 -04:00
nm-setting-ip6-config.c libnm: make use of GParamSpecFlags and GParamSpecEnum 2014-10-03 09:36:28 -04:00
nm-setting-ip6-config.h libnm-core: improve NMSettingIP4Config / NMSettingIP6Config property types 2014-09-04 09:20:11 -04:00
nm-setting-olpc-mesh.c libnm-core: change connection hash tables to variants in API 2014-09-18 11:51:09 -04:00
nm-setting-olpc-mesh.h libnm-core: change DBUS_TYPE_G_UCHAR_ARRAY properties to G_TYPE_BYTES 2014-09-04 09:20:11 -04:00
nm-setting-ppp.c libnm-core: simplify _nm_register_setting(), register error types too 2014-09-04 09:18:44 -04:00
nm-setting-ppp.h all: fix up multiple-include-guard defines 2014-08-16 10:17:14 -04:00
nm-setting-pppoe.c libnm: make use of GParamSpecFlags and GParamSpecEnum 2014-10-03 09:36:28 -04:00
nm-setting-pppoe.h all: fix up multiple-include-guard defines 2014-08-16 10:17:14 -04:00
nm-setting-private.h libnm-core: clean up NMConnectionError 2014-10-22 08:29:07 -04:00
nm-setting-serial.c libnm-core: make NMSettingSerial:parity an enum 2014-10-03 09:36:28 -04:00
nm-setting-serial.h libnm-core: make NMSettingSerial:parity an enum 2014-10-03 09:36:28 -04:00
nm-setting-team-port.c libnm-core: clean up NMConnectionError 2014-10-22 08:29:07 -04:00
nm-setting-team-port.h all: fix up multiple-include-guard defines 2014-08-16 10:17:14 -04:00
nm-setting-team.c libnm-core: change connection hash tables to variants in API 2014-09-18 11:51:09 -04:00
nm-setting-team.h libnm-core: drop :interface-name properties on virtual NMSetting types 2014-09-04 09:18:44 -04:00
nm-setting-vlan.c libnm: make use of GParamSpecFlags and GParamSpecEnum 2014-10-03 09:36:28 -04:00
nm-setting-vlan.h libnm: make use of GParamSpecFlags and GParamSpecEnum 2014-10-03 09:36:28 -04:00
nm-setting-vpn.c libnm-util: don't assert in nm_setting_get_secret_flags() and avoid assertion in agent_secrets_done_cb() 2014-10-12 21:17:17 +02:00
nm-setting-vpn.h all: fix up multiple-include-guard defines 2014-08-16 10:17:14 -04:00
nm-setting-wimax.c libnm-core: change connection hash tables to variants in API 2014-09-18 11:51:09 -04:00
nm-setting-wimax.h libnm-core: change all mac-address properties to G_TYPE_STRING 2014-09-04 09:20:10 -04:00
nm-setting-wired.c libnm-core: change connection hash tables to variants in API 2014-09-18 11:51:09 -04:00
nm-setting-wired.h libnm-core: change list-of-string and array-of-string properties to G_TYPE_STRV 2014-09-04 09:20:10 -04:00
nm-setting-wireless-security.c libnm: make use of GParamSpecFlags and GParamSpecEnum 2014-10-03 09:36:28 -04:00
nm-setting-wireless-security.h all: fix up multiple-include-guard defines 2014-08-16 10:17:14 -04:00
nm-setting-wireless.c libnm-core: change connection hash tables to variants in API 2014-09-18 11:51:09 -04:00
nm-setting-wireless.h libnm-core: change DBUS_TYPE_G_UCHAR_ARRAY properties to G_TYPE_BYTES 2014-09-04 09:20:11 -04:00
nm-setting.c libnm-core: clean up NMConnectionError 2014-10-22 08:29:07 -04:00
nm-setting.h libnm-core: drop nm_setting_lookup_type_by_quark() 2014-10-22 08:29:07 -04:00
nm-simple-connection.c libnm-core: change connection hash tables to variants in API 2014-09-18 11:51:09 -04:00
nm-simple-connection.h libnm-core: change connection hash tables to variants in API 2014-09-18 11:51:09 -04:00
nm-utils-private.h libnm: port to GDBus 2014-09-18 11:51:09 -04:00
nm-utils.c libnm: make @copy_func argument in _nm_utils_copy_strdict() optional 2014-10-12 20:13:17 +02:00
nm-utils.h libnm-core: add nm_utils_wifi_strength_bars(), use it in nmcli and nmtui 2014-09-27 11:49:15 -04:00
nm-version.h.in libnm: add libnm/libnm-core (part 1) 2014-08-01 14:34:04 -04:00
nm-vpn-dbus-interface.h all: fix up multiple-include-guard defines 2014-08-16 10:17:14 -04:00