fdo-mirrors/NetworkManager
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/NetworkManager/NetworkManager.git synced 2025-12-24 18:20:07 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions
NetworkManager/libnm
History
Thomas Haller f45aeba402 libnm: deprecate nm_client_check_connectivity() in 1.22 
The previous commit marks all synchronous libnm API as deprecated.
In practice, the macro _NM_DEPRECATED_SYNC_METHOD expands to
nothing, because there is no immediate urgency to force users
to migrate.

However nm_client_check_connectivity() is especially bad: it
makes a synchronous call and then updates the content of the
cache artificially. Usually, NMClient's cache of D-Bus objects
is only updated by "PropertiesChanged" D-Bus signals.
nm_client_check_connectivity() instead will act on the response to
the "CheckConnectivity" D-Bus call -- a response that is picked
out of order from the ordered sequence of messages --  and will
update the cache instead of honoring the usual "PropertiesChanged"
signal.

I think such behavior is fundamentally broken. For a trivial property like
NM_CLIENT_CONNECTIVITY such behavior is odd at best. Note how applying
this approach to other functions (like nm_client_deactivate_connection(),
which would affect a much larger state) would not be feasible.

I also imagine it to be complicate to preserve this behavior when
reworking libnm, as I plan to do.

See also commit b799de281b ('libnm: update property in the manager
after connectivity check'), which introduced this behavior to "fix"
bgo#784629.
2019-10-03 10:46:49 +02:00
..
tests all: unify format of our Copyright source code comments 2019-10-02 17:03:52 +02:00
generate-plugin-docs.pl all: unify format of our Copyright source code comments 2019-10-02 17:03:52 +02:00
generate-setting-docs.py all: unify format of our Copyright source code comments 2019-10-02 17:03:52 +02:00
libnm.pc.in libnm,pkg-config: provide a variable with VPN service directory 2015-08-19 15:13:11 +02:00
libnm.ver libnm: add nm_client_reload() 2019-09-17 09:31:34 +02:00
meson.build meson: Ease the use of the libnm-libnm-core-intern library 2019-10-01 09:49:33 +02:00
NetworkManager.h all: unify format of our Copyright source code comments 2019-10-02 17:03:52 +02:00
nm-access-point.c all: unify format of our Copyright source code comments 2019-10-02 17:03:52 +02:00
nm-access-point.h all: unify format of our Copyright source code comments 2019-10-02 17:03:52 +02:00
nm-active-connection.c all: unify format of our Copyright source code comments 2019-10-02 17:03:52 +02:00
nm-active-connection.h all: unify format of our Copyright source code comments 2019-10-02 17:03:52 +02:00
nm-autoptr.h all: unify format of our Copyright source code comments 2019-10-02 17:03:52 +02:00
nm-checkpoint.c all: unify format of our Copyright source code comments 2019-10-02 17:03:52 +02:00
nm-checkpoint.h all: unify format of our Copyright source code comments 2019-10-02 17:03:52 +02:00
nm-client.c libnm: deprecate synchronous/blocking API in libnm 2019-10-03 10:39:48 +02:00
nm-client.h libnm: deprecate nm_client_check_connectivity() in 1.22 2019-10-03 10:46:49 +02:00
nm-dbus-helpers.c all: unify format of our Copyright source code comments 2019-10-02 17:03:52 +02:00
nm-dbus-helpers.h all: unify format of our Copyright source code comments 2019-10-02 17:03:52 +02:00
nm-device-6lowpan.c all: unify format of our Copyright source code comments 2019-10-02 17:03:52 +02:00
nm-device-6lowpan.h all: unify format of our Copyright source code comments 2019-10-02 17:03:52 +02:00
nm-device-adsl.c all: unify format of our Copyright source code comments 2019-10-02 17:03:52 +02:00
nm-device-adsl.h all: unify format of our Copyright source code comments 2019-10-02 17:03:52 +02:00
nm-device-bond.c all: unify format of our Copyright source code comments 2019-10-02 17:03:52 +02:00
nm-device-bond.h all: unify format of our Copyright source code comments 2019-10-02 17:03:52 +02:00
nm-device-bridge.c all: unify format of our Copyright source code comments 2019-10-02 17:03:52 +02:00
nm-device-bridge.h all: unify format of our Copyright source code comments 2019-10-02 17:03:52 +02:00
nm-device-bt.c all: unify format of our Copyright source code comments 2019-10-02 17:03:52 +02:00
nm-device-bt.h all: unify format of our Copyright source code comments 2019-10-02 17:03:52 +02:00
nm-device-dummy.c all: unify format of our Copyright source code comments 2019-10-02 17:03:52 +02:00
nm-device-dummy.h all: unify format of our Copyright source code comments 2019-10-02 17:03:52 +02:00
nm-device-ethernet.c all: unify format of our Copyright source code comments 2019-10-02 17:03:52 +02:00
nm-device-ethernet.h all: unify format of our Copyright source code comments 2019-10-02 17:03:52 +02:00
nm-device-generic.c all: unify format of our Copyright source code comments 2019-10-02 17:03:52 +02:00
nm-device-generic.h all: unify format of our Copyright source code comments 2019-10-02 17:03:52 +02:00
nm-device-infiniband.c all: unify format of our Copyright source code comments 2019-10-02 17:03:52 +02:00
nm-device-infiniband.h all: unify format of our Copyright source code comments 2019-10-02 17:03:52 +02:00
nm-device-ip-tunnel.c all: unify format of our Copyright source code comments 2019-10-02 17:03:52 +02:00
nm-device-ip-tunnel.h all: unify format of our Copyright source code comments 2019-10-02 17:03:52 +02:00
nm-device-macsec.c all: unify format of our Copyright source code comments 2019-10-02 17:03:52 +02:00
nm-device-macsec.h all: unify format of our Copyright source code comments 2019-10-02 17:03:52 +02:00
nm-device-macvlan.c all: unify format of our Copyright source code comments 2019-10-02 17:03:52 +02:00
nm-device-macvlan.h all: unify format of our Copyright source code comments 2019-10-02 17:03:52 +02:00
nm-device-modem.c all: unify format of our Copyright source code comments 2019-10-02 17:03:52 +02:00
nm-device-modem.h all: unify format of our Copyright source code comments 2019-10-02 17:03:52 +02:00
nm-device-olpc-mesh.c all: unify format of our Copyright source code comments 2019-10-02 17:03:52 +02:00
nm-device-olpc-mesh.h all: unify format of our Copyright source code comments 2019-10-02 17:03:52 +02:00
nm-device-ovs-bridge.c all: unify format of our Copyright source code comments 2019-10-02 17:03:52 +02:00
nm-device-ovs-bridge.h all: unify format of our Copyright source code comments 2019-10-02 17:03:52 +02:00
nm-device-ovs-interface.c all: unify format of our Copyright source code comments 2019-10-02 17:03:52 +02:00
nm-device-ovs-interface.h all: unify format of our Copyright source code comments 2019-10-02 17:03:52 +02:00
nm-device-ovs-port.c all: unify format of our Copyright source code comments 2019-10-02 17:03:52 +02:00
nm-device-ovs-port.h all: unify format of our Copyright source code comments 2019-10-02 17:03:52 +02:00
nm-device-ppp.c all: unify format of our Copyright source code comments 2019-10-02 17:03:52 +02:00
nm-device-ppp.h all: unify format of our Copyright source code comments 2019-10-02 17:03:52 +02:00
nm-device-private.h libnm: use the o.fd.DBus.ObjectManager API for object management 2016-11-10 16:48:48 +01:00
nm-device-team.c all: unify format of our Copyright source code comments 2019-10-02 17:03:52 +02:00
nm-device-team.h all: unify format of our Copyright source code comments 2019-10-02 17:03:52 +02:00
nm-device-tun.c all: unify format of our Copyright source code comments 2019-10-02 17:03:52 +02:00
nm-device-tun.h all: unify format of our Copyright source code comments 2019-10-02 17:03:52 +02:00
nm-device-vlan.c all: unify format of our Copyright source code comments 2019-10-02 17:03:52 +02:00
nm-device-vlan.h all: unify format of our Copyright source code comments 2019-10-02 17:03:52 +02:00
nm-device-vxlan.c all: unify format of our Copyright source code comments 2019-10-02 17:03:52 +02:00
nm-device-vxlan.h all: unify format of our Copyright source code comments 2019-10-02 17:03:52 +02:00
nm-device-wifi-p2p.c all: unify format of our Copyright source code comments 2019-10-02 17:03:52 +02:00
nm-device-wifi-p2p.h all: unify format of our Copyright source code comments 2019-10-02 17:03:52 +02:00
nm-device-wifi.c libnm: deprecate synchronous/blocking API in libnm 2019-10-03 10:39:48 +02:00
nm-device-wifi.h libnm: deprecate synchronous/blocking API in libnm 2019-10-03 10:39:48 +02:00
nm-device-wimax.c all: unify format of our Copyright source code comments 2019-10-02 17:03:52 +02:00
nm-device-wimax.h all: unify format of our Copyright source code comments 2019-10-02 17:03:52 +02:00
nm-device-wireguard.c all: unify format of our Copyright source code comments 2019-10-02 17:03:52 +02:00
nm-device-wireguard.h all: unify format of our Copyright source code comments 2019-10-02 17:03:52 +02:00
nm-device-wpan.c all: unify format of our Copyright source code comments 2019-10-02 17:03:52 +02:00
nm-device-wpan.h all: unify format of our Copyright source code comments 2019-10-02 17:03:52 +02:00
nm-device.c libnm: deprecate synchronous/blocking API in libnm 2019-10-03 10:39:48 +02:00
nm-device.h libnm: deprecate synchronous/blocking API in libnm 2019-10-03 10:39:48 +02:00
nm-dhcp-config.c all: unify format of our Copyright source code comments 2019-10-02 17:03:52 +02:00
nm-dhcp-config.h all: unify format of our Copyright source code comments 2019-10-02 17:03:52 +02:00
nm-dhcp4-config.c all: unify format of our Copyright source code comments 2019-10-02 17:03:52 +02:00
nm-dhcp4-config.h all: unify format of our Copyright source code comments 2019-10-02 17:03:52 +02:00
nm-dhcp6-config.c all: unify format of our Copyright source code comments 2019-10-02 17:03:52 +02:00
nm-dhcp6-config.h all: unify format of our Copyright source code comments 2019-10-02 17:03:52 +02:00
nm-dns-manager.c all: unify format of our Copyright source code comments 2019-10-02 17:03:52 +02:00
nm-dns-manager.h all: unify format of our Copyright source code comments 2019-10-02 17:03:52 +02:00
nm-enum-types.c.template build: use template files for enum types' sources generation 2017-12-18 11:25:06 +01:00
nm-enum-types.h.template build: use template files for enum types' sources generation 2017-12-18 11:25:06 +01:00
nm-ip-config.c all: unify format of our Copyright source code comments 2019-10-02 17:03:52 +02:00
nm-ip-config.h all: unify format of our Copyright source code comments 2019-10-02 17:03:52 +02:00
nm-ip4-config.c all: unify format of our Copyright source code comments 2019-10-02 17:03:52 +02:00
nm-ip4-config.h all: unify format of our Copyright source code comments 2019-10-02 17:03:52 +02:00
nm-ip6-config.c all: unify format of our Copyright source code comments 2019-10-02 17:03:52 +02:00
nm-ip6-config.h all: unify format of our Copyright source code comments 2019-10-02 17:03:52 +02:00
nm-libnm-utils.c all: unify format of our Copyright source code comments 2019-10-02 17:03:52 +02:00
nm-libnm-utils.h libnm: deprecate synchronous/blocking API in libnm 2019-10-03 10:39:48 +02:00
nm-manager.c all: unify format of our Copyright source code comments 2019-10-02 17:03:52 +02:00
nm-manager.h libnm: deprecate synchronous/blocking API in libnm 2019-10-03 10:39:48 +02:00
nm-object-private.h all: unify format of our Copyright source code comments 2019-10-02 17:03:52 +02:00
nm-object.c all: unify format of our Copyright source code comments 2019-10-02 17:03:52 +02:00
nm-object.h all: unify format of our Copyright source code comments 2019-10-02 17:03:52 +02:00
nm-remote-connection-private.h all: unify format of our Copyright source code comments 2019-10-02 17:03:52 +02:00
nm-remote-connection.c libnm: deprecate synchronous/blocking API in libnm 2019-10-03 10:39:48 +02:00
nm-remote-connection.h libnm: deprecate synchronous/blocking API in libnm 2019-10-03 10:39:48 +02:00
nm-remote-settings.c all: unify format of our Copyright source code comments 2019-10-02 17:03:52 +02:00
nm-remote-settings.h libnm: deprecate synchronous/blocking API in libnm 2019-10-03 10:39:48 +02:00
nm-secret-agent-old.c all: unify format of our Copyright source code comments 2019-10-02 17:03:52 +02:00
nm-secret-agent-old.h all: unify format of our Copyright source code comments 2019-10-02 17:03:52 +02:00
nm-types.h all: unify format of our Copyright source code comments 2019-10-02 17:03:52 +02:00
nm-vpn-connection.c all: unify format of our Copyright source code comments 2019-10-02 17:03:52 +02:00
nm-vpn-connection.h all: unify format of our Copyright source code comments 2019-10-02 17:03:52 +02:00
nm-vpn-editor.c all: unify format of our Copyright source code comments 2019-10-02 17:03:52 +02:00
nm-vpn-editor.h all: unify format of our Copyright source code comments 2019-10-02 17:03:52 +02:00
nm-vpn-plugin-old.c all: unify format of our Copyright source code comments 2019-10-02 17:03:52 +02:00
nm-vpn-plugin-old.h all: unify format of our Copyright source code comments 2019-10-02 17:03:52 +02:00
nm-vpn-service-plugin.c all: unify format of our Copyright source code comments 2019-10-02 17:03:52 +02:00
nm-vpn-service-plugin.h all: unify format of our Copyright source code comments 2019-10-02 17:03:52 +02:00
nm-wifi-p2p-peer.c all: unify format of our Copyright source code comments 2019-10-02 17:03:52 +02:00
nm-wifi-p2p-peer.h all: unify format of our Copyright source code comments 2019-10-02 17:03:52 +02:00
nm-wimax-nsp.c all: unify format of our Copyright source code comments 2019-10-02 17:03:52 +02:00
nm-wimax-nsp.h all: unify format of our Copyright source code comments 2019-10-02 17:03:52 +02:00