fdo-mirrors/NetworkManager
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/NetworkManager/NetworkManager.git synced 2025-12-30 00:20:11 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions
NetworkManager/libnm-util
History
Thomas Haller e1c7a2b5d0 all: don't use gchar/gshort/gint/glong but C types 
We commonly don't use the glib typedefs for char/short/int/long,
but their C types directly.

    $ git grep '\<g\(char\|short\|int\|long\|float\|double\)\>' | wc -l
    587
    $ git grep '\<\(char\|short\|int\|long\|float\|double\)\>' | wc -l
    21114

One could argue that using the glib typedefs is preferable in
public API (of our glib based libnm library) or where it clearly
is related to glib, like during

  g_object_set (obj, PROPERTY, (gint) value, NULL);

However, that argument does not seem strong, because in practice we don't
follow that argument today, and seldomly use the glib typedefs.
Also, the style guide for this would be hard to formalize, because
"using them where clearly related to a glib" is a very loose suggestion.

Also note that glib typedefs will always just be typedefs of the
underlying C types. There is no danger of glib changing the meaning
of these typedefs (because that would be a major API break of glib).

A simple style guide is instead: don't use these typedefs.

No manual actions, I only ran the bash script:

  FILES=($(git ls-files '*.[hc]'))
  sed -i \
      -e 's/\<g\(char\|short\|int\|long\|float\|double\)\>\( [^ ]\)/\1\2/g' \
      -e 's/\<g\(char\|short\|int\|long\|float\|double\)\>  /\1   /g' \
      -e 's/\<g\(char\|short\|int\|long\|float\|double\)\>/\1/g' \
      "${FILES[@]}"
2018-07-11 12:02:06 +02:00
..
tests build: use default NM_BUILD_* defines for tests 2018-05-31 15:59:38 +02:00
COPYING doc: fix FSF address (bgo #575625) 2009-09-10 21:03:30 -04:00
crypto.c all: remove consecutive empty lines 2018-04-30 16:24:52 +02:00
crypto.h all: cleanup includes in header files 2016-08-17 19:09:50 +02:00
crypto_gnutls.c libnm-util/crypto: fix harmless compiler warning 2018-05-24 11:35:59 +02:00
crypto_nss.c all: don't use gchar/gshort/gint/glong but C types 2018-07-11 12:02:06 +02:00
libnm-util.pc.in libnm-glib,libnm-util: -glib requires -util, -util requires NetworkManager 2013-03-14 10:23:19 -05:00
libnm-util.ver libnm-util: add non-failing versions of nm_connection_new_from_hash() and replace-settings 2016-03-29 11:56:27 +02:00
meson.build meson: run the check-export.sh in test phase 2018-06-28 20:38:52 +02:00
NetworkManager.h all: remove consecutive empty lines 2018-04-30 16:24:52 +02:00
NetworkManagerVPN.h all: remove consecutive empty lines 2018-04-30 16:24:52 +02:00
nm-connection.c all: use the elvis operator wherever possible 2018-05-10 14:36:58 +02:00
nm-connection.h include: use double-quotes to include our own headers 2017-03-09 14:12:35 +01:00
nm-dbus-glib-types.h core: final gdbus porting 2015-08-10 09:41:26 -04:00
nm-gvaluearray-compat.h nm-glib: remove G_GNUC_EXTENSION 2016-06-17 12:25:15 +02:00
nm-param-spec-specialized.c all: don't use gchar/gshort/gint/glong but C types 2018-07-11 12:02:06 +02:00
nm-param-spec-specialized.h all: cleanup includes in header files 2016-08-17 19:09:50 +02:00
nm-setting-8021x.c all: remove consecutive empty lines 2018-04-30 16:24:52 +02:00
nm-setting-8021x.h all: remove consecutive empty lines 2018-04-30 16:24:52 +02:00
nm-setting-adsl.c all: use the elvis operator wherever possible 2018-05-10 14:36:58 +02:00
nm-setting-adsl.h include: use double-quotes to include our own headers 2017-03-09 14:12:35 +01:00
nm-setting-bluetooth.c all: remove consecutive empty lines 2018-04-30 16:24:52 +02:00
nm-setting-bluetooth.h libnm-util, libnm-glib: standardize copyright/license headers 2014-07-15 09:44:54 -04:00
nm-setting-bond.c all: don't use gchar/gshort/gint/glong but C types 2018-07-11 12:02:06 +02:00
nm-setting-bond.h include: use double-quotes to include our own headers 2017-03-09 14:12:35 +01:00
nm-setting-bridge-port.c all: fix minor typos in settings docs 2017-07-03 21:23:27 +02:00
nm-setting-bridge-port.h include: use double-quotes to include our own headers 2017-03-09 14:12:35 +01:00
nm-setting-bridge.c all: remove consecutive empty lines 2018-04-30 16:24:52 +02:00
nm-setting-bridge.h include: use double-quotes to include our own headers 2017-03-09 14:12:35 +01:00
nm-setting-cdma.c all: remove consecutive empty lines 2018-04-30 16:24:52 +02:00
nm-setting-cdma.h include: use double-quotes to include our own headers 2017-03-09 14:12:35 +01:00
nm-setting-connection.c all: remove consecutive empty lines 2018-04-30 16:24:52 +02:00
nm-setting-connection.h libnm-util, libnm-glib: whitespace fixes 2014-07-15 09:44:55 -04:00
nm-setting-dcb.c all: don't use gchar/gshort/gint/glong but C types 2018-07-11 12:02:06 +02:00
nm-setting-dcb.h all: don't use gchar/gshort/gint/glong but C types 2018-07-11 12:02:06 +02:00
nm-setting-generic.c all: modify line separator comments to be 80 chars wide 2016-10-03 12:01:15 +02:00
nm-setting-generic.h include: use double-quotes to include our own headers 2017-03-09 14:12:35 +01:00
nm-setting-gsm.c all: remove consecutive empty lines 2018-04-30 16:24:52 +02:00
nm-setting-gsm.h include: use double-quotes to include our own headers 2017-03-09 14:12:35 +01:00
nm-setting-infiniband.c all: cleanup includes and let "nm-default.h" include "config.h" 2016-02-19 17:53:25 +01:00
nm-setting-infiniband.h include: use double-quotes to include our own headers 2017-03-09 14:12:35 +01:00
nm-setting-ip4-config.c all: remove consecutive empty lines 2018-04-30 16:24:52 +02:00
nm-setting-ip4-config.h all: remove consecutive empty lines 2018-04-30 16:24:52 +02:00
nm-setting-ip6-config.c all: remove consecutive empty lines 2018-04-30 16:24:52 +02:00
nm-setting-ip6-config.h all: remove consecutive empty lines 2018-04-30 16:24:52 +02:00
nm-setting-olpc-mesh.c all: cleanup includes and let "nm-default.h" include "config.h" 2016-02-19 17:53:25 +01:00
nm-setting-olpc-mesh.h include: use double-quotes to include our own headers 2017-03-09 14:12:35 +01:00
nm-setting-ppp.c all: remove consecutive empty lines 2018-04-30 16:24:52 +02:00
nm-setting-ppp.h include: use double-quotes to include our own headers 2017-03-09 14:12:35 +01:00
nm-setting-pppoe.c all: remove consecutive empty lines 2018-04-30 16:24:52 +02:00
nm-setting-pppoe.h include: use double-quotes to include our own headers 2017-03-09 14:12:35 +01:00
nm-setting-private.h all: don't use gchar/gshort/gint/glong but C types 2018-07-11 12:02:06 +02:00
nm-setting-serial.c all: remove consecutive empty lines 2018-04-30 16:24:52 +02:00
nm-setting-serial.h include: use double-quotes to include our own headers 2017-03-09 14:12:35 +01:00
nm-setting-team-port.c all: cleanup includes and let "nm-default.h" include "config.h" 2016-02-19 17:53:25 +01:00
nm-setting-team-port.h include: use double-quotes to include our own headers 2017-03-09 14:12:35 +01:00
nm-setting-team.c all: remove consecutive empty lines 2018-04-30 16:24:52 +02:00
nm-setting-team.h include: use double-quotes to include our own headers 2017-03-09 14:12:35 +01:00
nm-setting-vlan.c all: don't use gchar/gshort/gint/glong but C types 2018-07-11 12:02:06 +02:00
nm-setting-vlan.h vlan: (all) add VLAN MVRP flag 2015-10-27 17:17:05 +01:00
nm-setting-vpn.c all: remove consecutive empty lines 2018-04-30 16:24:52 +02:00
nm-setting-vpn.h include: use double-quotes to include our own headers 2017-03-09 14:12:35 +01:00
nm-setting-wimax.c all: remove consecutive empty lines 2018-04-30 16:24:52 +02:00
nm-setting-wimax.h include: use double-quotes to include our own headers 2017-03-09 14:12:35 +01:00
nm-setting-wired.c all: remove consecutive empty lines 2018-04-30 16:24:52 +02:00
nm-setting-wired.h include: use double-quotes to include our own headers 2017-03-09 14:12:35 +01:00
nm-setting-wireless-security.c all: remove consecutive empty lines 2018-04-30 16:24:52 +02:00
nm-setting-wireless-security.h include: use double-quotes to include our own headers 2017-03-09 14:12:35 +01:00
nm-setting-wireless.c all: remove consecutive empty lines 2018-04-30 16:24:52 +02:00
nm-setting-wireless.h include: use double-quotes to include our own headers 2017-03-09 14:12:35 +01:00
nm-setting.c all: don't use gchar/gshort/gint/glong but C types 2018-07-11 12:02:06 +02:00
nm-setting.h all: don't use gchar/gshort/gint/glong but C types 2018-07-11 12:02:06 +02:00
nm-utils-enum-types.c.template build: use template files for enum types' sources generation 2017-12-18 11:25:06 +01:00
nm-utils-enum-types.h.template build: use template files for enum types' sources generation 2017-12-18 11:25:06 +01:00
nm-utils-private.h all: replace _nm_utils_string_in_list() with g_strv_contains() 2016-06-17 12:25:33 +02:00
nm-utils.c all: don't use gchar/gshort/gint/glong but C types 2018-07-11 12:02:06 +02:00
nm-utils.h libnm: add function nm_utils_file_search_in_paths() 2014-12-05 11:07:42 +01:00
nm-value-transforms.c all: use the elvis operator wherever possible 2018-05-10 14:36:58 +02:00
nm-version.h version: rename macro NM_VERSION_CUR_STABLE to NM_API_VERSION 2018-01-23 10:54:11 +01:00