Alfonso Sánchez-Beato 3caa065709 core/pppd-plugin: wait to recover port settings before notifying death ... pppd restores the previous settings for the serial port it uses right before exiting. It is especially important to do so because otherwise ModemManager is not able to recover the port as it can receive a hangup event from the port due to CLOCAL not being restored. However, there is currently a race condition that produces this issue. This is because when PHASE_DEAD is notified, pppd still has not restored the port settings - it does that a bit later, in the die() function. This patch delays notifying PHASE_DEAD until when the exitnotify() hook is called by pppd: when this happens the port settings have already been restored. There were previously efforts to fix this in commit fe090c34b7, so PHASE_DEAD was used instead of PHASE_DISCONNECT to notify MM that the port was disconnected, but that still early to ensure that the port settings are restored. The MM traces seen when the bug is triggered are: ModemManager[2158]: <warn> (ttyACM1): could not re-acquire serial port lock: (5) Input/output error ModemManager[2158]: <warn> Couldn't load Operator Code: 'Cannot run sequence: 'Could not open serial device ttyACM1: it has been forced close' https://mail.gnome.org/archives/networkmanager-list/2019-June/msg00014.html (cherry picked from commit a251712a72)		2019-06-14 13:32:57 +02:00
..
meson.build	build/meson: rename "nm_core_dep" to "libnm_core_dep"	2019-04-18 20:13:49 +02:00
nm-ppp-manager-call.c	all: drop unnecessary includes of <errno.h> and <string.h>	2019-02-12 08:50:28 +01:00
nm-ppp-manager-call.h	ppp: make ppp-manager cancellable via GCancellable	2018-10-17 13:03:50 +02:00
nm-ppp-manager.c	all: replace strerror() calls with nm_strerror_native()	2019-02-12 08:50:28 +01:00
nm-ppp-manager.h	ppp-manager: rework stopping NMPPPManager by merging async/sync methods	2018-05-25 12:35:49 +02:00
nm-ppp-plugin-api.h	ppp: make ppp-manager cancellable via GCancellable	2018-10-17 13:03:50 +02:00
nm-ppp-plugin.ver	ppp: split ppp manager into a plugin	2016-12-06 11:08:11 +01:00
nm-ppp-status.h	ppp: split ppp manager into a plugin	2016-12-06 11:08:11 +01:00
nm-pppd-plugin.c	core/pppd-plugin: wait to recover port settings before notifying death	2019-06-14 13:32:57 +02:00
nm-pppd-plugin.h	build: rename "src/ppp-manager" to "src/ppp"	2016-11-21 14:07:47 +01:00