fdo-mirrors/NetworkManager
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/NetworkManager/NetworkManager.git synced 2026-05-14 21:18:07 +02:00
Code Issues Projects Releases Packages Wiki Activity Actions
NetworkManager/src
History
Thomas Haller a685ec45dd device: fix reapplying changes to connection ID and UUID 
4 properties are not really relevant for an already activated connection
or it makes not sense to change them. These are connection.id, connection.uuid,
connection.autoconnect and connection.stable-id.

For convenience, we allow to reapply these. This way, one can take
a different setting (e.g. with a different connection.id or
connection.uuid) and reapply them, but such changes are silently
ignored.

However this was done wrongly. Instead of reverting the change to the new
applied connection, we would change the input connection.

This is bad, for example with

  nmcli connection up uuid cb922f18-e99a-49c6-b200-1678b5070a82
  nmcli connection modify cb922f18-e99a-49c6-b200-1678b5070a82 con-name "bogus"
  nmcli device reapply eth0

the last re-apply would reset the settings-connection's connection ID to
what was before, while accepting the new name on the applied-connection
(while it should have been rejected).

Fixes: bf3b3d444c ('device: avoid changing immutable properties during reapply')

(cherry picked from commit adb51c2a7f)
(cherry picked from commit 09f37d5bd4)
(cherry picked from commit 9c72ca5ee9)
(cherry picked from commit b1209e37db)
(cherry picked from commit cacb80e567)
(cherry picked from commit 0e8fb0add0)
(cherry picked from commit 932efa7a90)
2019-07-18 12:22:57 +02:00
..
devices device: fix reapplying changes to connection ID and UUID 2019-07-18 12:22:57 +02:00
dhcp dhcp: fix leak in dhclient's dhclient_start() 2018-09-10 14:40:04 +02:00
dns dns/resolved: consider configuration from unmanaged devices 2017-02-24 21:13:16 +01:00
dnsmasq build: don't add subdirectories to include search path but require qualified include 2016-11-21 14:26:37 +01:00
ndisc device: support dynamic "connection.stable-id" in form of text-substitution 2017-01-09 14:50:33 +01:00
platform platform/tests: relax checking for signals in test-address-linux 2018-01-08 16:52:04 +01:00
ppp ppp: only request IPV6CP when IPv6 is enabled in the connection 2017-03-22 08:36:16 -05:00
settings ifnet: avoid compiler warning about casting function pointers 2018-11-15 15:16:32 +01:00
supplicant wifi: don't use :1 bitfield for gboolean type 2018-08-26 18:35:17 +02:00
systemd systemd: fix crash by unrefing event sources before re-adding them 2018-11-15 15:16:32 +01:00
tests all: cleanup switch fall-through comments for -Wimplicit-fallthrough warning 2017-02-06 17:54:45 +01:00
vpn all: cleanup switch fall-through comments for -Wimplicit-fallthrough warning 2017-02-06 17:54:45 +01:00
main-utils.c all: use O_CLOEXEC for file descriptors 2016-12-13 11:26:59 +01:00
main-utils.h all: cleanup includes in header files 2016-08-17 19:51:17 +02:00
main.c main: fix compiler warning about uninitialized auto variable in _init_nm_debug() 2016-11-25 20:17:58 +01:00
NetworkManagerUtils.c build: don't add subdirectories to include search path but require qualified include 2016-11-21 14:26:37 +01:00
NetworkManagerUtils.h utils: inject platform into nm_utils_complete_generic() 2016-03-15 12:56:58 +01:00
nm-act-request.c act-request: return empty properties when not activated 2017-01-19 14:23:38 +01:00
nm-act-request.h act-request: allow omitting the @self argument in nm_act_request_cancel_secrets() 2016-12-20 15:53:41 +01:00
nm-active-connection.c device: refactor pending-action strings as named defines 2017-02-10 14:47:18 +01:00
nm-active-connection.h core: refactor private data for NMExportedObject and others 2016-10-03 12:04:14 +02:00
nm-audit-manager.c build: don't add subdirectories to include search path but require qualified include 2016-11-21 14:26:37 +01:00
nm-audit-manager.h build: don't add subdirectories to include search path but require qualified include 2016-11-21 14:26:37 +01:00
nm-auth-manager.c ip[46]-config/trivial: move code around 2017-01-16 17:24:36 +01:00
nm-auth-manager.h core: refactor private data in "src" 2016-10-04 09:50:56 +02:00
nm-auth-subject.c src: drop generated nm-src-enum-types.h 2016-10-22 17:16:17 +02:00
nm-auth-subject.h auth: embed private data NMAuthSubjectPrivate in NMAuthSubject struct 2016-05-12 10:24:36 +02:00
nm-auth-utils.c auth-utils: fix possibly uninitialized variables 2017-04-07 11:53:16 -05:00
nm-auth-utils.h all: move NM_AUTH_PERMISSION_* defines to "nm-common-macros.h" header 2016-06-01 19:06:35 +02:00
nm-bus-manager.c bus-manager: don't leak connections 2017-10-15 10:24:51 +02:00
nm-bus-manager.h core: refactor private data in "src" 2016-10-04 09:50:56 +02:00
nm-checkpoint-manager.c build: don't add subdirectories to include search path but require qualified include 2016-11-21 14:26:37 +01:00
nm-checkpoint-manager.h core: refactor private data in "src" 2016-10-04 09:50:56 +02:00
nm-checkpoint.c exported-object: use NM_EXPORT_PATH_NUMBERED() macro 2017-01-03 15:40:17 +01:00
nm-checkpoint.h checkpoint: introduce new flags to better restore previous state 2016-10-24 09:57:18 +02:00
nm-config-data.c build: fix -Wignored-qualifiers warnings 2017-02-06 19:42:43 +01:00
nm-config-data.h build: fix -Wignored-qualifiers warnings 2017-02-06 19:42:43 +01:00
nm-config.c all: cleanup switch fall-through comments for -Wimplicit-fallthrough warning 2017-02-06 17:54:45 +01:00
nm-config.h config: drop nm_config_get_debug() and access config directly 2016-11-25 18:02:38 +01:00
nm-connectivity.c core: introduce default logging macros 2016-10-14 15:57:43 +02:00
nm-connectivity.h core: refactor private data in "src" 2016-10-04 09:50:56 +02:00
nm-core-utils.c core: don't close input fd in nm_utils_fd_get_contents() 2017-10-19 09:08:20 +02:00
nm-core-utils.h core: refactor evaluation of device's match-spec 2017-01-20 21:18:30 +01:00
nm-dcb.c build: don't add subdirectories to include search path but require qualified include 2016-11-21 14:26:37 +01:00
nm-dcb.h all: cleanup includes in header files 2016-08-17 19:51:17 +02:00
nm-default-route-manager.c default-route-manager: fix possibly uninitialized variable 2017-04-07 11:34:07 -05:00
nm-default-route-manager.h default-route-manager: add nm_default_route_manager_resync() function 2017-04-03 13:23:43 +02:00
nm-dhcp4-config.c exported-object: use NM_EXPORT_PATH_NUMBERED() macro 2017-01-03 15:40:17 +01:00
nm-dhcp4-config.h core: refactor private data in "src" 2016-10-04 09:50:56 +02:00
nm-dhcp6-config.c exported-object: use NM_EXPORT_PATH_NUMBERED() macro 2017-01-03 15:40:17 +01:00
nm-dhcp6-config.h core: refactor private data in "src" 2016-10-04 09:50:56 +02:00
nm-dispatcher.c build: don't add subdirectories to include search path but require qualified include 2016-11-21 14:26:37 +01:00
nm-dispatcher.h src: Fixes to add Proxy Feature 2016-10-04 11:44:44 +02:00
nm-exported-object.c exported-object: fix adding get_property() function for "path" property 2017-01-25 17:19:16 +01:00
nm-exported-object.h exported-object: add "path" GObject property to have notify signal 2017-01-25 17:19:11 +01:00
nm-firewall-manager.c core: refactor private data in "src" 2016-10-04 09:50:56 +02:00
nm-firewall-manager.h core: refactor private data in "src" 2016-10-04 09:50:56 +02:00
nm-iface-helper.c iface-helper: don't cache nm_platform_check_support_kernel_extended_ifa_flags() flag 2017-01-10 14:29:46 +01:00
nm-ip4-config.c ip4-config: cleanup MTU handling 2017-01-16 17:29:44 +01:00
nm-ip4-config.h ip4-config: sort addresses only when reading the property value 2016-12-05 10:56:51 +01:00
nm-ip6-config.c ip[46]-config: reorder fields in private struct and use bool bitfield 2017-01-16 17:24:36 +01:00
nm-ip6-config.h ip6-config: add nm_ip6_config_set_privacy() 2016-12-05 10:56:51 +01:00
nm-logging.c logging: preserve errno in logging functions 2016-12-13 11:26:58 +01:00
nm-logging.h core: introduce default logging macros 2016-10-14 15:57:43 +02:00
nm-manager.c device: fix restricting Generic connection by interface-name 2017-04-26 21:10:15 +02:00
nm-manager.h manager: avoid an extra path to ac translation 2017-01-27 13:34:16 +01:00
nm-multi-index.c all: modify line separator comments to be 80 chars wide 2016-10-03 12:01:15 +02:00
nm-multi-index.h all: cleanup includes in header files 2016-08-17 19:51:17 +02:00
nm-pacrunner-manager.c pacrunner: fix a few typos, uniforms spelling of various forms to "pacrunner" 2017-01-17 14:27:31 +01:00
nm-pacrunner-manager.h proxy: rename NMPacRunnerManager to NMPacrunnerManager 2016-10-04 12:14:15 +02:00
nm-policy.c policy: fix memleak in lookup_callback() and cancelling 2017-05-02 18:27:16 +02:00
nm-policy.h core: refactor private data in "src" 2016-10-04 09:50:56 +02:00
nm-proxy-config.c proxy: reorder parts in nm-proxy-config.c and nm-pacrunner-manager.c 2016-10-04 11:58:32 +02:00
nm-proxy-config.h proxy: remove unnecessary APIs 2016-10-04 11:44:44 +02:00
nm-rfkill-manager.c build: fix -Wignored-qualifiers warnings 2017-02-06 19:42:43 +01:00
nm-rfkill-manager.h core: refactor private data in "src" 2016-10-04 09:50:56 +02:00
nm-route-manager.c build: don't add subdirectories to include search path but require qualified include 2016-11-21 14:26:37 +01:00
nm-route-manager.h core: refactor private data in "src" 2016-10-04 09:50:56 +02:00
nm-session-monitor.c session-monitor: fix a -Wcast-function-type warning 2018-11-15 15:15:39 +01:00
nm-session-monitor.h core: refactor private data in "src" 2016-10-04 09:50:56 +02:00
nm-sleep-monitor.c core: introduce default logging macros 2016-10-14 15:57:43 +02:00
nm-sleep-monitor.h core: refactor private data in "src" 2016-10-04 09:50:56 +02:00
nm-test-utils-core.h shared: move shared files to subdirectory "shared/nm-utils/" 2016-06-16 10:45:53 +02:00
nm-types.h platform: add support for macsec links 2017-01-16 17:37:14 +01:00
org.freedesktop.NetworkManager.conf dns: use DBus to make dnsmasq nameserver changes 2016-04-21 15:32:07 +02:00