NetworkManager/libnm
Jiří Klimeš 0c97448a91 agent: don't clear "error", g_simple_async_result_take_error() overtakes it
From valgrind:
==21921== Invalid free() / delete / delete[] / realloc()
==21921==    at 0x4C2CD5A: free (vg_replace_malloc.c:530)
==21921==    by 0x81C4F2D: g_free (gmem.c:189)
==21921==    by 0x81AB021: g_error_free (gerror.c:491)
==21921==    by 0x81AB325: g_clear_error (gerror.c:674)
==21921==    by 0x767B555: reg_request_cb (nm-secret-agent-old.c:616)
==21921==    by 0x7A211F2: g_task_return_now (gtask.c:1107)
==21921==    by 0x7A21228: complete_in_idle_cb (gtask.c:1121)
==21921==    by 0x81BF6B9: g_main_dispatch (gmain.c:3154)
==21921==    by 0x81BF6B9: g_main_context_dispatch (gmain.c:3769)
==21921==    by 0x81BFA6F: g_main_context_iterate.isra.29 (gmain.c:3840)
==21921==    by 0x81BFB1B: g_main_context_iteration (gmain.c:3901)
==21921==    by 0x7A4748C: g_application_run (gapplication.c:2381)
==21921==    by 0x118AEF: main (main.c:81)

It caused memory corruption and may result in strange nm-applet crashes.

(cherry picked from commit 544f7d3683)
(cherry picked from commit eb9b2de778)
2016-11-25 15:41:23 +01:00
..
tests build: disable deprecation checks for internal compilation 2016-04-05 22:22:58 +02:00
generate-plugin-docs.pl trivial: fix a comment typo in generate-plugin-docs.pl 2014-11-19 17:54:03 +01:00
generate-setting-docs.py python: use gi.require_version() in generate-setting-docs.py and examples 2015-11-11 10:56:05 +01:00
libnm.pc.in libnm,pkg-config: provide a variable with VPN service directory 2015-08-19 15:13:11 +02:00
libnm.ver libnm-core: add dns-priority to NMSettingIPConfig 2016-06-10 11:14:36 +02:00
Makefile.am libnm: link with libdl 2016-08-01 17:05:45 +02:00
NetworkManager.h libnm: include "nm-vpn-service-plugin.h" in "NetworkManager.h" 2016-01-27 17:20:09 +01:00
nm-access-point.c all: cleanup includes and let "nm-default.h" include "config.h" 2016-02-19 17:53:25 +01:00
nm-access-point.h docs: libnm: add doc comment to types 2016-05-07 15:34:30 +02:00
nm-active-connection.c all: cleanup includes and let "nm-default.h" include "config.h" 2016-02-19 17:53:25 +01:00
nm-active-connection.h docs: libnm: add doc comment to types 2016-05-07 15:34:30 +02:00
nm-client.c libnm: fix introspection annotations for nm_client_load_connections() 2016-08-04 13:59:24 +02:00
nm-client.h manager: add Reload() D-Bus command 2016-06-10 11:14:38 +02:00
nm-dbus-helpers.c all: cleanup includes and let "nm-default.h" include "config.h" 2016-02-19 17:53:25 +01:00
nm-dbus-helpers.h all: make use of new header file "nm-default.h" 2015-08-05 15:32:40 +02:00
nm-device-adsl.c all: cleanup includes and let "nm-default.h" include "config.h" 2016-02-19 17:53:25 +01:00
nm-device-adsl.h docs: libnm: add doc comment to types 2016-05-07 15:34:30 +02:00
nm-device-bond.c all: cleanup includes and let "nm-default.h" include "config.h" 2016-02-19 17:53:25 +01:00
nm-device-bond.h docs: libnm: add doc comment to types 2016-05-07 15:34:30 +02:00
nm-device-bridge.c all: cleanup includes and let "nm-default.h" include "config.h" 2016-02-19 17:53:25 +01:00
nm-device-bridge.h docs: libnm: add doc comment to types 2016-05-07 15:34:30 +02:00
nm-device-bt.c all: cleanup includes and let "nm-default.h" include "config.h" 2016-02-19 17:53:25 +01:00
nm-device-bt.h docs: libnm: add doc comment to types 2016-05-07 15:34:30 +02:00
nm-device-ethernet.c all: cleanup includes and let "nm-default.h" include "config.h" 2016-02-19 17:53:25 +01:00
nm-device-ethernet.h docs: libnm: add doc comment to types 2016-05-07 15:34:30 +02:00
nm-device-generic.c all: cleanup includes and let "nm-default.h" include "config.h" 2016-02-19 17:53:25 +01:00
nm-device-generic.h docs: libnm: add doc comment to types 2016-05-07 15:34:30 +02:00
nm-device-infiniband.c all: cleanup includes and let "nm-default.h" include "config.h" 2016-02-19 17:53:25 +01:00
nm-device-infiniband.h docs: libnm: add doc comment to types 2016-05-07 15:34:30 +02:00
nm-device-ip-tunnel.c all: cleanup includes and let "nm-default.h" include "config.h" 2016-02-19 17:53:25 +01:00
nm-device-ip-tunnel.h docs: libnm: add doc comment to types 2016-05-07 15:34:30 +02:00
nm-device-macvlan.c all: cleanup includes and let "nm-default.h" include "config.h" 2016-02-19 17:53:25 +01:00
nm-device-macvlan.h docs: libnm: add doc comment to types 2016-05-07 15:34:30 +02:00
nm-device-modem.c all: cleanup includes and let "nm-default.h" include "config.h" 2016-02-19 17:53:25 +01:00
nm-device-modem.h docs: libnm: add doc comment to types 2016-05-07 15:34:30 +02:00
nm-device-olpc-mesh.c all: cleanup includes and let "nm-default.h" include "config.h" 2016-02-19 17:53:25 +01:00
nm-device-olpc-mesh.h docs: libnm: add doc comment to types 2016-05-07 15:34:30 +02:00
nm-device-private.h all: fix up multiple-include-guard defines 2014-08-16 10:17:14 -04:00
nm-device-team.c all: cleanup includes and let "nm-default.h" include "config.h" 2016-02-19 17:53:25 +01:00
nm-device-team.h docs: libnm: add doc comment to types 2016-05-07 15:34:30 +02:00
nm-device-tun.c all: cleanup includes and let "nm-default.h" include "config.h" 2016-02-19 17:53:25 +01:00
nm-device-tun.h docs: libnm: add doc comment to types 2016-05-07 15:34:30 +02:00
nm-device-vlan.c libnm: avoid possibly NULL address for NMDeviceVlan calling nm_utils_hwaddr_matches() 2016-10-24 10:43:35 +02:00
nm-device-vlan.h docs: libnm: add doc comment to types 2016-05-07 15:34:30 +02:00
nm-device-vxlan.c libnm: fix memleak in NMDeviceVxlan 2016-10-24 10:43:33 +02:00
nm-device-vxlan.h docs: libnm: add doc comment to types 2016-05-07 15:34:30 +02:00
nm-device-wifi.c all: cleanup includes and let "nm-default.h" include "config.h" 2016-02-19 17:53:25 +01:00
nm-device-wifi.h docs: libnm: add doc comment to types 2016-05-07 15:34:30 +02:00
nm-device-wimax.c all: cleanup includes and let "nm-default.h" include "config.h" 2016-02-19 17:53:25 +01:00
nm-device-wimax.h docs: libnm: add doc comment to types 2016-05-07 15:34:30 +02:00
nm-device.c libnm/libnm-glib: use Bluetooth device name as description (bgo #592819) 2016-06-21 10:36:45 -05:00
nm-device.h docs: libnm: add doc comment to types 2016-05-07 15:34:30 +02:00
nm-dhcp-config.c all: cleanup includes and let "nm-default.h" include "config.h" 2016-02-19 17:53:25 +01:00
nm-dhcp-config.h docs: libnm: add doc comment to types 2016-05-07 15:34:30 +02:00
nm-dhcp4-config.c all: cleanup includes and let "nm-default.h" include "config.h" 2016-02-19 17:53:25 +01:00
nm-dhcp4-config.h docs: libnm: add doc comment to types 2016-05-07 15:34:30 +02:00
nm-dhcp6-config.c all: cleanup includes and let "nm-default.h" include "config.h" 2016-02-19 17:53:25 +01:00
nm-dhcp6-config.h docs: libnm: add doc comment to types 2016-05-07 15:34:30 +02:00
nm-ip-config.c all: cleanup includes and let "nm-default.h" include "config.h" 2016-02-19 17:53:25 +01:00
nm-ip-config.h docs: libnm: add doc comment to types 2016-05-07 15:34:30 +02:00
nm-ip4-config.c all: cleanup includes and let "nm-default.h" include "config.h" 2016-02-19 17:53:25 +01:00
nm-ip4-config.h docs: libnm: add doc comment to types 2016-05-07 15:34:30 +02:00
nm-ip6-config.c all: cleanup includes and let "nm-default.h" include "config.h" 2016-02-19 17:53:25 +01:00
nm-ip6-config.h docs: libnm: add doc comment to types 2016-05-07 15:34:30 +02:00
nm-manager.c libnm: disconnect devices' signals when disposing manager 2016-10-14 10:53:09 +02:00
nm-manager.h docs: libnm: add doc comment to types 2016-05-07 15:34:30 +02:00
nm-object-cache.c all: cleanup includes and let "nm-default.h" include "config.h" 2016-02-19 17:53:25 +01:00
nm-object-cache.h all: make use of new header file "nm-default.h" 2015-08-05 15:32:40 +02:00
nm-object-private.h all: make use of new header file "nm-default.h" 2015-08-05 15:32:40 +02:00
nm-object.c nm-object: delay object property completion until the objects are initialized 2016-03-14 16:32:44 +01:00
nm-object.h docs: libnm: add doc comment to types 2016-05-07 15:34:30 +02:00
nm-remote-connection-private.h libnm: add libnm/libnm-core (part 1) 2014-08-01 14:34:04 -04:00
nm-remote-connection.c libnm: be more accepting for invalid connections from NetworkManager 2016-03-26 12:10:54 +01:00
nm-remote-connection.h docs: libnm: add doc comment to types 2016-05-07 15:34:30 +02:00
nm-remote-settings.c all: cleanup includes and let "nm-default.h" include "config.h" 2016-02-19 17:53:25 +01:00
nm-remote-settings.h docs: libnm: add doc comment to types 2016-05-07 15:34:30 +02:00
nm-secret-agent-old.c agent: don't clear "error", g_simple_async_result_take_error() overtakes it 2016-11-25 15:41:23 +01:00
nm-secret-agent-old.h docs: libnm: add doc comment to types 2016-05-07 15:34:30 +02:00
nm-types.h libnm: add NMDeviceVxlan 2015-12-09 16:36:46 +01:00
nm-vpn-connection.c all: cleanup includes and let "nm-default.h" include "config.h" 2016-02-19 17:53:25 +01:00
nm-vpn-connection.h docs: libnm: add doc comment to types 2016-05-07 15:34:30 +02:00
nm-vpn-editor.c all: cleanup includes and let "nm-default.h" include "config.h" 2016-02-19 17:53:25 +01:00
nm-vpn-editor.h libnm: move NMVpnEditorPlugin to libnm-core/ 2015-07-29 22:34:35 +02:00
nm-vpn-plugin-old.c libnm: accept invalid connections in NMVpnServicePlugin 2016-03-26 12:10:54 +01:00
nm-vpn-plugin-old.h docs: libnm: add doc comment to types 2016-05-07 15:34:30 +02:00
nm-vpn-service-plugin.c libnm/vpn-service-plugin: don't register a bus name before creating the VPN object 2016-04-20 10:50:14 +02:00
nm-vpn-service-plugin.h docs: libnm: add doc comment to types 2016-05-07 15:34:30 +02:00
nm-wimax-nsp.c all: cleanup includes and let "nm-default.h" include "config.h" 2016-02-19 17:53:25 +01:00
nm-wimax-nsp.h docs: libnm: add doc comment to types 2016-05-07 15:34:30 +02:00