fdo-mirrors/NetworkManager
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/NetworkManager/NetworkManager.git synced 2026-03-28 21:30:57 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions
NetworkManager/clients/tui
History
Thomas Haller e1c7a2b5d0 all: don't use gchar/gshort/gint/glong but C types 
We commonly don't use the glib typedefs for char/short/int/long,
but their C types directly.

    $ git grep '\<g\(char\|short\|int\|long\|float\|double\)\>' | wc -l
    587
    $ git grep '\<\(char\|short\|int\|long\|float\|double\)\>' | wc -l
    21114

One could argue that using the glib typedefs is preferable in
public API (of our glib based libnm library) or where it clearly
is related to glib, like during

  g_object_set (obj, PROPERTY, (gint) value, NULL);

However, that argument does not seem strong, because in practice we don't
follow that argument today, and seldomly use the glib typedefs.
Also, the style guide for this would be hard to formalize, because
"using them where clearly related to a glib" is a very loose suggestion.

Also note that glib typedefs will always just be typedefs of the
underlying C types. There is no danger of glib changing the meaning
of these typedefs (because that would be a major API break of glib).

A simple style guide is instead: don't use these typedefs.

No manual actions, I only ran the bash script:

  FILES=($(git ls-files '*.[hc]'))
  sed -i \
      -e 's/\<g\(char\|short\|int\|long\|float\|double\)\>\( [^ ]\)/\1\2/g' \
      -e 's/\<g\(char\|short\|int\|long\|float\|double\)\>  /\1   /g' \
      -e 's/\<g\(char\|short\|int\|long\|float\|double\)\>/\1/g' \
      "${FILES[@]}"
2018-07-11 12:02:06 +02:00
..
newt all: use the elvis operator wherever possible 2018-05-10 14:36:58 +02:00
meson.build build: unifiy specifying locale directory define 2018-05-31 15:59:38 +02:00
nm-editor-bindings.c all: don't use gchar/gshort/gint/glong but C types 2018-07-11 12:02:06 +02:00
nm-editor-bindings.h all: don't use gchar/gshort/gint/glong but C types 2018-07-11 12:02:06 +02:00
nm-editor-utils.c all: don't use gchar/gshort/gint/glong but C types 2018-07-11 12:02:06 +02:00
nm-editor-utils.h clients: drop redundant #include "NetworkManager.h" 2018-01-08 12:38:54 +01:00
nmt-address-list.c all: cleanup includes and let "nm-default.h" include "config.h" 2016-02-19 17:53:25 +01:00
nmt-address-list.h all: cleanup includes in header files 2016-08-17 19:51:17 +02:00
nmt-connect-connection-list.c all: use the elvis operator wherever possible 2018-05-10 14:36:58 +02:00
nmt-connect-connection-list.h all: cleanup includes in header files 2016-08-17 19:51:17 +02:00
nmt-device-entry.c clients: drop redundant #include "NetworkManager.h" 2018-01-08 12:38:54 +01:00
nmt-device-entry.h clients: drop redundant #include "NetworkManager.h" 2018-01-08 12:38:54 +01:00
nmt-edit-connection-list.c all: remove consecutive empty lines 2018-04-30 16:24:52 +02:00
nmt-edit-connection-list.h clients: drop redundant #include "NetworkManager.h" 2018-01-08 12:38:54 +01:00
nmt-editor-grid.c all: remove consecutive empty lines 2018-04-30 16:24:52 +02:00
nmt-editor-grid.h all: cleanup includes in header files 2016-08-17 19:51:17 +02:00
nmt-editor-page-device.c all: cleanup includes and let "nm-default.h" include "config.h" 2016-02-19 17:53:25 +01:00
nmt-editor-page-device.h all: cleanup includes in header files 2016-08-17 19:51:17 +02:00
nmt-editor-page.c tui/editor: notify the pages after the connection is saved 2017-02-27 11:17:39 +01:00
nmt-editor-page.h clients: drop redundant #include "NetworkManager.h" 2018-01-08 12:38:54 +01:00
nmt-editor-section.c all: cleanup includes and let "nm-default.h" include "config.h" 2016-02-19 17:53:25 +01:00
nmt-editor-section.h all: cleanup includes in header files 2016-08-17 19:51:17 +02:00
nmt-editor.c all: remove consecutive empty lines 2018-04-30 16:24:52 +02:00
nmt-editor.h clients: drop redundant #include "NetworkManager.h" 2018-01-08 12:38:54 +01:00
nmt-ip-entry.c shared: pass addr_family as first argument to nm_utils_parse_inaddr*() 2017-10-06 11:08:39 +02:00
nmt-ip-entry.h all: cleanup includes in header files 2016-08-17 19:51:17 +02:00
nmt-mac-entry.c all: remove consecutive empty lines 2018-04-30 16:24:52 +02:00
nmt-mac-entry.h all: cleanup includes in header files 2016-08-17 19:51:17 +02:00
nmt-mtu-entry.c all: cleanup includes and let "nm-default.h" include "config.h" 2016-02-19 17:53:25 +01:00
nmt-mtu-entry.h all: cleanup includes in header files 2016-08-17 19:51:17 +02:00
nmt-page-bond.c all: replace non-leading tabs with spaces 2018-02-07 13:32:04 +01:00
nmt-page-bond.h all: cleanup includes in header files 2016-08-17 19:51:17 +02:00
nmt-page-bridge-port.c all: cleanup includes and let "nm-default.h" include "config.h" 2016-02-19 17:53:25 +01:00
nmt-page-bridge-port.h all: cleanup includes in header files 2016-08-17 19:51:17 +02:00
nmt-page-bridge.c tui: add group-forward-mask property to bridge page 2017-10-13 14:17:26 +02:00
nmt-page-bridge.h all: cleanup includes in header files 2016-08-17 19:51:17 +02:00
nmt-page-dsl.c all: cleanup includes and let "nm-default.h" include "config.h" 2016-02-19 17:53:25 +01:00
nmt-page-dsl.h all: cleanup includes in header files 2016-08-17 19:51:17 +02:00
nmt-page-ethernet.c device: extend MAC address handling including randomization for ethernet and wifi 2016-06-30 08:29:56 +02:00
nmt-page-ethernet.h all: cleanup includes in header files 2016-08-17 19:51:17 +02:00
nmt-page-infiniband.c all: cleanup includes and let "nm-default.h" include "config.h" 2016-02-19 17:53:25 +01:00
nmt-page-infiniband.h all: cleanup includes in header files 2016-08-17 19:51:17 +02:00
nmt-page-ip-tunnel.c all: don't use gchar/gshort/gint/glong but C types 2018-07-11 12:02:06 +02:00
nmt-page-ip-tunnel.h tui: add support for IP tunnel connections 2016-11-09 17:45:39 +01:00
nmt-page-ip4.c tui: add ignore-auto-dns property to IPv4 and IPv6 pages 2017-09-01 17:09:57 +02:00
nmt-page-ip4.h all: cleanup includes in header files 2016-08-17 19:51:17 +02:00
nmt-page-ip6.c tui: add ignore-auto-dns property to IPv4 and IPv6 pages 2017-09-01 17:09:57 +02:00
nmt-page-ip6.h all: cleanup includes in header files 2016-08-17 19:51:17 +02:00
nmt-page-ppp.c all: cleanup includes and let "nm-default.h" include "config.h" 2016-02-19 17:53:25 +01:00
nmt-page-ppp.h all: cleanup includes in header files 2016-08-17 19:51:17 +02:00
nmt-page-team-port.c all: replace non-leading tabs with spaces 2018-02-07 13:32:04 +01:00
nmt-page-team-port.h all: cleanup includes in header files 2016-08-17 19:51:17 +02:00
nmt-page-team.c all: replace non-leading tabs with spaces 2018-02-07 13:32:04 +01:00
nmt-page-team.h all: cleanup includes in header files 2016-08-17 19:51:17 +02:00
nmt-page-vlan.c nmtui: always create ethernet settings for VLAN and wireless security for wifi. 2017-05-28 23:22:55 +02:00
nmt-page-vlan.h all: cleanup includes in header files 2016-08-17 19:51:17 +02:00
nmt-page-wifi.c all: remove consecutive empty lines 2018-04-30 16:24:52 +02:00
nmt-page-wifi.h all: cleanup includes in header files 2016-08-17 19:51:17 +02:00
nmt-password-dialog.c clients: some cleanup of requesting VPN secrets 2017-11-23 14:44:25 +01:00
nmt-password-dialog.h all: cleanup includes in header files 2016-08-17 19:51:17 +02:00
nmt-password-fields.c all: cleanup includes and let "nm-default.h" include "config.h" 2016-02-19 17:53:25 +01:00
nmt-password-fields.h all: cleanup includes in header files 2016-08-17 19:51:17 +02:00
nmt-route-editor.c all: cleanup includes and let "nm-default.h" include "config.h" 2016-02-19 17:53:25 +01:00
nmt-route-editor.h clients: drop redundant #include "NetworkManager.h" 2018-01-08 12:38:54 +01:00
nmt-route-entry.c all: replace non-leading tabs with spaces 2018-02-07 13:32:04 +01:00
nmt-route-entry.h all: cleanup includes in header files 2016-08-17 19:51:17 +02:00
nmt-route-table.c clients: drop redundant #include "NetworkManager.h" 2018-01-08 12:38:54 +01:00
nmt-route-table.h all: cleanup includes in header files 2016-08-17 19:51:17 +02:00
nmt-slave-list.c clients: drop redundant #include "NetworkManager.h" 2018-01-08 12:38:54 +01:00
nmt-slave-list.h all: cleanup includes in header files 2016-08-17 19:51:17 +02:00
nmt-utils.c all: drop trailing spaces 2018-02-07 13:32:04 +01:00
nmt-utils.h all: cleanup includes in header files 2016-08-17 19:51:17 +02:00
nmt-widget-list.c all: cleanup includes and let "nm-default.h" include "config.h" 2016-02-19 17:53:25 +01:00
nmt-widget-list.h all: cleanup includes in header files 2016-08-17 19:51:17 +02:00
nmtui-connect.c clients: some cleanup of requesting VPN secrets 2017-11-23 14:44:25 +01:00
nmtui-connect.h all: cleanup includes in header files 2016-08-17 19:51:17 +02:00
nmtui-edit.c clients: drop redundant #include "NetworkManager.h" 2018-01-08 12:38:54 +01:00
nmtui-edit.h all: cleanup includes in header files 2016-08-17 19:51:17 +02:00
nmtui-hostname.c all: unify spelling of translators hint in source code 2018-04-13 10:00:09 +02:00
nmtui-hostname.h all: cleanup includes in header files 2016-08-17 19:51:17 +02:00
nmtui.c build: unifiy specifying locale directory define 2018-05-31 15:59:38 +02:00
nmtui.h clients: drop redundant #include "NetworkManager.h" 2018-01-08 12:38:54 +01:00