mirror of
https://gitlab.freedesktop.org/NetworkManager/NetworkManager.git
synced 2026-05-16 17:38:08 +02:00
e2c8ef45ac
When activation of the connection fails with no-secrets, we block autoconnect due to that. However, NMPolicy also unblocks such autoconnect, whenever a new secret-agent registers. The reason is obviously, that the new secret-agent might be able to provide the previously missing secrets. However, there is a race between - making the secret request, failing activation and blocking autoconnect - new secret-agent registers If the secret-agent registers after making the request, but before we block autoconnect, then autoconnect stays blocked. [1511468634.5759] device (wlp4s0): state change: config -> need-auth (reason 'none', sys-iface-state: 'managed') [1511468634.5772] device (wlp4s0): No agents were available for this request. [1511468638.4082] agent-manager: req[0x55ea7e58a5d0, :1.32/org.kde.plasma.networkmanagement/1000]: agent registered [1511468638.4082] policy: re-enabling autoconnect for all connections with failed secrets [1511468664.6280] device (wlp4s0): state change: need-auth -> failed (reason 'no-secrets', sys-iface-state: 'managed') [1511468664.6287] policy: connection 'tuxmobil' now blocked from autoconnect due to no secrets Note the long timing between making the secret request and the activation failure. This race already existed before, but now with WPS push-button method enabled by default, the duraction of the activation is much longer and the race is easy to hit. https://bugzilla.gnome.org/show_bug.cgi?id=790571
90 lines
4.5 KiB
C
90 lines
4.5 KiB
C
/* -*- Mode: C; tab-width: 4; indent-tabs-mode: t; c-basic-offset: 4 -*- */
|
|
/* NetworkManager -- Network link manager
|
|
*
|
|
* This program is free software; you can redistribute it and/or modify
|
|
* it under the terms of the GNU General Public License as published by
|
|
* the Free Software Foundation; either version 2 of the License, or
|
|
* (at your option) any later version.
|
|
*
|
|
* This program is distributed in the hope that it will be useful,
|
|
* but WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
|
|
* GNU General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License along
|
|
* with this program; if not, write to the Free Software Foundation, Inc.,
|
|
* 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA.
|
|
*
|
|
* Copyright (C) 2010 - 2011 Red Hat, Inc.
|
|
*/
|
|
|
|
#ifndef __NETWORKMANAGER_AGENT_MANAGER_H__
|
|
#define __NETWORKMANAGER_AGENT_MANAGER_H__
|
|
|
|
#include "nm-connection.h"
|
|
|
|
#include "nm-exported-object.h"
|
|
#include "nm-secret-agent.h"
|
|
|
|
#define NM_TYPE_AGENT_MANAGER (nm_agent_manager_get_type ())
|
|
#define NM_AGENT_MANAGER(obj) (G_TYPE_CHECK_INSTANCE_CAST ((obj), NM_TYPE_AGENT_MANAGER, NMAgentManager))
|
|
#define NM_AGENT_MANAGER_CLASS(klass) (G_TYPE_CHECK_CLASS_CAST ((klass), NM_TYPE_AGENT_MANAGER, NMAgentManagerClass))
|
|
#define NM_IS_AGENT_MANAGER(obj) (G_TYPE_CHECK_INSTANCE_TYPE ((obj), NM_TYPE_AGENT_MANAGER))
|
|
#define NM_IS_AGENT_MANAGER_CLASS(klass) (G_TYPE_CHECK_CLASS_TYPE ((klass), NM_TYPE_AGENT_MANAGER))
|
|
#define NM_AGENT_MANAGER_GET_CLASS(obj) (G_TYPE_INSTANCE_GET_CLASS ((obj), NM_TYPE_AGENT_MANAGER, NMAgentManagerClass))
|
|
|
|
#define NM_AGENT_MANAGER_AGENT_REGISTERED "agent-registered"
|
|
|
|
typedef struct _NMAgentManagerCallId *NMAgentManagerCallId;
|
|
|
|
typedef struct _NMAgentManagerClass NMAgentManagerClass;
|
|
|
|
GType nm_agent_manager_get_type (void);
|
|
|
|
NMAgentManager *nm_agent_manager_get (void);
|
|
|
|
guint64 nm_agent_manager_get_agent_version_id (NMAgentManager *self);
|
|
|
|
/* If no agent fulfilled the secrets request, agent_dbus_owner will be NULL */
|
|
typedef void (*NMAgentSecretsResultFunc) (NMAgentManager *manager,
|
|
NMAgentManagerCallId call_id,
|
|
const char *agent_dbus_owner,
|
|
const char *agent_uname,
|
|
gboolean agent_has_modify,
|
|
const char *setting_name,
|
|
NMSecretAgentGetSecretsFlags flags,
|
|
GVariant *secrets,
|
|
GError *error,
|
|
gpointer user_data);
|
|
|
|
NMAgentManagerCallId nm_agent_manager_get_secrets (NMAgentManager *manager,
|
|
const char *path,
|
|
NMConnection *connection,
|
|
NMAuthSubject *subject,
|
|
GVariant *existing_secrets,
|
|
const char *setting_name,
|
|
NMSecretAgentGetSecretsFlags flags,
|
|
const char *const*hints,
|
|
NMAgentSecretsResultFunc callback,
|
|
gpointer callback_data);
|
|
|
|
void nm_agent_manager_cancel_secrets (NMAgentManager *manager,
|
|
NMAgentManagerCallId request_id);
|
|
|
|
void nm_agent_manager_save_secrets (NMAgentManager *manager,
|
|
const char *path,
|
|
NMConnection *connection,
|
|
NMAuthSubject *subject);
|
|
|
|
void nm_agent_manager_delete_secrets (NMAgentManager *manager,
|
|
const char *path,
|
|
NMConnection *connection);
|
|
|
|
NMSecretAgent *nm_agent_manager_get_agent_by_user (NMAgentManager *manager,
|
|
const char *username);
|
|
|
|
gboolean nm_agent_manager_all_agents_have_capability (NMAgentManager *manager,
|
|
NMAuthSubject *subject,
|
|
NMSecretAgentCapabilities capability);
|
|
|
|
#endif /* __NETWORKMANAGER_AGENT_MANAGER_H__ */
|