mirror of
https://gitlab.freedesktop.org/NetworkManager/NetworkManager.git
synced 2026-01-03 18:40:16 +01:00
a764061807
Upside:
- it may avoid a D-Bus call altogether.
- currently there is no API to bind/unbind an existing NMActiveConnection,
it can only be bound initially with AddAndActivate2.
That makes sense when the calling applicatiion only wants to keep the
profile active for as long as it lives. It never intends to extend the
lifetime beyond that. In such a case, it is expected that eventually
we need to be sure whether the D-Bus client is still alive, as we
make a decision based on that. In that case, we eventually will call
GetNameOwner and nothing is saved.
A future feature could add D-Bus API to bind/unbind existing active
connections after creation. That would allow an application to
activate profiles and -- if anything goes wrong -- to be sure
that the profile gets deactivted. Only in the success case, it
would unbind the lifetime in a last step and terminate. Un such
a case, binding to a D-Bus client is more of a fail-safe mechanism
and commonly not expected to come into action.
This is an interesting feature, because ActivateConnection D-Bus call
may take a long time, while perfroming interactive polkit authentication.
That means, `nmcli connection up $PROFILE` can fail with timeout before
the active connection path is even created, but afterwards the profile may
still succeed to activate. That seems wrong. nmcli could avoid that,
by binding the active connection to itself, and when nmcli exits
with failure, it would make sure that the active connection gets
disconnected as well.
Downside:
- the code is slightly more complicated(?).
- if the D-Bus name is indeed gone (but the NMKeepAlive is still alive
for other reasons), we will not unregister the D-Bus signal, because we
never learn that it's gone. It's not a leak, but an unnecessary
signal subscription.
- during nm_keep_alive_set_dbus_client_watch() we don't notice right
away that the D-Bus client is already gone. That is unavoidable as
we confirm the state asynchronously.
If the NMKeepAlive is kept alive for other reasons but only later
depends on presence of the D-Bus client, then in the non-lazy approach
we would have noticed already that the client is gone, and would disconnect
right away. With the lazy approach, this takes another async D-Bus call to
notice.
|
||
|---|---|---|
| .. | ||
| devices | ||
| dhcp | ||
| dns | ||
| dnsmasq | ||
| initrd | ||
| ndisc | ||
| platform | ||
| ppp | ||
| settings | ||
| supplicant | ||
| systemd | ||
| tests | ||
| vpn | ||
| main-utils.c | ||
| main-utils.h | ||
| main.c | ||
| meson.build | ||
| NetworkManagerUtils.c | ||
| NetworkManagerUtils.h | ||
| nm-act-request.c | ||
| nm-act-request.h | ||
| nm-active-connection.c | ||
| nm-active-connection.h | ||
| nm-audit-manager.c | ||
| nm-audit-manager.h | ||
| nm-auth-manager.c | ||
| nm-auth-manager.h | ||
| nm-auth-subject.c | ||
| nm-auth-subject.h | ||
| nm-auth-utils.c | ||
| nm-auth-utils.h | ||
| nm-checkpoint-manager.c | ||
| nm-checkpoint-manager.h | ||
| nm-checkpoint.c | ||
| nm-checkpoint.h | ||
| nm-config-data.c | ||
| nm-config-data.h | ||
| nm-config.c | ||
| nm-config.h | ||
| nm-connectivity.c | ||
| nm-connectivity.h | ||
| nm-core-utils.c | ||
| nm-core-utils.h | ||
| nm-dbus-manager.c | ||
| nm-dbus-manager.h | ||
| nm-dbus-object.c | ||
| nm-dbus-object.h | ||
| nm-dbus-utils.c | ||
| nm-dbus-utils.h | ||
| nm-dcb.c | ||
| nm-dcb.h | ||
| nm-dhcp4-config.c | ||
| nm-dhcp4-config.h | ||
| nm-dhcp6-config.c | ||
| nm-dhcp6-config.h | ||
| nm-dispatcher.c | ||
| nm-dispatcher.h | ||
| nm-firewall-manager.c | ||
| nm-firewall-manager.h | ||
| nm-hostname-manager.c | ||
| nm-hostname-manager.h | ||
| nm-iface-helper.c | ||
| nm-ip4-config.c | ||
| nm-ip4-config.h | ||
| nm-ip6-config.c | ||
| nm-ip6-config.h | ||
| nm-keep-alive.c | ||
| nm-keep-alive.h | ||
| nm-logging.c | ||
| nm-logging.h | ||
| nm-manager.c | ||
| nm-manager.h | ||
| nm-netns.c | ||
| nm-netns.h | ||
| nm-pacrunner-manager.c | ||
| nm-pacrunner-manager.h | ||
| nm-policy.c | ||
| nm-policy.h | ||
| nm-proxy-config.c | ||
| nm-proxy-config.h | ||
| nm-rfkill-manager.c | ||
| nm-rfkill-manager.h | ||
| nm-session-monitor.c | ||
| nm-session-monitor.h | ||
| nm-sleep-monitor.c | ||
| nm-sleep-monitor.h | ||
| nm-test-utils-core.h | ||
| nm-types.h | ||
| org.freedesktop.NetworkManager.conf | ||