NetworkManager/src
Thomas Haller 6fbbb5be74 auth-subject: fix potential memory corruption in nm_auth_subject_to_string()
We don't want to apped the value to @buf, we want to set it.
Also, if @buf happens to be uninitialized, g_strlcat() might
determine there is nothing to append and return the buffer unmodified.
Then, the (non NULL terminated) buffer might be printed.

Note that before recent refactoring, we effectively would only call
nm_auth_subject_to_string() on auth-subjects that were of type
UNIX-PROCESS. Hence, this bug came only to light very recently,
although it was present for a long time.

Fixes: eabe7d856c
2018-04-13 11:34:08 +02:00
..
devices core: use NMDBusTrackObjPath for NM_DEVICE_ACTIVE_CONNECTION path 2018-04-13 09:09:46 +02:00
dhcp build: meson: add prefix to test names 2018-04-12 09:21:10 +02:00
dns dns: fix logging path name in update_resolv_conf() 2018-04-04 16:38:18 +02:00
dnsmasq build: meson: add prefix to test names 2018-04-12 09:21:10 +02:00
ndisc build: meson: add prefix to test names 2018-04-12 09:21:10 +02:00
platform build: meson: add prefix to test names 2018-04-12 09:21:10 +02:00
ppp core/dbus: rework creating numbered D-Bus export path by putting counter into class 2018-03-13 11:29:18 +01:00
settings settings: return empty connections list on D-Bus util connections are loaded 2018-04-13 10:48:37 +02:00
supplicant build: meson: add prefix to test names 2018-04-12 09:21:10 +02:00
systemd systemd: merge branch systemd into master 2018-04-04 17:47:22 +02:00
tests core: drop unused NMConnectionProvider typedef 2018-04-13 09:09:46 +02:00
vpn core: specify an activation reason for active connections 2018-04-08 09:40:14 +02:00
main-utils.c all: use nm_close() instead of close() 2017-11-14 15:10:42 +01:00
main-utils.h all: cleanup includes in header files 2016-08-17 19:51:17 +02:00
main.c connectivity: schedule connectivity timers per-device and probe for short outages 2018-04-10 15:11:23 +02:00
meson.build connectivity: always build nm-connectivity.c source 2018-03-19 14:46:55 +01:00
NetworkManagerUtils.c all: unify spelling of translators hint in source code 2018-04-13 10:00:09 +02:00
NetworkManagerUtils.h Revert "core: merge branch 'bg/restart-assume-rh1551958'" 2018-04-04 14:49:04 +02:00
nm-act-request.c core: specify an activation reason for active connections 2018-04-08 09:40:14 +02:00
nm-act-request.h core: specify an activation reason for active connections 2018-04-08 09:40:14 +02:00
nm-active-connection.c core: don't use NMAuthChain in NMActiveConnection but directly schedule events 2018-04-13 09:09:46 +02:00
nm-active-connection.h core: specify an activation reason for active connections 2018-04-08 09:40:14 +02:00
nm-audit-manager.c all: don't use NM_FLAGS_HAS() with non-constant argument 2017-12-15 11:48:38 +01:00
nm-audit-manager.h checkpoint: allow resetting the rollback timeout via D-Bus 2018-04-04 14:02:13 +02:00
nm-auth-manager.c auth-manager: let NMAuthChain always call to NMAuthManager for dummy requests 2018-04-13 09:09:46 +02:00
nm-auth-manager.h auth-manager: add helper function nm_auth_call_result_eval() 2018-04-13 09:09:46 +02:00
nm-auth-subject.c auth-subject: fix potential memory corruption in nm_auth_subject_to_string() 2018-04-13 11:34:08 +02:00
nm-auth-subject.h core: drop unnecessary #if WITH_POLKIT from nm-auth-subject.h 2018-04-05 17:45:30 +02:00
nm-auth-utils.c auth-chain: create data-hash hashtable only when needed 2018-04-13 09:09:46 +02:00
nm-auth-utils.h auth-manager: add helper function nm_auth_call_result_eval() 2018-04-13 09:09:46 +02:00
nm-checkpoint-manager.c checkpoint/trivial: add fixme comments 2018-04-04 14:02:13 +02:00
nm-checkpoint-manager.h checkpoint: allow resetting the rollback timeout via D-Bus 2018-04-04 14:02:13 +02:00
nm-checkpoint.c core: specify an activation reason for active connections 2018-04-08 09:40:14 +02:00
nm-checkpoint.h checkpoint: allow resetting the rollback timeout via D-Bus 2018-04-04 14:02:13 +02:00
nm-config-data.c core: fix infinite loop in evaluating global dns configuration 2018-04-04 15:31:38 +02:00
nm-config-data.h config/trivial: rename dns_config local variable 2018-03-27 09:58:00 +02:00
nm-config.c config: fix using the right nm-version for the match specification 2018-01-23 10:50:34 +01:00
nm-config.h core: use define for configuration name "wifi.scan-rand-mac-address" 2017-12-27 09:18:54 +01:00
nm-connectivity.c connectivity: schedule connectivity timers per-device and probe for short outages 2018-04-10 15:11:23 +02:00
nm-connectivity.h connectivity: schedule connectivity timers per-device and probe for short outages 2018-04-10 15:11:23 +02:00
nm-core-utils.c core: minor cleanup of nm_utils_g_value_set_strv() 2018-04-13 09:09:46 +02:00
nm-core-utils.h core: explicitly pass D-Bus path to nm_utils_log_connection_diff() 2018-04-13 09:09:46 +02:00
nm-dbus-manager.c core: fix freeing reg_data in error path of _obj_register() 2018-04-06 15:40:10 +02:00
nm-dbus-manager.h core/dbus: rework D-Bus implementation to use lower layer GDBusConnection API 2018-03-12 18:37:08 +01:00
nm-dbus-object.c core: convert NMDBusObject's "path" property to signal "exported-changed" 2018-04-13 09:09:46 +02:00
nm-dbus-object.h core: convert NMDBusObject's "path" property to signal "exported-changed" 2018-04-13 09:09:46 +02:00
nm-dbus-utils.c core: add NMDBusTrackObjPath helper 2018-04-13 09:09:46 +02:00
nm-dbus-utils.h core: add NMDBusTrackObjPath helper 2018-04-13 09:09:46 +02:00
nm-dcb.c build: don't add subdirectories to include search path but require qualified include 2016-11-21 14:26:37 +01:00
nm-dcb.h all: cleanup includes in header files 2016-08-17 19:51:17 +02:00
nm-dhcp4-config.c core/dbus: rework creating numbered D-Bus export path by putting counter into class 2018-03-13 11:29:18 +01:00
nm-dhcp4-config.h core: refactor private data in "src" 2016-10-04 09:50:56 +02:00
nm-dhcp6-config.c core/dbus: rework creating numbered D-Bus export path by putting counter into class 2018-03-13 11:29:18 +01:00
nm-dhcp6-config.h core: refactor private data in "src" 2016-10-04 09:50:56 +02:00
nm-dispatcher.c core: use nm_dbus_object_get_path() instead of nm_connection_get_path() 2018-04-13 09:09:46 +02:00
nm-dispatcher.h core/dispatcher: pass act-request to device dispatcher calls 2017-03-16 18:27:33 +01:00
nm-firewall-manager.c c-list: re-import latest version of c-list.h from upstream 2017-11-28 11:26:39 +01:00
nm-firewall-manager.h firewall: merge "started" signal and "available" property 2017-04-21 09:09:01 +02:00
nm-hostname-manager.c core,cli: replace wrong pattern for clearing GError 2017-06-27 09:42:28 +02:00
nm-hostname-manager.h hostname: cache hostname-manager's hostname property 2017-05-12 17:29:33 +02:00
nm-iface-helper.c device: don't capture resolve.conf for initial device config 2018-03-20 21:02:52 +01:00
nm-ip4-config.c device: don't capture resolve.conf for initial device config 2018-03-20 21:02:52 +01:00
nm-ip4-config.h core: add ip-config implementation for NMIP4Config vs. NMIP6Config 2018-03-20 21:03:20 +01:00
nm-ip6-config.c device: don't capture resolve.conf for initial device config 2018-03-20 21:02:52 +01:00
nm-ip6-config.h device: don't capture resolve.conf for initial device config 2018-03-20 21:02:52 +01:00
nm-logging.c core/logging: with --debug also output glib messages in stderr 2018-02-07 13:41:52 +01:00
nm-logging.h logging: add LOGD_IP_from_af() util 2018-03-20 15:24:38 +01:00
nm-manager.c auth-chain/trivial: rename nm_auth_chain_unref() to nm_auth_chain_destroy() 2018-04-13 09:09:46 +02:00
nm-manager.h core: specify an activation reason for active connections 2018-04-08 09:40:14 +02:00
nm-netns.c all: get rid of a handful of unused-but-set variables 2017-12-18 13:29:32 +01:00
nm-netns.h core: rework handling of default-routes and drop NMDefaultRouteManager 2017-09-08 11:11:21 +02:00
nm-pacrunner-manager.c all: get rid of a handful of unused-but-set variables 2017-12-18 13:29:32 +01:00
nm-pacrunner-manager.h proxy: introduce call-id for clearing pacmanager configuration 2017-04-23 18:12:09 +02:00
nm-policy.c policy: fix potential leak of subject in auto_activate_device() 2018-04-13 11:22:17 +02:00
nm-policy.h policy: add support to configurable hostname mode 2017-03-24 15:18:09 +01:00
nm-proxy-config.c proxy: reorder parts in nm-proxy-config.c and nm-pacrunner-manager.c 2016-10-04 11:58:32 +02:00
nm-proxy-config.h proxy: remove unnecessary APIs 2016-10-04 11:44:44 +02:00
nm-rfkill-manager.c udev: drop libgudev in favor of libudev 2017-03-22 12:41:06 +01:00
nm-rfkill-manager.h core: refactor private data in "src" 2016-10-04 09:50:56 +02:00
nm-session-monitor.c session-monitor: fix a -Wcast-function-type warning 2018-03-19 13:05:31 +01:00
nm-session-monitor.h core: refactor private data in "src" 2016-10-04 09:50:56 +02:00
nm-sleep-monitor.c all: use nm_close() instead of close() 2017-11-14 15:10:42 +01:00
nm-sleep-monitor.h core: refactor private data in "src" 2016-10-04 09:50:56 +02:00
nm-test-utils-core.h tests: add NMTST_EXPECT*() macros 2018-01-08 12:38:53 +01:00
nm-types.h core: drop unused NMConnectionProvider typedef 2018-04-13 09:09:46 +02:00
org.freedesktop.NetworkManager.conf dbus: allow firewalld to communicate with NetworkManager 2017-04-21 13:38:21 +02:00