mirror of
https://gitlab.freedesktop.org/NetworkManager/NetworkManager.git
synced 2026-01-09 18:10:21 +01:00
We already have nm_utils_bin2hexstr() and _nm_utils_bin2hexstr_full().
This is confusing.
- nm_utils_bin2hexstr() is public API of libnm. Also, it has
a last argument @final_len to truncate the string at that
length.
It uses no delimiter and lower-case characters.
- _nm_utils_bin2hexstr_full() does not do any truncation, but
it has options to specify a delimiter, the character case,
and to update a given buffer in-place. Also, like
nm_utils_bin2hexstr() and _nm_utils_bin2hexstr() it can
allocate a new buffer on demand.
- _nm_utils_bin2hexstr() would use ':' as delimiter and make
the case configurable. Also, it would always allocate the returned
buffer.
It's too much and confusing. Drop _nm_utils_bin2hexstr() which is internal
API and just a wrapper around _nm_utils_bin2hexstr_full().
|
||
|---|---|---|
| .. | ||
| tests | ||
| meson.build | ||
| nm-dhcp-client-logging.h | ||
| nm-dhcp-client.c | ||
| nm-dhcp-client.h | ||
| nm-dhcp-dhclient-utils.c | ||
| nm-dhcp-dhclient-utils.h | ||
| nm-dhcp-dhclient.c | ||
| nm-dhcp-dhcpcanon.c | ||
| nm-dhcp-dhcpcd.c | ||
| nm-dhcp-helper-api.h | ||
| nm-dhcp-helper.c | ||
| nm-dhcp-listener.c | ||
| nm-dhcp-listener.h | ||
| nm-dhcp-manager.c | ||
| nm-dhcp-manager.h | ||
| nm-dhcp-systemd.c | ||
| nm-dhcp-utils.c | ||
| nm-dhcp-utils.h | ||