fdo-mirrors/NetworkManager
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/NetworkManager/NetworkManager.git synced 2025-12-26 15:50:07 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions
NetworkManager/src
History
Thomas Haller 6804c2ba04
device: set MTU after attaching bond port 
When attaching a bond port, kernel will reset the MTU of the port ([1],
[2]). Configuring a different MTU on the port seems not a sensible
thing for the user to do.

Still, before commit e67ddd826f ('device: commit MTU during stage2')
we would first attach the bond port before setting the MTU. That
changed, and now the MTU set by kernel wins.

Btw, this change in behavior happens because we attach the port in
stage3 (ip-config), which seems an ugly thing to do.

Anyway, fix this by setting the MTU after attaching the ports, but still
in stage3.

It is probably not sensible for the user to configure a different MTU.
Still, if the user requested it by configuration, we should apply it.
Note that NetworkManager has some logic to constrain the MTU based on
the parent/child and controller/port. In many regards however, NetworkManager
does not fully understand or enforce the correct MTU and relies on the
user to configure it correctly. After all, if the user misconfigures the
MTU, the setup will have problems anyway (and in many cases neither
kernel nor NetworkManager could know that the configuration is wrong).

[1] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/net/bonding/bond_main.c?h=v5.17#n3603
[2] https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/drivers/net/bonding/bond_main.c?h=v5.17#n4372

https://bugzilla.redhat.com/show_bug.cgi?id=2071985

Fixes: e67ddd826f ('device: commit MTU during stage2')

https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/merge_requests/1199
2022-04-27 12:53:18 +02:00
..
c-list src/c-list: reimport 2021-10-01 16:18:06 +02:00
c-rbtree c-rbtree: re-import git-subtree for 'src/c-rbtree' 2021-10-01 16:12:15 +02:00
c-siphash c-siphash: re-import git-subtree for 'src/c-siphash' 2021-10-01 16:07:26 +02:00
c-stdaux c-stdaux: re-import git-subtree for 'src/c-stdaux' 2022-04-13 12:49:59 +02:00
contrib all: adjust glib-mkenums annotations for automated formatting 2022-02-08 11:14:01 +01:00
core device: set MTU after attaching bond port 2022-04-27 12:53:18 +02:00
libnm-base libnm: don't depend nm-crypto on "nm-error.h" 2022-03-29 11:56:03 +02:00
libnm-client-aux-extern format: reformat source tree with clang-format 13.0 2021-11-29 09:31:09 +00:00
libnm-client-impl libnm: move dependency to libnm-crypto out of libnm-core's "nm-utils.c" 2022-03-29 11:56:04 +02:00
libnm-client-public libnm: move dependency to libnm-crypto out of libnm-core's "nm-utils.c" 2022-03-29 11:56:04 +02:00
libnm-client-test all: suppress wrong gcc-12 warning "-Wdangling-pointer" 2022-02-21 19:50:52 +01:00
libnm-core-aux-extern format: reformat source tree with clang-format 13.0 2021-11-29 09:31:09 +00:00
libnm-core-aux-intern format: reformat source tree with clang-format 13.0 2021-11-29 09:31:09 +00:00
libnm-core-impl libnm: use own nm_unbase64mem_full() instead of systemd's in nm_utils_base64secret_decode() 2022-04-20 12:07:03 +02:00
libnm-core-intern libnm: add nm_setting_8021x_scheme_vtable_by_setting_key() helper 2022-03-28 18:27:36 +02:00
libnm-core-public libnm: move dependency to libnm-crypto out of libnm-core's "nm-utils.c" 2022-03-29 11:56:04 +02:00
libnm-crypto crypto: cleanup error handling in nm_crypto_is_pkcs12_data() 2022-03-29 11:56:05 +02:00
libnm-glib-aux all: hardcode HOST_NAME_MAX to 64 2022-04-26 17:54:56 +02:00
libnm-log-core format: reformat source tree with clang-format 13.0 2021-11-29 09:31:09 +00:00
libnm-log-null all: add some README.md files describing the purpose of our sources 2021-08-19 17:51:11 +02:00
libnm-platform platform: log skipped addresses in nm_platform_ip_address_sync() 2022-04-11 11:47:48 +02:00
libnm-std-aux std-aux: add NM_UTILS_GET_NEXT_REALLOC_SIZE_488 define 2022-04-13 09:23:28 +02:00
libnm-systemd-core systemd: drop "nm-sd-utils-core.h" and nm_sd_utils_id128_get_machine() 2022-04-20 12:07:04 +02:00
libnm-systemd-shared systemd: drop unused nm_sd_hostname_is_valid() 2022-04-20 12:07:04 +02:00
libnm-udev-aux format: reformat source tree with clang-format 13.0 2021-11-29 09:31:09 +00:00
libnmc-base libnmc: Remove verbose logging 2022-03-04 18:09:02 +01:00
libnmc-setting libnm: add nm_setting_8021x_scheme_vtable_by_setting_key() helper 2022-03-28 18:27:36 +02:00
libnmt-newt format: reformat source tree with clang-format 13.0 2021-11-29 09:31:09 +00:00
linux-headers linux-headers: add nl80211-vnd-intel.h kernel header 2022-03-07 10:55:33 +02:00
n-acd n-acd: fix handling of N_ACD_E_DROPPED 2021-09-30 15:10:17 +02:00
n-dhcp4 n-dhcp4: re-import git-subtree for 'src/n-dhcp4' 2022-04-13 10:57:58 +02:00
nm-cloud-setup all: prefer nm wrappers to automatically attach GSource to default context 2022-03-13 11:59:42 +01:00
nm-daemon-helper all: add some README.md files describing the purpose of our sources 2021-08-19 17:51:11 +02:00
nm-dispatcher all: suppress wrong gcc-12 warning "-Wdangling-pointer" 2022-02-21 19:50:52 +01:00
nm-initrd-generator all: use nm_hostname_is_valid() instead of systemd code 2022-04-20 12:07:04 +02:00
nm-online nm-online: set the timeout upper limit to 2073600 seconds 2022-03-07 14:47:30 +01:00
nm-priv-helper priv-helper: remove D-Bus Alias for "nm-priv-helper.service" 2022-02-09 18:47:14 +01:00
nmcli nmcli: add --offline option for "add" and "modify" 2022-04-19 14:12:42 +02:00
nmtui clients: bulk removal of g_assert*() statements 2022-03-28 13:51:44 +02:00
tests clients/tests: declare encoding of utf-8 python source "test-client.py" 2022-04-21 12:01:20 +02:00
meson.build Squashed 'src/c-stdaux/' changes from 9582a563c25e..f20e1cf2dfb1 2022-04-13 12:49:04 +02:00
README.md nm-sudo: rename to nm-priv-helper 2022-01-11 21:46:55 +01:00

README.md

src/

Most of the subdirectories are static helper libraries, which get linked into one of the final build artifacts (like libnm, nmcli or NetworkManager). Static libraries are internal API.

The only public API is libnm, which is a shared library provided client implementations.

Our own clients (like nmcli and nmtui) also use libnm, the shared library. But they also use additional static helper libraries.

The daemon statically links against a part of libnm, the part that provides connection profiles. That is libnm-core. libnm-core is thus statically linked with libnm and the daemon. It does not get linked by clients that already link with libnm (like nmtui).

Read the individual README.md files in the subdirectories for details:

Directory Description
core/ the NetworkManager daemon
nmcli/ nmcli application, a command line client for NetworkManager
nmtui/ nmtui application, a text UI client for NetworkManager
nm-cloud-setup/ service to automatically configure NetworkManager in cloud environment
nm-initrd-generator/ generates NetworkManager configuration by parsing kernel command line options for dracut/initrd
nm-dispatcher/ NetworkManager-dispatcher service to run user scripts
nm-online/ application which checks whether NetworkManager is done, for implementing NetworkManager-wait-online.service
nm-priv-helper/ internal service for privileged operations
nm-daemon-helper/ internal helper binary spawned by NetworkManager
libnm-std-aux/ internal helper library for standard C
libnm-glib-aux/ internal helper library for glib
libnm-log-null/ internal helper library with dummy (null) logging backend
libnm-log-core/ internal helper library with logging backend (syslog) used by daemon
libnm-base/ internal helper library with base definitions
libnm-platform/ internal helper library for netlink and other platform/kernel API
libnm-udev-aux/ internal helper library for libudev
libnm-core-public/ public API of libnm (libnm-core part)
libnm-core-intern/ internal API of libnm-core, used by libnm and daemon
libnm-core-impl/ implementation of libnm-core
libnm-core-aux-intern/ internal helper library on top of libnm-core (used by libnm-core itself)
libnm-core-aux-extern/ internal helper library on top of libnm-core (not used by libnm-core)
libnm-client-public/ public API of libnm (NMClient part)
libnm-client-impl/ implementation of libnm (NMClient)
libnm-client-aux-extern/ internal helper library on top of libnm (not used by libnm itself)
libnmc-base/ internal helper library for libnm clients
libnmc-setting/ internal helper library for setting connection profiles (used by nmcli)
libnmt-newt/ internal helper library for libnewt for nmtui
linux-headers/ extra Linux kernel UAPI headers
contrib/ sources that are not used by NetworkManager itself
tests/ unit tests that are not specific to one of the other directories
libnm-client-test/ internal helper library with test utils for libnm
c-list/ fork of c-util helper library for intrusive, doubly linked list
c-rbtree/ fork of c-util helper library for intrusive Red-Black Tree
c-siphash/ fork of c-util helper library for SIPHash24
c-stdaux/ fork of c-util general purpose helpers for standard C
n-acd/ fork of nettools IPv4 ACD library
n-dhcp4/ fork of nettools DHCPv4 library
libnm-systemd-core/ fork of systemd code as network library
libnm-systemd-shared/ fork of systemd code as general purpose library