NetworkManager/libnm-core/tests
Thomas Haller 64da830b07 libnm: allow setting empty vpn.data item
Until now, nm_setting_vpn_add_data_item() would reject empty data values.
This leads for example to an assertion failure, if you write a keyfile
that assigns an empty value to a key. Keyfile reader would not check that
the value is non-empty before calling nm_setting_vpn_add_data_item().

Anyway, I think we should not require having non-empty data elements. It's
an unnecessary and sometimes harmful restriction. NetworkManager doesn't understand
not care about the content of the vpn data. That is up the VPN plugins. Sometimes
and empty value may be desirable.

Also, the NM_SETTING_VPN_DATA property setter wouldn't filter out empty
values either. So it was always possible to use some libnm API to set data
with empty values. The restriction in nm_setting_vpn_add_data_item() was
inconsistent.
2020-04-04 19:51:34 +02:00
..
certs libnm/crypto: accept TPM2-wrapped PEM keys 2019-07-10 17:31:48 +02:00
meson.build license: Add license using SPDX identifiers to meson build files 2020-02-17 13:16:57 +01:00
nm-core-tests-enum-types.c.template build: use template files for enum types' sources generation 2017-12-18 11:25:06 +01:00
nm-core-tests-enum-types.h.template build: use template files for enum types' sources generation 2017-12-18 11:25:06 +01:00
test-compare.c all: unify format of our Copyright source code comments 2019-10-02 17:03:52 +02:00
test-crypto.c all: unify format of our Copyright source code comments 2019-10-02 17:03:52 +02:00
test-general-enums.h all: unify format of our Copyright source code comments 2019-10-02 17:03:52 +02:00
test-general.c libnm: allow setting empty vpn.data item 2020-04-04 19:51:34 +02:00
test-keyfile.c all: use nm_clear_pointer() instead of g_clear_pointer() 2020-03-23 11:22:38 +01:00
test-secrets.c all: unify format of our Copyright source code comments 2019-10-02 17:03:52 +02:00
test-setting.c all: use nm_clear_g_free() instead of g_clear_pointer() 2020-03-23 11:05:34 +01:00
test-settings-defaults.c all: unify format of our Copyright source code comments 2019-10-02 17:03:52 +02:00