mirror of
https://gitlab.freedesktop.org/NetworkManager/NetworkManager.git
synced 2025-12-28 00:30:09 +01:00
a4af7967c9
ifupdown only supports secrets for wireless connections, so attempts to get non-wireless secrets need to fail. Previously, this was accomplished by overriding NMSysconfigSettingsClass->get_secrets, the handler for DBus GetSecrets() method calls. This had some problems: - It created an information leak. The first thing the NMSysconfigConnection implementation does is verify that the caller is authorized to get secrets information, but nm-ifupdown-connection ends up performing its additional check before authorization happens. Thus, unauthorized users are able to determine that some connections don't have secrets. This will become more significant when secrets handling is revamped. - We'd really like to devirtualize these DBus method call handlers. They were inherited from from NMRemoteConnection, where we needed these functions to be virtual so that user and system settings services could implement them differently. That is no longer needed. ifupdown was the last place were we actually "needed" these functions to be virtual. With this commit, we fix these problems by overriding nm_settings_connection_interface_get_secrets instead. |
||
|---|---|---|
| .. | ||
| ifcfg-rh | ||
| ifcfg-suse | ||
| ifupdown | ||
| keyfile | ||
| Makefile.am | ||