NetworkManager/src
Thomas Haller 518f6124c6
l3cfg: fix clearing IPv6 temporary addresses to avoid stale addresses
IPv6 temporary addresses are configured by kernel, with the
"ipv6.ip6-privacy" setting ("use_tempaddr" sysctl) and the
IFA_F_MANAGETEMPADDR flag.

As such, the idea was that during reapply we would not remove them.
However, that is wrong.

The only case when we want to keep those addresses, is if during reapply
we are going to configure the same primary address (with mngtmpaddr
flag) again. Otherwise, theses addresses must always go away.

This is quite serious. This not only affects Reapply. Also during disconnect
we clear IP configuration via l3cfg.
Have an ethernet profile active with "ipv6.ip6-privacy". Unplug
the cable, the device disconnects but the temporary IPv6 address is not
cleared. As such, nm_device_generate_connection() will now generate
an external profile (with "ipv6.method=disabled" and no manual IP addresses).
The result is, that the device cannot properly autoconnect again,
once you replug the cable.

This is serious for disconnect. But I could not actually reproduce the
problem using reapply. That is, because during reapply we usually
toggle ipv6_disable sysctl, which drops all IPv6 addresses. I still
went through the effort of trying to preserve addresses that we still
want to have, because I am not sure whether there are cases where we
don't toggle ipv6_disable. Also, doing ipv6_disable during reapply is
bad anyway, and we might want to avoid that in the future.

Fixes: 58287cbcc0 ('core: rework IP configuration in NetworkManager using layer 3 configuration')
2022-05-09 19:21:58 +02:00
..
c-list c-list: re-import git-subtree for 'src/c-list' 2022-05-06 10:02:17 +02:00
c-rbtree c-rbtree: re-import git-subtree for 'src/c-rbtree' 2022-05-06 09:58:08 +02:00
c-siphash c-siphash: re-import git-subtree for 'src/c-siphash' 2022-05-06 09:52:00 +02:00
c-stdaux c-stdaux: re-import git-subtree for 'src/c-stdaux' 2022-05-06 09:46:30 +02:00
contrib all: adjust glib-mkenums annotations for automated formatting 2022-02-08 11:14:01 +01:00
core l3cfg: fix clearing IPv6 temporary addresses to avoid stale addresses 2022-05-09 19:21:58 +02:00
libnm-base libnm: don't depend nm-crypto on "nm-error.h" 2022-03-29 11:56:03 +02:00
libnm-client-aux-extern format: reformat source tree with clang-format 13.0 2021-11-29 09:31:09 +00:00
libnm-client-impl libnm-client: fix some comments 2022-05-06 18:33:27 +02:00
libnm-client-public libnm: replace nm-types.h by defining the types in respective headers 2022-05-06 18:33:27 +02:00
libnm-client-test build/meson: add dependency libnm_client_public_dep for "libnm-client-test" 2022-05-04 08:56:58 +02:00
libnm-core-aux-extern format: reformat source tree with clang-format 13.0 2021-11-29 09:31:09 +00:00
libnm-core-aux-intern format: reformat source tree with clang-format 13.0 2021-11-29 09:31:09 +00:00
libnm-core-impl glib-aux: drop nm_str_buf_init() for NM_STR_BUF_INIT() 2022-05-09 19:18:30 +02:00
libnm-core-intern all: drop redundant includes 2022-05-09 19:20:18 +02:00
libnm-core-public version: add 1.40 macros 2022-05-01 14:12:20 +02:00
libnm-crypto crypto: cleanup error handling in nm_crypto_is_pkcs12_data() 2022-03-29 11:56:05 +02:00
libnm-glib-aux glib-aux: add nm_g_array_data() helper 2022-05-09 19:21:58 +02:00
libnm-log-core glib-aux: drop nm_str_buf_init() for NM_STR_BUF_INIT() 2022-05-09 19:18:30 +02:00
libnm-log-null all: add some README.md files describing the purpose of our sources 2021-08-19 17:51:11 +02:00
libnm-platform l3cfg: fix clearing IPv6 temporary addresses to avoid stale addresses 2022-05-09 19:21:58 +02:00
libnm-std-aux std-aux: include default std-aux headers by "nm-default-std.h" 2022-05-09 19:20:19 +02:00
libnm-systemd-core systemd: drop "nm-sd-utils-core.h" and nm_sd_utils_id128_get_machine() 2022-04-20 12:07:04 +02:00
libnm-systemd-shared systemd: drop unused nm_sd_hostname_is_valid() 2022-04-20 12:07:04 +02:00
libnm-udev-aux format: reformat source tree with clang-format 13.0 2021-11-29 09:31:09 +00:00
libnmc-base glib-aux: drop nm_str_buf_init() for NM_STR_BUF_INIT() 2022-05-09 19:18:30 +02:00
libnmc-setting core: change the priority order in static "ipv6.addresses" 2022-04-27 15:50:55 +02:00
libnmt-newt format: reformat source tree with clang-format 13.0 2021-11-29 09:31:09 +00:00
linux-headers linux-headers: add nl80211-vnd-intel.h kernel header 2022-03-07 10:55:33 +02:00
n-acd n-acd: fix handling of N_ACD_E_DROPPED 2021-09-30 15:10:17 +02:00
n-dhcp4 n-dhcp4/probe: forget lease after a NAK 2022-05-06 10:23:03 +02:00
nm-cloud-setup cloud-setup: only pass config-iface-data as user-data for async functions 2022-05-05 08:29:53 +02:00
nm-daemon-helper daemon-helper: include "libnm-std-aux/nm-default-std.h" as first in "nm-daemon-helper.c" 2022-05-09 19:20:19 +02:00
nm-dispatcher all: suppress wrong gcc-12 warning "-Wdangling-pointer" 2022-02-21 19:50:52 +01:00
nm-initrd-generator all: use nm_hostname_is_valid() instead of systemd code 2022-04-20 12:07:04 +02:00
nm-online nm-online: set the timeout upper limit to 2073600 seconds 2022-03-07 14:47:30 +01:00
nm-priv-helper all: drop redundant includes 2022-05-09 19:20:18 +02:00
nmcli core: change the priority order in static "ipv6.addresses" 2022-04-27 15:50:55 +02:00
nmtui clients: bulk removal of g_assert*() statements 2022-03-28 13:51:44 +02:00
tests tests/client: improve readme for how to get test-client.py regenerate the test data 2022-05-02 19:03:32 +02:00
meson.build Squashed 'src/c-list/' changes from a0970f12f1f4..b86ba656ac22 2022-05-06 10:02:08 +02:00
README.md nm-sudo: rename to nm-priv-helper 2022-01-11 21:46:55 +01:00

src/

Most of the subdirectories are static helper libraries, which get linked into one of the final build artifacts (like libnm, nmcli or NetworkManager). Static libraries are internal API.

The only public API is libnm, which is a shared library provided client implementations.

Our own clients (like nmcli and nmtui) also use libnm, the shared library. But they also use additional static helper libraries.

The daemon statically links against a part of libnm, the part that provides connection profiles. That is libnm-core. libnm-core is thus statically linked with libnm and the daemon. It does not get linked by clients that already link with libnm (like nmtui).

Read the individual README.md files in the subdirectories for details:

Directory Description
core/ the NetworkManager daemon
nmcli/ nmcli application, a command line client for NetworkManager
nmtui/ nmtui application, a text UI client for NetworkManager
nm-cloud-setup/ service to automatically configure NetworkManager in cloud environment
nm-initrd-generator/ generates NetworkManager configuration by parsing kernel command line options for dracut/initrd
nm-dispatcher/ NetworkManager-dispatcher service to run user scripts
nm-online/ application which checks whether NetworkManager is done, for implementing NetworkManager-wait-online.service
nm-priv-helper/ internal service for privileged operations
nm-daemon-helper/ internal helper binary spawned by NetworkManager
libnm-std-aux/ internal helper library for standard C
libnm-glib-aux/ internal helper library for glib
libnm-log-null/ internal helper library with dummy (null) logging backend
libnm-log-core/ internal helper library with logging backend (syslog) used by daemon
libnm-base/ internal helper library with base definitions
libnm-platform/ internal helper library for netlink and other platform/kernel API
libnm-udev-aux/ internal helper library for libudev
libnm-core-public/ public API of libnm (libnm-core part)
libnm-core-intern/ internal API of libnm-core, used by libnm and daemon
libnm-core-impl/ implementation of libnm-core
libnm-core-aux-intern/ internal helper library on top of libnm-core (used by libnm-core itself)
libnm-core-aux-extern/ internal helper library on top of libnm-core (not used by libnm-core)
libnm-client-public/ public API of libnm (NMClient part)
libnm-client-impl/ implementation of libnm (NMClient)
libnm-client-aux-extern/ internal helper library on top of libnm (not used by libnm itself)
libnmc-base/ internal helper library for libnm clients
libnmc-setting/ internal helper library for setting connection profiles (used by nmcli)
libnmt-newt/ internal helper library for libnewt for nmtui
linux-headers/ extra Linux kernel UAPI headers
contrib/ sources that are not used by NetworkManager itself
tests/ unit tests that are not specific to one of the other directories
libnm-client-test/ internal helper library with test utils for libnm
c-list/ fork of c-util helper library for intrusive, doubly linked list
c-rbtree/ fork of c-util helper library for intrusive Red-Black Tree
c-siphash/ fork of c-util helper library for SIPHash24
c-stdaux/ fork of c-util general purpose helpers for standard C
n-acd/ fork of nettools IPv4 ACD library
n-dhcp4/ fork of nettools DHCPv4 library
libnm-systemd-core/ fork of systemd code as network library
libnm-systemd-shared/ fork of systemd code as general purpose library