5022aff2c8
Since normalize already sorts the array, and verify needs to check
whether the array is sorted, we can implement verify() more efficiently.
In the usual case (where the property is normalized), we can just
iterate over the list and check that the ranges are increasing and
non-overlapping.
Only if that fails, do a shallow-copy of the array, sort it, and check
again. If it's still invalid after sorting, verification fails.
We don't need to create a GHashTable which adds all elements in between
the ranges. While the algorithm with hash table is O(n), the new version
with sorting is O(n*ln(n)). But of course, since the overall number of
range elements is limited to 4096, they are really both O(1). But more
importantly, it's just faster to iterate over the list and sort it, than
to fill a hash table.
---
Test with -O2, more-asserts=0:
diff --git c/src/libnm-core-impl/tests/test-setting.c w/src/libnm-core-impl/tests/test-setting.c
index 00fc838d1794..a0991b36d9d7 100644
--- c/src/libnm-core-impl/tests/test-setting.c
+++ w/src/libnm-core-impl/tests/test-setting.c
@@ -5266,5 +5266,5 @@ static void
test_ovs_port_trunks(void)
{
- const guint N_RUN = 10;
+ const guint N_RUN = 10000;
guint i_run;
gs_unref_object NMConnection *con = NULL;
$ make -j src/libnm-core-impl/tests/test-setting && \
libtool --mode=execute \
perf stat -r 5 -B \
src/libnm-core-impl/tests/test-setting -p /libnm/test_ovs_port_trunks
Before:
8,114.55 msec task-clock:u # 0.998 CPUs utilized ( +- 0.20% )
0 context-switches:u # 0.000 /sec
0 cpu-migrations:u # 0.000 /sec
341 page-faults:u # 41.980 /sec ( +- 0.16% )
25,172,559,932 cycles:u # 3.099 GHz ( +- 0.12% )
39,221,096,221 instructions:u # 1.56 insn per cycle ( +- 0.04% )
5,721,519,798 branches:u # 704.373 M/sec ( +- 0.07% )
230,728,395 branch-misses:u # 4.04% of all branches ( +- 0.28% )
8.1340 +- 0.0179 seconds time elapsed ( +- 0.22% )
After:
4,300.62 msec task-clock:u # 0.999 CPUs utilized ( +- 0.34% )
0 context-switches:u # 0.000 /sec
0 cpu-migrations:u # 0.000 /sec
342 page-faults:u # 79.435 /sec ( +- 0.20% )
13,231,554,996 cycles:u # 3.073 GHz ( +- 0.27% )
20,676,554,955 instructions:u # 1.55 insn per cycle ( +- 0.07% )
3,101,429,604 branches:u # 720.354 M/sec ( +- 0.11% )
118,808,950 branch-misses:u # 3.83% of all branches ( +- 0.34% )
4.3068 +- 0.0143 seconds time elapsed ( +- 0.33% )
|
||
|---|---|---|
| .gitlab-ci | ||
| contrib | ||
| data | ||
| docs | ||
| examples | ||
| introspection | ||
| m4 | ||
| man | ||
| po | ||
| src | ||
| tools | ||
| vapi | ||
| .clang-format | ||
| .dir-locals.el | ||
| .git-blame-ignore-revs | ||
| .gitignore | ||
| .gitlab-ci.yml | ||
| .mailmap | ||
| .triage-policies.yml | ||
| AUTHORS | ||
| autogen.sh | ||
| ChangeLog | ||
| config-extra.h.meson | ||
| config-extra.h.mk | ||
| config.h.meson | ||
| configure.ac | ||
| CONTRIBUTING.md | ||
| COPYING | ||
| COPYING.GFDL | ||
| COPYING.LGPL | ||
| linker-script-binary.ver | ||
| linker-script-devices.ver | ||
| linker-script-settings.ver | ||
| lsan.suppressions | ||
| MAINTAINERS | ||
| MAINTAINERS.md | ||
| Makefile.am | ||
| Makefile.examples | ||
| Makefile.glib | ||
| Makefile.vapigen | ||
| meson.build | ||
| meson_options.txt | ||
| NEWS | ||
| README.md | ||
| RELICENSE.md | ||
| TODO | ||
| valgrind.suppressions | ||
NetworkManager core daemon has moved to gitlab.freedesktop.org!
git clone https://gitlab.freedesktop.org/NetworkManager/NetworkManager.git
Networking that Just Works
NetworkManager attempts to keep an active network connection available at all times. The point of NetworkManager is to make networking configuration and setup as painless and automatic as possible. NetworkManager is intended to replace default route, replace other routes, set IP addresses, and in general configure networking as NM sees fit (with the possibility of manual override as necessary). In effect, the goal of NetworkManager is to make networking Just Work with a minimum of user hassle, but still allow customization and a high level of manual network control. If you have special needs, we'd like to hear about them, but understand that NetworkManager is not intended for every use-case.
NetworkManager will attempt to keep every network device in the system up and active, as long as the device is available for use (has a cable plugged in, the killswitch isn't turned on, etc). Network connections can be set to 'autoconnect', meaning that NetworkManager will make that connection active whenever it and the hardware is available.
"Settings services" store lists of user- or administrator-defined "connections", which contain all the settings and parameters required to connect to a specific network. NetworkManager will never activate a connection that is not in this list, or that the user has not directed NetworkManager to connect to.
How it works:
The NetworkManager daemon runs as a privileged service (since it must access and control hardware), but provides a D-Bus interface on the system bus to allow for fine-grained control of networking. NetworkManager does not store connections or settings, it is only the mechanism by which those connections are selected and activated.
To store pre-defined network connections, two separate services, the "system settings service" and the "user settings service" store connection information and provide these to NetworkManager, also via D-Bus. Each settings service can determine how and where it persistently stores the connection information; for example, the GNOME applet stores its configuration in GConf, and the system settings service stores its config in distro-specific formats, or in a distro- agnostic format, depending on user/administrator preference.
A variety of other system services are used by NetworkManager to provide network functionality: wpa_supplicant for wireless connections and 802.1x wired connections, pppd for PPP and mobile broadband connections, DHCP clients for dynamic IP addressing, dnsmasq for proxy nameserver and DHCP server functionality for internet connection sharing, and avahi-autoipd for IPv4 link-local addresses. Most communication with these daemons occurs, again, via D-Bus.
Why doesn't my network Just Work?
Driver problems are the #1 cause of why NetworkManager sometimes fails to connect to wireless networks. Often, the driver simply doesn't behave in a consistent manner, or is just plain buggy. NetworkManager supports only those drivers that are shipped with the upstream Linux kernel, because only those drivers can be easily fixed and debugged. ndiswrapper, vendor binary drivers, or other out-of-tree drivers may or may not work well with NetworkManager, precisely because they have not been vetted and improved by the open-source community, and because problems in these drivers usually cannot be fixed.
Sometimes, command-line tools like 'iwconfig' will work, but NetworkManager will fail. This is again often due to buggy drivers, because these drivers simply aren't expecting the dynamic requests that NetworkManager and wpa_supplicant make. Driver bugs should be filed in the bug tracker of the distribution being run, since often distributions customize their kernel and drivers.
Sometimes, it really is NetworkManager's fault. If you think that's the case, please file a bug at:
https://gitlab.freedesktop.org/NetworkManager/NetworkManager/issues
Attaching NetworkManager debug logs from the journal (or wherever your distribution directs syslog's 'daemon' facility output, as /var/log/messages or /var/log/daemon.log) is often very helpful, and (if you can get) a working wpa_supplicant config file helps enormously. See the logging section of file contrib/fedora/rpm/NetworkManager.conf for how to enable debug logging in NetworkManager.