mirror of
https://gitlab.freedesktop.org/NetworkManager/NetworkManager.git
synced 2025-12-26 18:10:08 +01:00
5388542fc0
The numeric source IDs exist from a time before 2000, when there was only one "GMainContext" singleton instance. Nowadays, the source ID is only relative to one GMainContext, and you'd have to track that association yourself. Als, g_source_remove() requires an additional hash lookup, when you could simply track the GSource instance from the start. This API should not be used anymore. Operate on GSouce instances direclty and use API like nm_clear_g_source_inst() nm_g_idle_add_source() nm_g_idle_souce_new() nm_g_source_attach() g_source_attach g_source_destroy g_source_unref etc. Note that if you don't care about to ever remove a source again, like scheduling an idle action that should not be cancelled, then g_idle_add(callback, user_data); is fine. It is only problematic to do something with those numeric IDs. checkpatch.pl would also flag those uses, but these are just warnings and in the few cases where such a warning is emitted wrongly, it's find to ignore them. |
||
|---|---|---|
| .. | ||
| btmodem.pl | ||
| checkpatch-feature-branch.sh | ||
| checkpatch-git-post-commit-hook | ||
| checkpatch.pl | ||
| code-style-git-post-commit-hook | ||
| find-backports | ||
| modemu.pl | ||
| nm-ci-install-valgrind-in-ubuntu1604.sh | ||
| nm-ci-patch-gtkdoc.sh | ||
| nm-ci-run.sh | ||
| nm-code-format-container.sh | ||
| nm-code-format.sh | ||
| nm-copr-build-nm-git-bundle.sh | ||
| nm-copr-build.sh | ||
| nm-import-openconnect | ||
| nm-import-openvpn | ||
| nm-import-vpnc | ||
| NM-log | ||
| test-create-many-device-setup.sh | ||
| test-macsec | ||