fdo-mirrors/NetworkManager
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/NetworkManager/NetworkManager.git synced 2025-12-25 23:30:07 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions
NetworkManager/src
History
Thomas Haller 4419dbed13 dnsmasq: refactor construction of command line options in create_dm_cmd_line() 
Having a NMCmdLine implementation here is wrong.

For one, it local to nm-dnsmasq-manager.c and not reusable.
If there is anything of value in such an implementation, then it should
possibly also be useful at other places that create command line
arguments.

Note that in the end, command line arguments are just strv arrays.
There are different ways how to construct that strv array. For example,
do we need to clone the strings that we add? How to do that most
elegantly and efficiently? The previous implementation for example used a
GStringChunk for that (quite creative!). The point is, there are pros and
cons about how to create strv arrays. But constructing command line options
shouldn't be abstracted in a NMCmdLine API. It should use a suitable API
for creating an strv array. Otherwise, it's too much abstraction.

Drop NMCmdLine and use GPtrArray directly. Together with a few helper
functions nm_strv_ptrarray_*() that is our preferred way to create such
strv arrays. Is it perfect? No, we still g_strdup() static strings.
That could be optimized. But then we would want an optimized API for
constructing strv arrays, not NMCmdLine.
2018-12-03 12:28:45 +01:00
..
devices all: make use of NM_MAKE_STRV() macro 2018-12-01 15:16:48 +01:00
dhcp dhcp: always explicitly set IAID of internal DHCPv6 client 2018-11-29 07:48:20 +01:00
dns all: cleanup GChecksum handling 2018-11-13 18:30:03 +01:00
dnsmasq dnsmasq: refactor construction of command line options in create_dm_cmd_line() 2018-12-03 12:28:45 +01:00
initrd initrd: actually use the constructed filename 2018-11-27 11:18:08 +01:00
ndisc all: say Wi-Fi instead of "wifi" or "WiFi" 2018-11-29 17:53:35 +01:00
platform platform: don't consult cache before invoking netlink operation 2018-12-03 12:26:16 +01:00
ppp ppp: check ppp status against correct type 2018-10-22 10:53:16 +02:00
settings keyfile: add helper functions to record loaded UUID files 2018-12-03 12:09:57 +01:00
supplicant all: cleanup GChecksum handling 2018-11-13 18:30:03 +01:00
systemd dhcp: disable systemd's dhcp_identifier_set_iaid() 2018-11-29 07:48:20 +01:00
tests all: make use of NM_MAKE_STRV() macro 2018-12-01 15:16:48 +01:00
vpn core: add checks on connection default properties 2018-12-01 15:16:48 +01:00
main-utils.c all: don't use gchar/gshort/gint/glong but C types 2018-07-11 12:02:06 +02:00
main-utils.h all: cleanup includes in header files 2016-08-17 19:51:17 +02:00
main.c config: warn about unknown keys in config files 2018-12-01 15:16:48 +01:00
meson.build build: check that the list of supported config options is up to date 2018-12-01 15:16:48 +01:00
NetworkManagerUtils.c device: add "dhcp-plugin" match spec for device 2018-11-01 11:17:12 +01:00
NetworkManagerUtils.h device: add "dhcp-plugin" match spec for device 2018-11-01 11:17:12 +01:00
nm-act-request.c all: say Wi-Fi instead of "wifi" or "WiFi" 2018-11-29 17:53:35 +01:00
nm-act-request.h core: specify an activation reason for active connections 2018-04-08 09:40:14 +02:00
nm-active-connection.c keep-alive: various style fixes 2018-11-17 12:50:58 +01:00
nm-active-connection.h core: Add option to AddAndActivateConnection2 to bind the lifetime 2018-11-17 12:15:40 +01:00
nm-audit-manager.c config: use macros for config keys 2018-12-01 15:16:48 +01:00
nm-audit-manager.h checkpoint: allow resetting the rollback timeout via D-Bus 2018-04-04 14:02:13 +02:00
nm-auth-manager.c auth-manager: use the correct function to deallocate a GError 2018-05-02 14:55:01 +02:00
nm-auth-manager.h auth-manager: add helper function nm_auth_call_result_eval() 2018-04-13 09:09:46 +02:00
nm-auth-subject.c all: don't use gchar/gshort/gint/glong but C types 2018-07-11 12:02:06 +02:00
nm-auth-subject.h all: remove consecutive empty lines 2018-04-30 16:24:52 +02:00
nm-auth-utils.c docs: misc. typos pt2 2018-09-17 11:26:13 +02:00
nm-auth-utils.h core: add nm_auth_is_subject_in_acl_set_error() helper 2018-04-18 07:55:15 +02:00
nm-checkpoint-manager.c settings: use delegation instead of inheritance for NMSettingsConnection and NMConnection 2018-08-28 22:27:55 +02:00
nm-checkpoint-manager.h checkpoint: allow resetting the rollback timeout via D-Bus 2018-04-04 14:02:13 +02:00
nm-checkpoint.c settings: use delegation instead of inheritance for NMSettingsConnection and NMConnection 2018-08-28 22:27:55 +02:00
nm-checkpoint.h checkpoint: allow resetting the rollback timeout via D-Bus 2018-04-04 14:02:13 +02:00
nm-config-data.c core: add checks on connection default properties 2018-12-01 15:16:48 +01:00
nm-config-data.h core: add checks on connection default properties 2018-12-01 15:16:48 +01:00
nm-config.c config: use cleanup attribute for variables in init_sync() 2018-12-01 15:16:48 +01:00
nm-config.h build: check that the list of supported config options is up to date 2018-12-01 15:16:48 +01:00
nm-connectivity.c connectivity: fix crash when the uri gets cleared from configuration 2018-10-01 09:46:14 +02:00
nm-connectivity.h connectivity: allow limiting the connectivity check to a specified AF 2018-09-24 15:17:02 +02:00
nm-core-utils.c core: add nm_utils_create_dhcp_iaid() util 2018-11-29 07:48:20 +01:00
nm-core-utils.h core: add nm_utils_create_dhcp_iaid() util 2018-11-29 07:48:20 +01:00
nm-dbus-manager.c dbus: register object manager object before requesting dbus name 2018-11-29 07:55:16 +01:00
nm-dbus-manager.h settings: use delegation instead of inheritance for NMSettingsConnection and NMConnection 2018-08-28 22:27:55 +02:00
nm-dbus-object.c core/dbus: stop NMDBusManager and reject future method calls 2018-04-24 10:25:26 +02:00
nm-dbus-object.h core/dbus: stop NMDBusManager and reject future method calls 2018-04-24 10:25:26 +02:00
nm-dbus-utils.c core: don't explicitly set D-Bus path properties to "/" 2018-04-18 07:55:15 +02:00
nm-dbus-utils.h core/dbus: stop NMDBusManager and reject future method calls 2018-04-24 10:25:26 +02:00
nm-dcb.c all: don't use gchar/gshort/gint/glong but C types 2018-07-11 12:02:06 +02:00
nm-dcb.h all: cleanup includes in header files 2016-08-17 19:51:17 +02:00
nm-dhcp4-config.c core: sort DHCP options that are exported on D-Bus 2018-04-23 15:43:39 +02:00
nm-dhcp4-config.h core: refactor private data in "src" 2016-10-04 09:50:56 +02:00
nm-dhcp6-config.c core: sort DHCP options that are exported on D-Bus 2018-04-23 15:43:39 +02:00
nm-dhcp6-config.h core: refactor private data in "src" 2016-10-04 09:50:56 +02:00
nm-dispatcher.c all: use the elvis operator wherever possible 2018-05-10 14:36:58 +02:00
nm-dispatcher.h all: remove consecutive empty lines 2018-04-30 16:24:52 +02:00
nm-firewall-manager.c all: use the elvis operator wherever possible 2018-05-10 14:36:58 +02:00
nm-firewall-manager.h firewall: merge "started" signal and "available" property 2017-04-21 09:09:01 +02:00
nm-hostname-manager.c hostname: drop define IFCFG_DIR which is only used once 2018-07-17 17:46:01 +02:00
nm-hostname-manager.h hostname: cache hostname-manager's hostname property 2017-05-12 17:29:33 +02:00
nm-iface-helper.c config: add --configure-and-quit=initrd mode 2018-09-18 17:40:47 +02:00
nm-ip4-config.c all: cleanup GChecksum handling 2018-11-13 18:30:03 +01:00
nm-ip4-config.h ip-config: add @intersect_routes argument to intersect functions 2018-09-26 11:49:37 +02:00
nm-ip6-config.c all: cleanup GChecksum handling 2018-11-13 18:30:03 +01:00
nm-ip6-config.h ip-config: add @intersect_routes argument to intersect functions 2018-09-26 11:49:37 +02:00
nm-keep-alive.c keep-alive: check GetNameOwner lazy and only when we rely on the information 2018-11-20 10:22:27 +01:00
nm-keep-alive.h keep-alive: drop unused error argument 2018-11-17 12:43:25 +01:00
nm-logging.c shared: thread safe initialization of nm_utils_get_monotonic_timestamp*() 2018-11-28 16:13:04 +01:00
nm-logging.h all: say Wi-Fi instead of "wifi" or "WiFi" 2018-11-29 17:53:35 +01:00
nm-manager.c core: add checks on connection default properties 2018-12-01 15:16:48 +01:00
nm-manager.h core: extend nm_manager_get_activatable_connections() for autoconnect and multi-connect 2018-08-08 11:24:29 +02:00
nm-netns.c all: get rid of a handful of unused-but-set variables 2017-12-18 13:29:32 +01:00
nm-netns.h core: rework handling of default-routes and drop NMDefaultRouteManager 2017-09-08 11:11:21 +02:00
nm-pacrunner-manager.c docs: misc. typos pt2 2018-09-17 11:26:13 +02:00
nm-pacrunner-manager.h proxy: introduce call-id for clearing pacmanager configuration 2017-04-23 18:12:09 +02:00
nm-policy.c policy: don't check for valid error in active_connection_keep_alive_changed() 2018-11-17 13:38:15 +01:00
nm-policy.h policy: track best active connections rather than best devices 2018-07-09 14:56:59 +02:00
nm-proxy-config.c proxy: reorder parts in nm-proxy-config.c and nm-pacrunner-manager.c 2016-10-04 11:58:32 +02:00
nm-proxy-config.h proxy: remove unnecessary APIs 2016-10-04 11:44:44 +02:00
nm-rfkill-manager.c all: say Wi-Fi instead of "wifi" or "WiFi" 2018-11-29 17:53:35 +01:00
nm-rfkill-manager.h core: refactor private data in "src" 2016-10-04 09:50:56 +02:00
nm-session-monitor.c all: avoid g_memdup() 2018-09-07 11:24:17 +02:00
nm-session-monitor.h core: refactor private data in "src" 2016-10-04 09:50:56 +02:00
nm-sleep-monitor.c all: don't use gchar/gshort/gint/glong but C types 2018-07-11 12:02:06 +02:00
nm-sleep-monitor.h core: refactor private data in "src" 2016-10-04 09:50:56 +02:00
nm-test-utils-core.h build: avoid header conflict for <linux/if.h> and <net/if.h> with "nm-platform.h" 2018-11-12 16:02:35 +01:00
nm-types.h core: Introduce helper class to track connection keep alive 2018-11-17 12:15:40 +01:00
org.freedesktop.NetworkManager.conf all: replace "it's" with "its" where needed 2018-04-18 14:14:07 +02:00