Thomas Haller 7771473f46 libnm,core: add _nm_connection_aggregate() to replace nm_connection_for_each_setting_value() ... We should no longer use nm_connection_for_each_setting_value() and nm_setting_for_each_value(). It's fundamentally broken as it does not work with properties that are not backed by a GObject property and it cannot be fixed because it is public API. Add an internal function _nm_connection_aggregate() to replace it. Compare the implementation of the aggregation functionality inside libnm with the previous two checks for secret-flags that it replaces: - previous approach broke abstraction and require detailed knowledge of secret flags. Meaning, they must special case NMSettingVpn and GObject-property based secrets. If we implement a new way for implementing secrets (like we will need for WireGuard), then this the new way should only affect libnm-core, not require changes elsewhere. - it's very inefficient to itereate over all settings. It involves cloning and sorting the list of settings, and retrieve and clone all GObject properties. Only to look at secret properties alone. _nm_connection_aggregate() is supposed to be more flexible then just the two new aggregate types that perform a "find-any" search. The @arg argument and boolean return value can suffice to implement different aggregation types in the future. Also fixes the check of NMAgentManager for secret flags for VPNs (NM_CONNECTION_AGGREGATE_ANY_SYSTEM_SECRET_FLAGS). A secret for VPNs is a property that either has a secret or a secret-flag. The previous implementation would only look at present secrets and check their flags. It wouldn't check secret-flags that are NM_SETTING_SECRET_FLAG_NONE, but have no secret.		2019-01-07 10:54:28 +01:00
..
certs	libnm-core: support private keys encrypted with AES-{192,256}-CBC	2018-08-28 11:05:01 +02:00
meson.build	libnm: use "libnm-systemd-shared.a" in "libnm-core.la" (and "libnm.so")	2019-01-02 17:08:41 +01:00
nm-core-tests-enum-types.c.template	build: use template files for enum types' sources generation	2017-12-18 11:25:06 +01:00
nm-core-tests-enum-types.h.template	build: use template files for enum types' sources generation	2017-12-18 11:25:06 +01:00
test-compare.c	shared: move shared files to subdirectory "shared/nm-utils/"	2016-06-16 10:45:53 +02:00
test-crypto.c	libnm/crypto: refactor nmtst_crypto_rsa_key_encrypt() and clear memory	2018-09-04 07:38:30 +02:00
test-general-enums.h	utils: support unknown numeric values in nm_utils_enum_to_str() and nm_utils_enum_from_str()	2017-02-20 13:45:32 +01:00
test-general.c	libnm,core: add _nm_connection_aggregate() to replace nm_connection_for_each_setting_value()	2019-01-07 10:54:28 +01:00
test-keyfile.c	keyfile: split automatically setting ID/UUID for keyfile	2018-10-04 11:03:23 +02:00
test-secrets.c	build: use default NM_BUILD_* defines for tests	2018-05-31 15:59:38 +02:00
test-setting.c	keyfile: rework handling of GObject properties from keyfile	2019-01-07 10:41:00 +01:00
test-settings-defaults.c	shared: move shared files to subdirectory "shared/nm-utils/"	2016-06-16 10:45:53 +02:00