mirror of
https://gitlab.freedesktop.org/NetworkManager/NetworkManager.git
synced 2025-12-28 16:50:16 +01:00
e1c7a2b5d0
We commonly don't use the glib typedefs for char/short/int/long,
but their C types directly.
$ git grep '\<g\(char\|short\|int\|long\|float\|double\)\>' | wc -l
587
$ git grep '\<\(char\|short\|int\|long\|float\|double\)\>' | wc -l
21114
One could argue that using the glib typedefs is preferable in
public API (of our glib based libnm library) or where it clearly
is related to glib, like during
g_object_set (obj, PROPERTY, (gint) value, NULL);
However, that argument does not seem strong, because in practice we don't
follow that argument today, and seldomly use the glib typedefs.
Also, the style guide for this would be hard to formalize, because
"using them where clearly related to a glib" is a very loose suggestion.
Also note that glib typedefs will always just be typedefs of the
underlying C types. There is no danger of glib changing the meaning
of these typedefs (because that would be a major API break of glib).
A simple style guide is instead: don't use these typedefs.
No manual actions, I only ran the bash script:
FILES=($(git ls-files '*.[hc]'))
sed -i \
-e 's/\<g\(char\|short\|int\|long\|float\|double\)\>\( [^ ]\)/\1\2/g' \
-e 's/\<g\(char\|short\|int\|long\|float\|double\)\> /\1 /g' \
-e 's/\<g\(char\|short\|int\|long\|float\|double\)\>/\1/g' \
"${FILES[@]}"
70 lines
4.2 KiB
C
70 lines
4.2 KiB
C
/* -*- Mode: C; tab-width: 4; indent-tabs-mode: t; c-basic-offset: 4 -*- */
|
|
/*
|
|
* This program is free software; you can redistribute it and/or
|
|
* modify it under the terms of the GNU General Public License as
|
|
* published by the Free Software Foundation; either version 2 of the
|
|
* License, or (at your option) any later version.
|
|
*
|
|
* This program is distributed in the hope that it will be useful, but
|
|
* WITHOUT ANY WARRANTY; without even the implied warranty of
|
|
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU
|
|
* General Public License for more details.
|
|
*
|
|
* You should have received a copy of the GNU General Public License
|
|
* along with this program. If not, see <http://www.gnu.org/licenses/>.
|
|
*
|
|
* Copyright 2013 Red Hat, Inc.
|
|
*/
|
|
|
|
#ifndef NM_EDITOR_BINDINGS_H
|
|
#define NM_EDITOR_BINDINGS_H
|
|
|
|
void nm_editor_bindings_init (void);
|
|
|
|
void nm_editor_bind_ip_addresses_with_prefix_to_strv (int family,
|
|
gpointer source,
|
|
const char *source_property,
|
|
gpointer target,
|
|
const char *target_property,
|
|
GBindingFlags flags);
|
|
void nm_editor_bind_ip_addresses_to_strv (int family,
|
|
gpointer source,
|
|
const char *source_property,
|
|
gpointer target,
|
|
const char *target_property,
|
|
GBindingFlags flags);
|
|
|
|
void nm_editor_bind_ip_gateway_to_string (int family,
|
|
NMSettingIPConfig *source,
|
|
gpointer target,
|
|
const char *target_property,
|
|
const char *target_sensitive_property,
|
|
GBindingFlags flags);
|
|
|
|
void nm_editor_bind_ip_route_to_strings (int family,
|
|
gpointer source,
|
|
const char *source_property,
|
|
gpointer dest_target,
|
|
const char *dest_target_property,
|
|
gpointer next_hop_target,
|
|
const char *next_hop_target_property,
|
|
gpointer metric_target,
|
|
const char *metric_target_property,
|
|
GBindingFlags flags);
|
|
|
|
void nm_editor_bind_wireless_security_method (NMConnection *connection,
|
|
NMSettingWirelessSecurity *s_wsec,
|
|
gpointer target,
|
|
const char *target_property,
|
|
GBindingFlags flags);
|
|
void nm_editor_bind_wireless_security_wep_key (NMSettingWirelessSecurity *s_wsec,
|
|
gpointer entry,
|
|
const char *entry_property,
|
|
gpointer key_selector,
|
|
const char *key_selector_property,
|
|
GBindingFlags flags);
|
|
|
|
void nm_editor_bind_vlan_name (NMSettingVlan *s_vlan,
|
|
NMSettingConnection *s_con);
|
|
|
|
#endif /* NM_EDITOR_BINDINGS_H */
|