NetworkManager/libnm-glib
Dan Winship 396610d14a libnm-glib: fix assertion-failure messages in test-remote-settings-client
test-remote-setting-client uses a macro:

    #define test_assert(condition) \
    do { \
        if (!G_LIKELY (condition)) \
            cleanup (); \
        g_assert (condition); \
    } while (0)

where cleanup() kills the fake remote-settings service and unrefs
settings. However, in many cases, "condition" would involve a test
against a connection that was owned by settings, so if the check
failed, the connection would end up getting freed by cleanup(), and so
then the second invocation of condition would result in the program
aborting on a failed check somewhere else (eg, "invalid unclassed
pointer in cast to 'NMConnection'") rather than displaying the failed
assertion that had gotten us to that point.

Fix this by not unreffing settings from cleanup(); in the normal exit
case we can just have main() unref it, and in the assertion-failed
case, we don't need to free things anyway.
2014-07-20 08:58:56 -04:00
..
tests libnm-glib: fix assertion-failure messages in test-remote-settings-client 2014-07-20 08:58:56 -04:00
libnm-glib-test.c libnm-glib: don't use deprecated nm_access_point_get_hw_address() 2014-06-07 11:19:02 +02:00
libnm-glib-vpn.pc.in release: bump version to 0.9.0 2011-08-22 20:33:07 -05:00
libnm-glib-vpn.ver libnm-glib-vpn: add support for interactive secrets requests 2013-07-31 08:16:40 -05:00
libnm-glib.pc.in libnm-glib,libnm-util: -glib requires -util, -util requires NetworkManager 2013-03-14 10:23:19 -05:00
libnm-glib.ver libnm-glib: add nm_device_get_setting_type() 2014-03-06 09:38:36 -05:00
libnm_glib.c all: g_type_init() has been deprecated in GLib 2.35.0 2014-05-27 16:58:21 +02:00
libnm_glib.h libnm-glib: deprecate original libnm_glib bits 2010-03-10 09:18:08 -08:00
Makefile.am build: more srcdir!=builddir fixes 2014-07-15 11:37:19 -04:00
nm-access-point.c libnm-util, libnm-glib: whitespace fixes 2014-07-15 09:44:55 -04:00
nm-access-point.h libnm-util, libnm-glib: standardize copyright/license headers 2014-07-15 09:44:54 -04:00
nm-active-connection.c libnm-util, libnm-glib: whitespace fixes 2014-07-15 09:44:55 -04:00
nm-active-connection.h libnm-util, libnm-glib: standardize copyright/license headers 2014-07-15 09:44:54 -04:00
nm-client.c libnm-util, libnm-glib: whitespace fixes 2014-07-15 09:44:55 -04:00
nm-client.h libnm-util, libnm-glib: standardize copyright/license headers 2014-07-15 09:44:54 -04:00
nm-dbus-helpers-private.h libnm-util, libnm-glib: standardize copyright/license headers 2014-07-15 09:44:54 -04:00
nm-dbus-helpers.c libnm-glib: drop separate test library 2014-07-15 09:44:55 -04:00
nm-device-adsl.c libnm-util, libnm-glib: standardize copyright/license headers 2014-07-15 09:44:54 -04:00
nm-device-adsl.h libnm-util, libnm-glib: standardize copyright/license headers 2014-07-15 09:44:54 -04:00
nm-device-bond.c libnm-util, libnm-glib: whitespace fixes 2014-07-15 09:44:55 -04:00
nm-device-bond.h libnm-util, libnm-glib: standardize copyright/license headers 2014-07-15 09:44:54 -04:00
nm-device-bridge.c libnm-util, libnm-glib: standardize copyright/license headers 2014-07-15 09:44:54 -04:00
nm-device-bridge.h libnm-util, libnm-glib: standardize copyright/license headers 2014-07-15 09:44:54 -04:00
nm-device-bt.c libnm-util, libnm-glib: whitespace fixes 2014-07-15 09:44:55 -04:00
nm-device-bt.h libnm-util, libnm-glib: standardize copyright/license headers 2014-07-15 09:44:54 -04:00
nm-device-ethernet.c libnm-util, libnm-glib: whitespace fixes 2014-07-15 09:44:55 -04:00
nm-device-ethernet.h libnm-util, libnm-glib: standardize copyright/license headers 2014-07-15 09:44:54 -04:00
nm-device-generic.c libnm-util, libnm-glib: whitespace fixes 2014-07-15 09:44:55 -04:00
nm-device-generic.h libnm-util, libnm-glib: standardize copyright/license headers 2014-07-15 09:44:54 -04:00
nm-device-infiniband.c libnm-util, libnm-glib: whitespace fixes 2014-07-15 09:44:55 -04:00
nm-device-infiniband.h libnm-util, libnm-glib: standardize copyright/license headers 2014-07-15 09:44:54 -04:00
nm-device-modem.c libnm-util, libnm-glib: whitespace fixes 2014-07-15 09:44:55 -04:00
nm-device-modem.h libnm-util, libnm-glib: standardize copyright/license headers 2014-07-15 09:44:54 -04:00
nm-device-olpc-mesh.c libnm-util, libnm-glib: whitespace fixes 2014-07-15 09:44:55 -04:00
nm-device-olpc-mesh.h libnm-util, libnm-glib: standardize copyright/license headers 2014-07-15 09:44:54 -04:00
nm-device-private.h libnm-util, libnm-glib: standardize copyright/license headers 2014-07-15 09:44:54 -04:00
nm-device-team.c libnm-util, libnm-glib: whitespace fixes 2014-07-15 09:44:55 -04:00
nm-device-team.h libnm-util, libnm-glib: standardize copyright/license headers 2014-07-15 09:44:54 -04:00
nm-device-vlan.c libnm-util, libnm-glib: standardize copyright/license headers 2014-07-15 09:44:54 -04:00
nm-device-vlan.h libnm-util, libnm-glib: standardize copyright/license headers 2014-07-15 09:44:54 -04:00
nm-device-wifi.c libnm-util, libnm-glib: whitespace fixes 2014-07-15 09:44:55 -04:00
nm-device-wifi.h libnm-util, libnm-glib: standardize copyright/license headers 2014-07-15 09:44:54 -04:00
nm-device-wimax.c libnm-util, libnm-glib: whitespace fixes 2014-07-15 09:44:55 -04:00
nm-device-wimax.h libnm-util, libnm-glib: whitespace fixes 2014-07-15 09:44:55 -04:00
nm-device.c libnm-util, libnm-glib: whitespace fixes 2014-07-15 09:44:55 -04:00
nm-device.h libnm-util, libnm-glib: standardize copyright/license headers 2014-07-15 09:44:54 -04:00
nm-dhcp4-config.c libnm-util, libnm-glib: whitespace fixes 2014-07-15 09:44:55 -04:00
nm-dhcp4-config.h libnm-util, libnm-glib: standardize copyright/license headers 2014-07-15 09:44:54 -04:00
nm-dhcp6-config.c libnm-util, libnm-glib: whitespace fixes 2014-07-15 09:44:55 -04:00
nm-dhcp6-config.h libnm-util, libnm-glib: standardize copyright/license headers 2014-07-15 09:44:54 -04:00
nm-ip4-config.c libnm-util, libnm-glib: whitespace fixes 2014-07-15 09:44:55 -04:00
nm-ip4-config.h libnm-util, libnm-glib: standardize copyright/license headers 2014-07-15 09:44:54 -04:00
nm-ip6-config.c libnm-util, libnm-glib: whitespace fixes 2014-07-15 09:44:55 -04:00
nm-ip6-config.h libnm-util, libnm-glib: standardize copyright/license headers 2014-07-15 09:44:54 -04:00
nm-object-cache.c libnm-util, libnm-glib: whitespace fixes 2014-07-15 09:44:55 -04:00
nm-object-cache.h libnm-util, libnm-glib: standardize copyright/license headers 2014-07-15 09:44:54 -04:00
nm-object-private.h libnm-util, libnm-glib: whitespace fixes 2014-07-15 09:44:55 -04:00
nm-object.c libnm-util, libnm-glib: whitespace fixes 2014-07-15 09:44:55 -04:00
nm-object.h libnm-util, libnm-glib: standardize copyright/license headers 2014-07-15 09:44:54 -04:00
nm-remote-connection-private.h libnm-util, libnm-glib: whitespace fixes 2014-07-15 09:44:55 -04:00
nm-remote-connection.c libnm-util, libnm-glib: whitespace fixes 2014-07-15 09:44:55 -04:00
nm-remote-connection.h libnm-util, libnm-glib: whitespace fixes 2014-07-15 09:44:55 -04:00
nm-remote-settings.c libnm-util, libnm-glib: whitespace fixes 2014-07-15 09:44:55 -04:00
nm-remote-settings.h libnm-util, libnm-glib: standardize copyright/license headers 2014-07-15 09:44:54 -04:00
nm-secret-agent.c libnm-util, libnm-glib: whitespace fixes 2014-07-15 09:44:55 -04:00
nm-secret-agent.h libnm-util, libnm-glib: whitespace fixes 2014-07-15 09:44:55 -04:00
nm-types-private.h libnm-util, libnm-glib: whitespace fixes 2014-07-15 09:44:55 -04:00
nm-types.c libnm-util, libnm-glib: whitespace fixes 2014-07-15 09:44:55 -04:00
nm-types.h libnm-util, libnm-glib: standardize copyright/license headers 2014-07-15 09:44:54 -04:00
nm-vpn-connection.c libnm-util, libnm-glib: whitespace fixes 2014-07-15 09:44:55 -04:00
nm-vpn-connection.h libnm-util, libnm-glib: standardize copyright/license headers 2014-07-15 09:44:54 -04:00
nm-vpn-plugin-ui-interface.c libnm-util, libnm-glib: whitespace fixes 2014-07-15 09:44:55 -04:00
nm-vpn-plugin-ui-interface.h libnm-util, libnm-glib: standardize copyright/license headers 2014-07-15 09:44:54 -04:00
nm-vpn-plugin-utils.c libnm-util, libnm-glib: standardize copyright/license headers 2014-07-15 09:44:54 -04:00
nm-vpn-plugin-utils.h libnm-util, libnm-glib: standardize copyright/license headers 2014-07-15 09:44:54 -04:00
nm-vpn-plugin.c libnm-util, libnm-glib: whitespace fixes 2014-07-15 09:44:55 -04:00
nm-vpn-plugin.h libnm-util, libnm-glib: standardize copyright/license headers 2014-07-15 09:44:54 -04:00
nm-wimax-nsp.c libnm-util, libnm-glib: whitespace fixes 2014-07-15 09:44:55 -04:00
nm-wimax-nsp.h libnm-util, libnm-glib: standardize copyright/license headers 2014-07-15 09:44:54 -04:00