mirror of
https://gitlab.freedesktop.org/NetworkManager/NetworkManager.git
synced 2026-06-06 03:38:32 +02:00
2ef5014f98
glib really likes the numeric source IDs. That is, g_idle_add(), g_timeout_add(), etc. return those IDs, that can then be destroyed with g_remove_source() (or nm_clear_g_source()). I think these numeric IDs are really not great. - API like g_idle_add() and g_remove_source() only works with the g_main_context_get_default() instance. That means, you cannot use this API for any other contexts. If you'd insist on using numeric IDs, you'd need to call g_main_context_find_source_by_id() on the right context first (but you'd also have to track the context alongside the ID). - g_remove_source() requires first a call to g_main_context_find_source_by_id(). This involves taking a mutex and doing an extra hash lookup. Instead, it often seems preferable to use the GSource instance directly. It works with any context, it can be referenced and unreferenced, and it can be destroyed, and avoids the overhead of g_main_context_find_source_by_id(). The only downside really is that keeping a GSource pointer takes one pointer size, while the guint source ID is usually only 4 bytes. Anyway, I think we should deal more with GSource instances directly. Hence, add this convenience macro, that works like nm_clear_g_source(). |
||
|---|---|---|
| .. | ||
| nm-c-list.h | ||
| nm-dbus-aux.c | ||
| nm-dbus-aux.h | ||
| nm-dedup-multi.c | ||
| nm-dedup-multi.h | ||
| nm-enum-utils.c | ||
| nm-enum-utils.h | ||
| nm-errno.c | ||
| nm-errno.h | ||
| nm-glib.h | ||
| nm-hash-utils.c | ||
| nm-hash-utils.h | ||
| nm-io-utils.c | ||
| nm-io-utils.h | ||
| nm-jansson.h | ||
| nm-json-aux.c | ||
| nm-json-aux.h | ||
| nm-keyfile-aux.c | ||
| nm-keyfile-aux.h | ||
| nm-logging-fwd.h | ||
| nm-macros-internal.h | ||
| nm-obj.h | ||
| nm-random-utils.c | ||
| nm-random-utils.h | ||
| nm-ref-string.c | ||
| nm-ref-string.h | ||
| nm-secret-utils.c | ||
| nm-secret-utils.h | ||
| nm-shared-utils.c | ||
| nm-shared-utils.h | ||
| nm-time-utils.c | ||
| nm-time-utils.h | ||
| nm-value-type.h | ||