fdo-mirrors/NetworkManager
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/NetworkManager/NetworkManager.git synced 2025-12-28 09:50:09 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions
NetworkManager/clients/tui
History
Beniamino Galvani 91a460c0b4 tui: fix creation of open Wi-Fi connections 
Commit 6a4af482f0 ("nmtui: always create ethernet settings for VLAN
and wireless security for wifi.") changed nmtui to always add the
wireless security setting to the new connection, but without
initializing it. This leads to a crash that was fixed in 40fcf67a84
("tui: fix crash creating Wi-Fi connection").

There is an additional bug: connections without authentication can't
be saved because the wireless security setting has uninitialized
fields.

To fix this, revert both patches (the first partially) because the
previous code did the right thing as it added the setting only when
needed.

Fixes: 6a4af482f0

https://bugzilla.redhat.com/show_bug.cgi?id=1518167
(cherry picked from commit fead82f419)
2017-11-30 23:43:30 +01:00
..
newt all: use nm_close() instead of close() 2017-11-14 15:17:02 +01:00
nm-editor-bindings.c tui: fix creation of open Wi-Fi connections 2017-11-30 23:43:30 +01:00
nm-editor-bindings.h include: use double-quotes to include our own headers 2017-03-09 14:12:35 +01:00
nm-editor-utils.c all: use "unsigned" instead of "unsigned int" 2017-03-14 11:26:29 +01:00
nm-editor-utils.h include: use double-quotes to include our own headers 2017-03-09 14:12:35 +01:00
nmt-address-list.c all: cleanup includes and let "nm-default.h" include "config.h" 2016-02-19 17:53:25 +01:00
nmt-address-list.h all: cleanup includes in header files 2016-08-17 19:51:17 +02:00
nmt-connect-connection-list.c core,clients: use our own string hashing function nm_str_hash() 2017-10-18 13:05:00 +02:00
nmt-connect-connection-list.h all: cleanup includes in header files 2016-08-17 19:51:17 +02:00
nmt-device-entry.c all: use nm_utils_is_valid_iface_name() 2017-01-06 15:11:56 +01:00
nmt-device-entry.h include: use double-quotes to include our own headers 2017-03-09 14:12:35 +01:00
nmt-edit-connection-list.c tui/edit-connection-list: add routine to recommit connections in a list 2017-02-27 11:16:45 +01:00
nmt-edit-connection-list.h include: use double-quotes to include our own headers 2017-03-09 14:12:35 +01:00
nmt-editor-grid.c all: cleanup includes and let "nm-default.h" include "config.h" 2016-02-19 17:53:25 +01:00
nmt-editor-grid.h all: cleanup includes in header files 2016-08-17 19:51:17 +02:00
nmt-editor-page-device.c all: cleanup includes and let "nm-default.h" include "config.h" 2016-02-19 17:53:25 +01:00
nmt-editor-page-device.h all: cleanup includes in header files 2016-08-17 19:51:17 +02:00
nmt-editor-page.c tui/editor: notify the pages after the connection is saved 2017-02-27 11:17:39 +01:00
nmt-editor-page.h include: use double-quotes to include our own headers 2017-03-09 14:12:35 +01:00
nmt-editor-section.c all: cleanup includes and let "nm-default.h" include "config.h" 2016-02-19 17:53:25 +01:00
nmt-editor-section.h all: cleanup includes in header files 2016-08-17 19:51:17 +02:00
nmt-editor.c tui/editor: notify the pages after the connection is saved 2017-02-27 11:17:39 +01:00
nmt-editor.h include: use double-quotes to include our own headers 2017-03-09 14:12:35 +01:00
nmt-ip-entry.c shared: pass addr_family as first argument to nm_utils_parse_inaddr*() 2017-10-06 11:08:39 +02:00
nmt-ip-entry.h all: cleanup includes in header files 2016-08-17 19:51:17 +02:00
nmt-mac-entry.c libnm: fix regression serializing empty "cloned-mac-address" 2016-09-06 16:11:23 +02:00
nmt-mac-entry.h all: cleanup includes in header files 2016-08-17 19:51:17 +02:00
nmt-mtu-entry.c all: cleanup includes and let "nm-default.h" include "config.h" 2016-02-19 17:53:25 +01:00
nmt-mtu-entry.h all: cleanup includes in header files 2016-08-17 19:51:17 +02:00
nmt-page-bond.c nmtui: add support for cloned mac in bond interfaces 2017-05-28 23:22:55 +02:00
nmt-page-bond.h all: cleanup includes in header files 2016-08-17 19:51:17 +02:00
nmt-page-bridge-port.c all: cleanup includes and let "nm-default.h" include "config.h" 2016-02-19 17:53:25 +01:00
nmt-page-bridge-port.h all: cleanup includes in header files 2016-08-17 19:51:17 +02:00
nmt-page-bridge.c tui: add group-forward-mask property to bridge page 2017-10-13 14:17:26 +02:00
nmt-page-bridge.h all: cleanup includes in header files 2016-08-17 19:51:17 +02:00
nmt-page-dsl.c all: cleanup includes and let "nm-default.h" include "config.h" 2016-02-19 17:53:25 +01:00
nmt-page-dsl.h all: cleanup includes in header files 2016-08-17 19:51:17 +02:00
nmt-page-ethernet.c device: extend MAC address handling including randomization for ethernet and wifi 2016-06-30 08:29:56 +02:00
nmt-page-ethernet.h all: cleanup includes in header files 2016-08-17 19:51:17 +02:00
nmt-page-infiniband.c all: cleanup includes and let "nm-default.h" include "config.h" 2016-02-19 17:53:25 +01:00
nmt-page-infiniband.h all: cleanup includes in header files 2016-08-17 19:51:17 +02:00
nmt-page-ip-tunnel.c tui: add support for IP tunnel connections 2016-11-09 17:45:39 +01:00
nmt-page-ip-tunnel.h tui: add support for IP tunnel connections 2016-11-09 17:45:39 +01:00
nmt-page-ip4.c tui: add ignore-auto-dns property to IPv4 and IPv6 pages 2017-09-01 17:09:57 +02:00
nmt-page-ip4.h all: cleanup includes in header files 2016-08-17 19:51:17 +02:00
nmt-page-ip6.c tui: add ignore-auto-dns property to IPv4 and IPv6 pages 2017-09-01 17:09:57 +02:00
nmt-page-ip6.h all: cleanup includes in header files 2016-08-17 19:51:17 +02:00
nmt-page-ppp.c all: cleanup includes and let "nm-default.h" include "config.h" 2016-02-19 17:53:25 +01:00
nmt-page-ppp.h all: cleanup includes in header files 2016-08-17 19:51:17 +02:00
nmt-page-team-port.c all: cleanup includes and let "nm-default.h" include "config.h" 2016-02-19 17:53:25 +01:00
nmt-page-team-port.h all: cleanup includes in header files 2016-08-17 19:51:17 +02:00
nmt-page-team.c tui: recommit bond, bridge and team slaves on master save 2017-02-27 11:17:39 +01:00
nmt-page-team.h all: cleanup includes in header files 2016-08-17 19:51:17 +02:00
nmt-page-vlan.c nmtui: always create ethernet settings for VLAN and wireless security for wifi. 2017-05-28 23:22:55 +02:00
nmt-page-vlan.h all: cleanup includes in header files 2016-08-17 19:51:17 +02:00
nmt-page-wifi.c tui: fix creation of open Wi-Fi connections 2017-11-30 23:43:30 +01:00
nmt-page-wifi.h all: cleanup includes in header files 2016-08-17 19:51:17 +02:00
nmt-password-dialog.c all: cleanup includes and let "nm-default.h" include "config.h" 2016-02-19 17:53:25 +01:00
nmt-password-dialog.h all: cleanup includes in header files 2016-08-17 19:51:17 +02:00
nmt-password-fields.c all: cleanup includes and let "nm-default.h" include "config.h" 2016-02-19 17:53:25 +01:00
nmt-password-fields.h all: cleanup includes in header files 2016-08-17 19:51:17 +02:00
nmt-route-editor.c all: cleanup includes and let "nm-default.h" include "config.h" 2016-02-19 17:53:25 +01:00
nmt-route-editor.h include: use double-quotes to include our own headers 2017-03-09 14:12:35 +01:00
nmt-route-entry.c tui: extend range of route metric to full uint32 2017-09-05 19:27:19 +02:00
nmt-route-entry.h all: cleanup includes in header files 2016-08-17 19:51:17 +02:00
nmt-route-table.c tui: change default route metric of new routes to -1 2017-09-05 19:10:07 +02:00
nmt-route-table.h all: cleanup includes in header files 2016-08-17 19:51:17 +02:00
nmt-slave-list.c all: cleanup includes and let "nm-default.h" include "config.h" 2016-02-19 17:53:25 +01:00
nmt-slave-list.h all: cleanup includes in header files 2016-08-17 19:51:17 +02:00
nmt-utils.c all: cleanup includes and let "nm-default.h" include "config.h" 2016-02-19 17:53:25 +01:00
nmt-utils.h all: cleanup includes in header files 2016-08-17 19:51:17 +02:00
nmt-widget-list.c all: cleanup includes and let "nm-default.h" include "config.h" 2016-02-19 17:53:25 +01:00
nmt-widget-list.h all: cleanup includes in header files 2016-08-17 19:51:17 +02:00
nmtui-connect.c tui: improve tracking of activation state 2017-10-16 17:43:37 +02:00
nmtui-connect.h all: cleanup includes in header files 2016-08-17 19:51:17 +02:00
nmtui-edit.c tui: avoid failed assertion when adding bond slaves 2016-08-01 17:20:38 +02:00
nmtui-edit.h all: cleanup includes in header files 2016-08-17 19:51:17 +02:00
nmtui-hostname.c tui: return to initial menu after sub-forms exit 2016-04-15 13:27:42 +02:00
nmtui-hostname.h all: cleanup includes in header files 2016-08-17 19:51:17 +02:00
nmtui.c tui: quit from top-level form when exiting 2016-04-27 10:52:31 +02:00
nmtui.h include: use double-quotes to include our own headers 2017-03-09 14:12:35 +01:00