NetworkManager/src
Thomas Haller 1feaf427d2
platform: rework handling of failed routes during nm_platform_ip_route_sync()
Previously, there was "temporary-not-available" mechanism in NML3Cfg,
which aimed to handle IPv6 routes with prefsrc. Theoretically, that
mechanism may have been extended to other use-cases, like IPv4 routes
with prefsrc. What it attempted to handle, is the inability to configure
such routes, unless the respective prefsrc address is configured and
non-tentative.  However, the address that we are waiting for, could also
be on another interface, so that mechanism wasn't applicable. This is
now replaced by _routes_watch_ip_addrs(). It seems there isn't anything
useful left for the "temporary-not-available" mechanism and it can go,
except...

We want to log a warning when we are unable to configure a route. Also,
in the future we might want to know when the IP configuration is
degradated due to inability to configure the desired routes (a condition
that  we might want to expose to the user, not only via logging; or we
may want to react on that).

However, with prefsrc routes we don't know right away whether the
inability to configure the route right away indicates an actual problem,
or whether that will resolve itself (e.g. after the address passes
DAD/ACD, after we received an DHCP lease or after the address was
configured on another interface).  Consequently, to know whether the
current inability to configure such a route is a problem, we need to
know the larger context.  nm_platform_ip_route_sync() does not have that
context.

Instead, nm_platform_ip_route_sync() needs only do debug log about
failure to configure routes. It  will now also  return all the failed
routes to NML3Cfg, which can decide whether that is a problem.

This reworks the previous "temporary-not-available" mechanism to track
the state of the failed routes, to eventually decide whether there is an
actual problem (and log about it).

Another problem this solves is that since commit ('platform: always
reconfigure IP routes even if removed externally'), we will eagerly
re-try to configure the same route over and over. We cannot just spam
the log with warnings about the same failure on every commit. We need to
remember that we already logged about the problem and rate limit
warnings otherwise. This is what the new mechanism also achieves.

Indeed, all this is mostly for the sole benefit of logging better
warnings (and not duplicated).
2023-03-21 15:58:55 +01:00
..
c-list c-list: re-import git-subtree for 'src/c-list' 2022-07-19 09:02:36 +02:00
c-rbtree c-rbtree: re-import git-subtree for 'src/c-rbtree' 2022-11-23 18:00:31 +01:00
c-siphash c-siphash: re-import git-subtree for 'src/c-siphash' 2022-11-23 18:00:33 +01:00
c-stdaux c-stdaux: re-import git-subtree for 'src/c-stdaux' 2023-03-03 13:40:38 +01:00
contrib all: adjust glib-mkenums annotations for automated formatting 2022-02-08 11:14:01 +01:00
core platform: rework handling of failed routes during nm_platform_ip_route_sync() 2023-03-21 15:58:55 +01:00
libnm-base base: add nm_dhcp_iaid_{from,to}_hexstr() helpers 2023-02-21 09:13:08 +01:00
libnm-client-aux-extern all: use nm_random_*() instead of g_random_*() 2023-01-30 10:51:13 +01:00
libnm-client-impl all: add "link" setting 2023-03-02 16:51:16 +01:00
libnm-client-public all: add "link" setting 2023-03-02 16:51:16 +01:00
libnm-client-test build/meson: add dependency libnm_client_public_dep for "libnm-client-test" 2022-05-04 08:56:58 +02:00
libnm-core-aux-extern nm-dispatcher: dispatch on reapply 2023-02-08 17:08:35 +01:00
libnm-core-aux-intern bonding: add support to ns_ip6_target option 2023-03-06 15:06:41 +01:00
libnm-core-impl libnmc-setting/docs: how to disable ip-tunnel.encapsulation-limit (ip6) 2023-03-13 08:41:45 +00:00
libnm-core-intern bonding: add support to ns_ip6_target option 2023-03-06 15:06:41 +01:00
libnm-core-public bonding: add support to ns_ip6_target option 2023-03-06 15:06:41 +01:00
libnm-crypto all: fix various "-Wcast-align=strict" warnings 2022-12-09 09:15:56 +01:00
libnm-glib-aux glib-aux/prioq: rename NM_PRIOQ_FOREACH_ITEM() to nm_prioq_for_each() 2023-03-21 15:58:39 +01:00
libnm-lldp glib-aux/prioq: assert for valid index in find_item() of NMPrioq 2023-03-21 15:58:39 +01:00
libnm-log-core log,dhcp: avoid deprecated GTimeVal API and use g_get_real_time() 2023-03-21 10:21:28 +01:00
libnm-log-null all: add some README.md files describing the purpose of our sources 2021-08-19 17:51:11 +02:00
libnm-platform platform: rework handling of failed routes during nm_platform_ip_route_sync() 2023-03-21 15:58:55 +01:00
libnm-std-aux std-aux: add c_list_is_empty_or_single() helper 2023-03-08 15:34:47 +01:00
libnm-systemd-core systemd: merge branch systemd into main 2023-02-13 15:33:02 +01:00
libnm-systemd-shared systemd: merge branch systemd into main 2023-02-13 15:33:02 +01:00
libnm-udev-aux format: reformat source tree with clang-format 13.0 2021-11-29 09:31:09 +00:00
libnmc-base all: use _NM_G_TYPE_CHECK_INSTANCE_CAST() for internal uses 2022-12-16 10:55:03 +01:00
libnmc-setting libnmc-setting/docs: how to disable ip-tunnel.encapsulation-limit (ip6) 2023-03-13 08:41:45 +00:00
libnmt-newt all: use _NM_G_TYPE_CHECK_INSTANCE_CAST() for internal uses 2022-12-16 10:55:03 +01:00
linux-headers all: add src/nm-compat-headers for patching included system headers 2022-09-23 11:43:33 +02:00
n-acd modules: patch meson subprojects to use local dependencies 2022-07-25 10:27:33 +02:00
n-dhcp4 n-dhcp4: re-import git-subtree for 'src/n-dhcp4' 2022-08-11 14:47:04 +02:00
nm-cloud-setup glib-aux,cloud-setup: move nm{cs,}_utils_poll() to libnm-glib-aux 2023-03-13 17:13:01 +01:00
nm-compat-headers all: add src/nm-compat-headers for patching included system headers 2022-09-23 11:43:33 +02:00
nm-daemon-helper nm-daemon-helper: log to stderr any error from getaddrinfo() 2023-02-21 13:46:55 +01:00
nm-dispatcher clang-format: reformat code with clang-format 15.0.4-1.fc37 2022-11-23 09:17:21 +01:00
nm-initrd-generator clang-format: reformat code with clang-format 15.0.4-1.fc37 2022-11-23 09:17:21 +01:00
nm-online clang-format: reformat code with clang-format 15.0.4-1.fc37 2022-11-23 09:17:21 +01:00
nm-priv-helper all: drop redundant includes 2022-05-09 19:20:18 +02:00
nmcli libnmc-setting/docs: how to disable ip-tunnel.encapsulation-limit (ip6) 2023-03-13 08:41:45 +00:00
nmtui bonding: add support to ns_ip6_target option 2023-03-06 15:06:41 +01:00
tests client/tests: adjust expected output for new order of replace-local-rule 2023-02-22 22:20:41 +00:00
meson.build Squashed 'src/c-stdaux/' changes from 4e78ffaea49d..2d3877aabd7d 2022-11-23 18:00:35 +01:00
README.md nm-sudo: rename to nm-priv-helper 2022-01-11 21:46:55 +01:00

src/

Most of the subdirectories are static helper libraries, which get linked into one of the final build artifacts (like libnm, nmcli or NetworkManager). Static libraries are internal API.

The only public API is libnm, which is a shared library provided client implementations.

Our own clients (like nmcli and nmtui) also use libnm, the shared library. But they also use additional static helper libraries.

The daemon statically links against a part of libnm, the part that provides connection profiles. That is libnm-core. libnm-core is thus statically linked with libnm and the daemon. It does not get linked by clients that already link with libnm (like nmtui).

Read the individual README.md files in the subdirectories for details:

Directory Description
core/ the NetworkManager daemon
nmcli/ nmcli application, a command line client for NetworkManager
nmtui/ nmtui application, a text UI client for NetworkManager
nm-cloud-setup/ service to automatically configure NetworkManager in cloud environment
nm-initrd-generator/ generates NetworkManager configuration by parsing kernel command line options for dracut/initrd
nm-dispatcher/ NetworkManager-dispatcher service to run user scripts
nm-online/ application which checks whether NetworkManager is done, for implementing NetworkManager-wait-online.service
nm-priv-helper/ internal service for privileged operations
nm-daemon-helper/ internal helper binary spawned by NetworkManager
libnm-std-aux/ internal helper library for standard C
libnm-glib-aux/ internal helper library for glib
libnm-log-null/ internal helper library with dummy (null) logging backend
libnm-log-core/ internal helper library with logging backend (syslog) used by daemon
libnm-base/ internal helper library with base definitions
libnm-platform/ internal helper library for netlink and other platform/kernel API
libnm-udev-aux/ internal helper library for libudev
libnm-core-public/ public API of libnm (libnm-core part)
libnm-core-intern/ internal API of libnm-core, used by libnm and daemon
libnm-core-impl/ implementation of libnm-core
libnm-core-aux-intern/ internal helper library on top of libnm-core (used by libnm-core itself)
libnm-core-aux-extern/ internal helper library on top of libnm-core (not used by libnm-core)
libnm-client-public/ public API of libnm (NMClient part)
libnm-client-impl/ implementation of libnm (NMClient)
libnm-client-aux-extern/ internal helper library on top of libnm (not used by libnm itself)
libnmc-base/ internal helper library for libnm clients
libnmc-setting/ internal helper library for setting connection profiles (used by nmcli)
libnmt-newt/ internal helper library for libnewt for nmtui
linux-headers/ extra Linux kernel UAPI headers
contrib/ sources that are not used by NetworkManager itself
tests/ unit tests that are not specific to one of the other directories
libnm-client-test/ internal helper library with test utils for libnm
c-list/ fork of c-util helper library for intrusive, doubly linked list
c-rbtree/ fork of c-util helper library for intrusive Red-Black Tree
c-siphash/ fork of c-util helper library for SIPHash24
c-stdaux/ fork of c-util general purpose helpers for standard C
n-acd/ fork of nettools IPv4 ACD library
n-dhcp4/ fork of nettools DHCPv4 library
libnm-systemd-core/ fork of systemd code as network library
libnm-systemd-shared/ fork of systemd code as general purpose library