Thomas Haller 1de9ddee6c libnmc-base:fix leak in NMSecretAgentSimple's request_secrets_from_ui() ... Found by Coverity: Error: RESOURCE_LEAK (CWE-772): [#def271] [important] NetworkManager-1.31.3/src/libnmc-base/nm-secret-agent-simple.c:874: alloc_fn: Storage is returned from allocation function "nm_utils_ssid_to_utf8". NetworkManager-1.31.3/src/libnmc-base/nm-secret-agent-simple.c:874: var_assign: Assigning: "ssid_utf8" = storage returned from "nm_utils_ssid_to_utf8(g_bytes_get_data(ssid, NULL), g_bytes_get_size(ssid))". NetworkManager-1.31.3/src/libnmc-base/nm-secret-agent-simple.c:877: noescape: Resource "ssid_utf8" is not freed or pointed-to in "g_strdup_printf". NetworkManager-1.31.3/src/libnmc-base/nm-secret-agent-simple.c:882: leaked_storage: Variable "ssid_utf8" going out of scope leaks the storage it points to. # 880| # 881| if (!add_wireless_secrets(request, secrets)) # 882|-> goto out_fail; # 883| } else if (nm_connection_is_type(request->connection, NM_SETTING_WIRED_SETTING_NAME)) { # 884| title = _("Wired 802.1X authentication"); Error: RESOURCE_LEAK (CWE-772): [#def272] [important] NetworkManager-1.31.3/src/libnmc-base/nm-secret-agent-simple.c:874: alloc_fn: Storage is returned from allocation function "nm_utils_ssid_to_utf8". NetworkManager-1.31.3/src/libnmc-base/nm-secret-agent-simple.c:874: var_assign: Assigning: "ssid_utf8" = storage returned from "nm_utils_ssid_to_utf8(g_bytes_get_data(ssid, NULL), g_bytes_get_size(ssid))". NetworkManager-1.31.3/src/libnmc-base/nm-secret-agent-simple.c:877: noescape: Resource "ssid_utf8" is not freed or pointed-to in "g_strdup_printf". NetworkManager-1.31.3/src/libnmc-base/nm-secret-agent-simple.c:883: leaked_storage: Variable "ssid_utf8" going out of scope leaks the storage it points to. # 881| if (!add_wireless_secrets(request, secrets)) # 882| goto out_fail; # 883|-> } else if (nm_connection_is_type(request->connection, NM_SETTING_WIRED_SETTING_NAME)) { # 884| title = _("Wired 802.1X authentication"); # 885| msg = g_strdup_printf(_("Secrets are required to access the wired network %s"), Fixes: 3fbabde4c3 ('libnm-core: replace GByteArray with pointer + length in some APIs') (cherry picked from commit 2c628e4762) (cherry picked from commit 4f5cd076ab)		2021-06-10 16:11:37 +02:00
..
cli	cli: fix showing active state for nmcli con show with fields	2020-10-09 10:24:02 +02:00
cloud-setup	cloud-setup: fix replacing IPv4 addresses during update	2021-03-12 12:43:03 +01:00
common	libnmc-base:fix leak in NMSecretAgentSimple's request_secrets_from_ui()	2021-06-10 16:11:37 +02:00
tests	Correct python black rules	2021-02-09 10:55:13 +01:00
tui	libnmt-newt: fix leak in nmt_newt_button_build_component()	2021-06-10 16:11:32 +02:00
meson.build	docs: generate nm-settings-docs-nmcli.xml based on nmcli meta data	2020-06-11 10:53:50 +02:00
nm-online.c	all: unify comment style for SPDX-License-Identifier tag	2020-09-29 16:50:53 +02:00