mirror of
https://gitlab.freedesktop.org/NetworkManager/NetworkManager.git
synced 2026-06-07 06:28:21 +02:00
17d9b852c8
When looking at nm_utils_array_find_binary_search(), we see that binary search really isn't complicated. In nm_utils_array_find_binary_search() it looks complicated, because that is our general purpose function which accepts arbitrary lists, uses an opaque compare function, accepts a user data argument, and returns the insertion position. This is unnecessary for the narrow purpose in NM_UTILS_STRING_TABLE_LOOKUP_DEFINE*(). When we inline the binary search, it can be simplified, and the remaining parts is simple enough to prefer this duplication of binary search over using our general purpose function. Also, this gives the compiler more chance for optimization. For example, we can use "unsigned" as index type instead of gssize, because we know (at compile time), that this type will always be large enough for our LIST. Also, we can directly call strcmp(). The result is that the macro's implementation is also fast in the best case (where the needle is found with only one strcmp()) and in the cases where there is a small number of items to search. It thus alleviates concerns that using the macro might be slower than an optimized implementation. The binary size of the defined function increases slightly (from 112 bytes to 192 bytes, on x86_64, GCC, -O2). But according to my tests it is slightly and measurably faster. |
||
|---|---|---|
| .. | ||
| tests | ||
| nm-c-list.h | ||
| nm-dbus-aux.c | ||
| nm-dbus-aux.h | ||
| nm-dedup-multi.c | ||
| nm-dedup-multi.h | ||
| nm-enum-utils.c | ||
| nm-enum-utils.h | ||
| nm-errno.c | ||
| nm-errno.h | ||
| nm-glib.h | ||
| nm-hash-utils.c | ||
| nm-hash-utils.h | ||
| nm-io-utils.c | ||
| nm-io-utils.h | ||
| nm-jansson.h | ||
| nm-json-aux.c | ||
| nm-json-aux.h | ||
| nm-keyfile-aux.c | ||
| nm-keyfile-aux.h | ||
| nm-logging-base.c | ||
| nm-logging-base.h | ||
| nm-logging-fwd.h | ||
| nm-macros-internal.h | ||
| nm-obj.h | ||
| nm-random-utils.c | ||
| nm-random-utils.h | ||
| nm-ref-string.c | ||
| nm-ref-string.h | ||
| nm-secret-utils.c | ||
| nm-secret-utils.h | ||
| nm-shared-utils.c | ||
| nm-shared-utils.h | ||
| nm-time-utils.c | ||
| nm-time-utils.h | ||
| nm-value-type.h | ||