NetworkManager/libnm-core
Thomas Haller 411af76312
libnm: fix leak in nm_utils_tc_tfilter_from_str()
Found by Coverity:

  Error: RESOURCE_LEAK (CWE-772):
  NetworkManager-1.31.3/src/libnm-core-impl/nm-utils.c:2772: alloc_fn: Storage is returned from allocation function "nm_utils_tc_action_from_str".
  NetworkManager-1.31.3/src/libnm-core-impl/nm-utils.c:2772: var_assign: Assigning: "action" = storage returned from "nm_utils_tc_action_from_str(extra_opts, error)".
  NetworkManager-1.31.3/src/libnm-core-impl/nm-utils.c:2785: leaked_storage: Variable "action" going out of scope leaks the storage it points to.
  # 2783|       tfilter = nm_tc_tfilter_new(kind, parent, error);
  # 2784|       if (!tfilter)
  # 2785|->         return NULL;
  # 2786|
  # 2787|       nm_tc_tfilter_set_handle(tfilter, handle);

Fixes: de41c45e61 ('libnm-core: add functionality for dealing with tc-style traffic filter specifiers')
(cherry picked from commit 3cd56e92d4)
2021-06-04 21:29:21 +02:00
..
nm-libnm-core-aux all: add "nm-glib-aux/nm-default-glib-i18n-lib.h" as replacement for "nm-default.h" 2021-02-09 12:38:17 +01:00
nm-libnm-core-intern libnm: add nm_auto_unref_tc_action cleanup macro for NMTCAction 2021-06-04 21:29:21 +02:00
tests bond: support tlb_dynamic_lb in balance-alb mode 2021-06-03 14:32:26 +02:00
meson.build libnm: move "nm-version-macros.h" from shared/ to libnm-core/ 2021-02-09 12:38:19 +01:00
nm-connection-private.h all: update deprecated SPDX license identifiers 2021-01-05 09:46:21 +01:00
nm-connection.c all: add "libnm-core/nm-default-libnm-core.h" as replacement for "nm-default.h" 2021-02-09 12:38:18 +01:00
nm-connection.h libnm/doc: consistently write "Since:" tag for enum values 2021-01-20 09:16:21 +01:00
nm-core-internal.h bond: avoid logging warning to set "ad_actor_system=00:00:00:00:00:00" 2021-02-23 14:18:33 +01:00
nm-core-types-internal.h all: update deprecated SPDX license identifiers 2021-01-05 09:46:21 +01:00
nm-core-types.h all: update deprecated SPDX license identifiers 2021-01-05 09:46:21 +01:00
nm-crypto-gnutls.c all: add "libnm-core/nm-default-libnm-core.h" as replacement for "nm-default.h" 2021-02-09 12:38:18 +01:00
nm-crypto-impl.h all: update deprecated SPDX license identifiers 2021-01-05 09:46:21 +01:00
nm-crypto-nss.c all: add "libnm-core/nm-default-libnm-core.h" as replacement for "nm-default.h" 2021-02-09 12:38:18 +01:00
nm-crypto.c all: add "libnm-core/nm-default-libnm-core.h" as replacement for "nm-default.h" 2021-02-09 12:38:18 +01:00
nm-crypto.h all: update deprecated SPDX license identifiers 2021-01-05 09:46:21 +01:00
nm-dbus-interface.h libnm/doc: consistently write "Since:" tag for enum values 2021-01-20 09:16:21 +01:00
nm-dbus-utils.c all: add "libnm-core/nm-default-libnm-core.h" as replacement for "nm-default.h" 2021-02-09 12:38:18 +01:00
nm-default-libnm-core.h all: add "libnm-core/nm-default-libnm-core.h" as replacement for "nm-default.h" 2021-02-09 12:38:18 +01:00
nm-errors.c all: add "libnm-core/nm-default-libnm-core.h" as replacement for "nm-default.h" 2021-02-09 12:38:18 +01:00
nm-errors.h libnm/doc: consistently write "Since:" tag for enum values 2021-01-20 09:16:21 +01:00
nm-keyfile-internal.h libnm: merge libnm-keyfile into libnm-core 2021-02-09 12:38:19 +01:00
nm-keyfile-utils.c libnm: merge libnm-keyfile into libnm-core 2021-02-09 12:38:19 +01:00
nm-keyfile-utils.h libnm: merge libnm-keyfile into libnm-core 2021-02-09 12:38:19 +01:00
nm-keyfile.c libnm: merge libnm-keyfile into libnm-core 2021-02-09 12:38:19 +01:00
nm-keyfile.h all: update deprecated SPDX license identifiers 2021-01-05 09:46:21 +01:00
nm-meta-setting-base-impl.c all: move shared/nm-meta-setting.[hc] to libnm-core and clients 2021-02-09 12:38:19 +01:00
nm-meta-setting-base-impl.h all: move shared/nm-meta-setting.[hc] to libnm-core and clients 2021-02-09 12:38:19 +01:00
nm-meta-setting-base.h all: move shared/nm-meta-setting.[hc] to libnm-core and clients 2021-02-09 12:38:19 +01:00
nm-property-compare.c all: add "libnm-core/nm-default-libnm-core.h" as replacement for "nm-default.h" 2021-02-09 12:38:18 +01:00
nm-property-compare.h all: update deprecated SPDX license identifiers 2021-01-05 09:46:21 +01:00
nm-setting-6lowpan.c all: add "libnm-core/nm-default-libnm-core.h" as replacement for "nm-default.h" 2021-02-09 12:38:18 +01:00
nm-setting-6lowpan.h all: update deprecated SPDX license identifiers 2021-01-05 09:46:21 +01:00
nm-setting-8021x.c setting-8021x: Fix descriptions for phase2-auth & phase2-autheap 2021-02-09 17:09:31 +01:00
nm-setting-8021x.h all: update deprecated SPDX license identifiers 2021-01-05 09:46:21 +01:00
nm-setting-adsl.c all: add "libnm-core/nm-default-libnm-core.h" as replacement for "nm-default.h" 2021-02-09 12:38:18 +01:00
nm-setting-adsl.h all: update deprecated SPDX license identifiers 2021-01-05 09:46:21 +01:00
nm-setting-bluetooth.c all: add "libnm-core/nm-default-libnm-core.h" as replacement for "nm-default.h" 2021-02-09 12:38:18 +01:00
nm-setting-bluetooth.h all: update deprecated SPDX license identifiers 2021-01-05 09:46:21 +01:00
nm-setting-bond.c bond: support tlb_dynamic_lb in balance-alb mode 2021-06-03 14:32:26 +02:00
nm-setting-bond.h all: update deprecated SPDX license identifiers 2021-01-05 09:46:21 +01:00
nm-setting-bridge-port.c all: add "libnm-core/nm-default-libnm-core.h" as replacement for "nm-default.h" 2021-02-09 12:38:18 +01:00
nm-setting-bridge-port.h all: update deprecated SPDX license identifiers 2021-01-05 09:46:21 +01:00
nm-setting-bridge.c all: add "libnm-core/nm-default-libnm-core.h" as replacement for "nm-default.h" 2021-02-09 12:38:18 +01:00
nm-setting-bridge.h all: update deprecated SPDX license identifiers 2021-01-05 09:46:21 +01:00
nm-setting-cdma.c all: add "libnm-core/nm-default-libnm-core.h" as replacement for "nm-default.h" 2021-02-09 12:38:18 +01:00
nm-setting-cdma.h all: update deprecated SPDX license identifiers 2021-01-05 09:46:21 +01:00
nm-setting-connection.c all: add "libnm-core/nm-default-libnm-core.h" as replacement for "nm-default.h" 2021-02-09 12:38:18 +01:00
nm-setting-connection.h all: update deprecated SPDX license identifiers 2021-01-05 09:46:21 +01:00
nm-setting-dcb.c all: add "libnm-core/nm-default-libnm-core.h" as replacement for "nm-default.h" 2021-02-09 12:38:18 +01:00
nm-setting-dcb.h all: update deprecated SPDX license identifiers 2021-01-05 09:46:21 +01:00
nm-setting-dummy.c all: add "libnm-core/nm-default-libnm-core.h" as replacement for "nm-default.h" 2021-02-09 12:38:18 +01:00
nm-setting-dummy.h all: update deprecated SPDX license identifiers 2021-01-05 09:46:21 +01:00
nm-setting-ethtool.c all: add "libnm-core/nm-default-libnm-core.h" as replacement for "nm-default.h" 2021-02-09 12:38:18 +01:00
nm-setting-ethtool.h libnm,shared: move nm-ethtool helper to "libnm-base" 2021-01-15 11:32:41 +01:00
nm-setting-generic.c all: add "libnm-core/nm-default-libnm-core.h" as replacement for "nm-default.h" 2021-02-09 12:38:18 +01:00
nm-setting-generic.h all: update deprecated SPDX license identifiers 2021-01-05 09:46:21 +01:00
nm-setting-gsm.c all: add "libnm-core/nm-default-libnm-core.h" as replacement for "nm-default.h" 2021-02-09 12:38:18 +01:00
nm-setting-gsm.h all: update deprecated SPDX license identifiers 2021-01-05 09:46:21 +01:00
nm-setting-hostname.c all: add "libnm-core/nm-default-libnm-core.h" as replacement for "nm-default.h" 2021-02-09 12:38:18 +01:00
nm-setting-hostname.h all: update deprecated SPDX license identifiers 2021-01-05 09:46:21 +01:00
nm-setting-infiniband.c all: add "libnm-core/nm-default-libnm-core.h" as replacement for "nm-default.h" 2021-02-09 12:38:18 +01:00
nm-setting-infiniband.h all: update deprecated SPDX license identifiers 2021-01-05 09:46:21 +01:00
nm-setting-ip-config.c all: add "libnm-core/nm-default-libnm-core.h" as replacement for "nm-default.h" 2021-02-09 12:38:18 +01:00
nm-setting-ip-config.h all: update deprecated SPDX license identifiers 2021-01-05 09:46:21 +01:00
nm-setting-ip-tunnel.c all: add "libnm-core/nm-default-libnm-core.h" as replacement for "nm-default.h" 2021-02-09 12:38:18 +01:00
nm-setting-ip-tunnel.h all: update deprecated SPDX license identifiers 2021-01-05 09:46:21 +01:00
nm-setting-ip4-config.c all: add "libnm-core/nm-default-libnm-core.h" as replacement for "nm-default.h" 2021-02-09 12:38:18 +01:00
nm-setting-ip4-config.h all: update deprecated SPDX license identifiers 2021-01-05 09:46:21 +01:00
nm-setting-ip6-config.c all: add "libnm-core/nm-default-libnm-core.h" as replacement for "nm-default.h" 2021-02-09 12:38:18 +01:00
nm-setting-ip6-config.h all: update deprecated SPDX license identifiers 2021-01-05 09:46:21 +01:00
nm-setting-macsec.c all: add "libnm-core/nm-default-libnm-core.h" as replacement for "nm-default.h" 2021-02-09 12:38:18 +01:00
nm-setting-macsec.h all: update deprecated SPDX license identifiers 2021-01-05 09:46:21 +01:00
nm-setting-macvlan.c all: add "libnm-core/nm-default-libnm-core.h" as replacement for "nm-default.h" 2021-02-09 12:38:18 +01:00
nm-setting-macvlan.h all: update deprecated SPDX license identifiers 2021-01-05 09:46:21 +01:00
nm-setting-match.c all: add "libnm-core/nm-default-libnm-core.h" as replacement for "nm-default.h" 2021-02-09 12:38:18 +01:00
nm-setting-match.h all: update deprecated SPDX license identifiers 2021-01-05 09:46:21 +01:00
nm-setting-olpc-mesh.c all: add "libnm-core/nm-default-libnm-core.h" as replacement for "nm-default.h" 2021-02-09 12:38:18 +01:00
nm-setting-olpc-mesh.h all: update deprecated SPDX license identifiers 2021-01-05 09:46:21 +01:00
nm-setting-ovs-bridge.c all: add "libnm-core/nm-default-libnm-core.h" as replacement for "nm-default.h" 2021-02-09 12:38:18 +01:00
nm-setting-ovs-bridge.h all: update deprecated SPDX license identifiers 2021-01-05 09:46:21 +01:00
nm-setting-ovs-dpdk.c all: add "libnm-core/nm-default-libnm-core.h" as replacement for "nm-default.h" 2021-02-09 12:38:18 +01:00
nm-setting-ovs-dpdk.h all: update deprecated SPDX license identifiers 2021-01-05 09:46:21 +01:00
nm-setting-ovs-external-ids.c all: add "libnm-core/nm-default-libnm-core.h" as replacement for "nm-default.h" 2021-02-09 12:38:18 +01:00
nm-setting-ovs-external-ids.h all: update deprecated SPDX license identifiers 2021-01-05 09:46:21 +01:00
nm-setting-ovs-interface.c all: add "libnm-core/nm-default-libnm-core.h" as replacement for "nm-default.h" 2021-02-09 12:38:18 +01:00
nm-setting-ovs-interface.h all: update deprecated SPDX license identifiers 2021-01-05 09:46:21 +01:00
nm-setting-ovs-patch.c all: add "libnm-core/nm-default-libnm-core.h" as replacement for "nm-default.h" 2021-02-09 12:38:18 +01:00
nm-setting-ovs-patch.h all: update deprecated SPDX license identifiers 2021-01-05 09:46:21 +01:00
nm-setting-ovs-port.c all: add "libnm-core/nm-default-libnm-core.h" as replacement for "nm-default.h" 2021-02-09 12:38:18 +01:00
nm-setting-ovs-port.h all: update deprecated SPDX license identifiers 2021-01-05 09:46:21 +01:00
nm-setting-ppp.c all: add "libnm-core/nm-default-libnm-core.h" as replacement for "nm-default.h" 2021-02-09 12:38:18 +01:00
nm-setting-ppp.h all: update deprecated SPDX license identifiers 2021-01-05 09:46:21 +01:00
nm-setting-pppoe.c all: add "libnm-core/nm-default-libnm-core.h" as replacement for "nm-default.h" 2021-02-09 12:38:18 +01:00
nm-setting-pppoe.h all: update deprecated SPDX license identifiers 2021-01-05 09:46:21 +01:00
nm-setting-private.h all: update deprecated SPDX license identifiers 2021-01-05 09:46:21 +01:00
nm-setting-proxy.c all: add "libnm-core/nm-default-libnm-core.h" as replacement for "nm-default.h" 2021-02-09 12:38:18 +01:00
nm-setting-proxy.h all: update deprecated SPDX license identifiers 2021-01-05 09:46:21 +01:00
nm-setting-serial.c all: add "libnm-core/nm-default-libnm-core.h" as replacement for "nm-default.h" 2021-02-09 12:38:18 +01:00
nm-setting-serial.h all: update deprecated SPDX license identifiers 2021-01-05 09:46:21 +01:00
nm-setting-sriov.c all: add "libnm-core/nm-default-libnm-core.h" as replacement for "nm-default.h" 2021-02-09 12:38:18 +01:00
nm-setting-sriov.h all: update deprecated SPDX license identifiers 2021-01-05 09:46:21 +01:00
nm-setting-tc-config.c all: add "libnm-core/nm-default-libnm-core.h" as replacement for "nm-default.h" 2021-02-09 12:38:18 +01:00
nm-setting-tc-config.h all: update deprecated SPDX license identifiers 2021-01-05 09:46:21 +01:00
nm-setting-team-port.c all: add "libnm-core/nm-default-libnm-core.h" as replacement for "nm-default.h" 2021-02-09 12:38:18 +01:00
nm-setting-team-port.h all: update deprecated SPDX license identifiers 2021-01-05 09:46:21 +01:00
nm-setting-team.c all: add "libnm-core/nm-default-libnm-core.h" as replacement for "nm-default.h" 2021-02-09 12:38:18 +01:00
nm-setting-team.h all: update deprecated SPDX license identifiers 2021-01-05 09:46:21 +01:00
nm-setting-tun.c all: add "libnm-core/nm-default-libnm-core.h" as replacement for "nm-default.h" 2021-02-09 12:38:18 +01:00
nm-setting-tun.h all: update deprecated SPDX license identifiers 2021-01-05 09:46:21 +01:00
nm-setting-user.c all: add "libnm-core/nm-default-libnm-core.h" as replacement for "nm-default.h" 2021-02-09 12:38:18 +01:00
nm-setting-user.h all: update deprecated SPDX license identifiers 2021-01-05 09:46:21 +01:00
nm-setting-veth.c all: add "libnm-core/nm-default-libnm-core.h" as replacement for "nm-default.h" 2021-02-09 12:38:18 +01:00
nm-setting-veth.h all: update deprecated SPDX license identifiers 2021-01-05 09:46:21 +01:00
nm-setting-vlan.c all: add "libnm-core/nm-default-libnm-core.h" as replacement for "nm-default.h" 2021-02-09 12:38:18 +01:00
nm-setting-vlan.h all: update deprecated SPDX license identifiers 2021-01-05 09:46:21 +01:00
nm-setting-vpn.c all: add "libnm-core/nm-default-libnm-core.h" as replacement for "nm-default.h" 2021-02-09 12:38:18 +01:00
nm-setting-vpn.h all: update deprecated SPDX license identifiers 2021-01-05 09:46:21 +01:00
nm-setting-vrf.c all: add "libnm-core/nm-default-libnm-core.h" as replacement for "nm-default.h" 2021-02-09 12:38:18 +01:00
nm-setting-vrf.h all: update deprecated SPDX license identifiers 2021-01-05 09:46:21 +01:00
nm-setting-vxlan.c all: add "libnm-core/nm-default-libnm-core.h" as replacement for "nm-default.h" 2021-02-09 12:38:18 +01:00
nm-setting-vxlan.h all: update deprecated SPDX license identifiers 2021-01-05 09:46:21 +01:00
nm-setting-wifi-p2p.c all: add "libnm-core/nm-default-libnm-core.h" as replacement for "nm-default.h" 2021-02-09 12:38:18 +01:00
nm-setting-wifi-p2p.h all: update deprecated SPDX license identifiers 2021-01-05 09:46:21 +01:00
nm-setting-wimax.c all: add "libnm-core/nm-default-libnm-core.h" as replacement for "nm-default.h" 2021-02-09 12:38:18 +01:00
nm-setting-wimax.h all: update deprecated SPDX license identifiers 2021-01-05 09:46:21 +01:00
nm-setting-wired.c all: add "libnm-core/nm-default-libnm-core.h" as replacement for "nm-default.h" 2021-02-09 12:38:18 +01:00
nm-setting-wired.h all: update deprecated SPDX license identifiers 2021-01-05 09:46:21 +01:00
nm-setting-wireguard.c all: add "libnm-core/nm-default-libnm-core.h" as replacement for "nm-default.h" 2021-02-09 12:38:18 +01:00
nm-setting-wireguard.h all: update deprecated SPDX license identifiers 2021-01-05 09:46:21 +01:00
nm-setting-wireless-security.c all: add "libnm-core/nm-default-libnm-core.h" as replacement for "nm-default.h" 2021-02-09 12:38:18 +01:00
nm-setting-wireless-security.h all: update deprecated SPDX license identifiers 2021-01-05 09:46:21 +01:00
nm-setting-wireless.c all: add "libnm-core/nm-default-libnm-core.h" as replacement for "nm-default.h" 2021-02-09 12:38:18 +01:00
nm-setting-wireless.h all: update deprecated SPDX license identifiers 2021-01-05 09:46:21 +01:00
nm-setting-wpan.c all: add "libnm-core/nm-default-libnm-core.h" as replacement for "nm-default.h" 2021-02-09 12:38:18 +01:00
nm-setting-wpan.h all: update deprecated SPDX license identifiers 2021-01-05 09:46:21 +01:00
nm-setting.c all: add "libnm-core/nm-default-libnm-core.h" as replacement for "nm-default.h" 2021-02-09 12:38:18 +01:00
nm-setting.h all: update deprecated SPDX license identifiers 2021-01-05 09:46:21 +01:00
nm-simple-connection.c all: add "libnm-core/nm-default-libnm-core.h" as replacement for "nm-default.h" 2021-02-09 12:38:18 +01:00
nm-simple-connection.h all: update deprecated SPDX license identifiers 2021-01-05 09:46:21 +01:00
nm-team-utils.c all: add "libnm-core/nm-default-libnm-core.h" as replacement for "nm-default.h" 2021-02-09 12:38:18 +01:00
nm-team-utils.h all: update deprecated SPDX license identifiers 2021-01-05 09:46:21 +01:00
nm-utils-private.h all: update deprecated SPDX license identifiers 2021-01-05 09:46:21 +01:00
nm-utils.c libnm: fix leak in nm_utils_tc_tfilter_from_str() 2021-06-04 21:29:21 +02:00
nm-utils.h all: update deprecated SPDX license identifiers 2021-01-05 09:46:21 +01:00
nm-version-macros.h.in libnm: move "nm-version-macros.h" from shared/ to libnm-core/ 2021-02-09 12:38:19 +01:00
nm-version.h all: update deprecated SPDX license identifiers 2021-01-05 09:46:21 +01:00
nm-vpn-dbus-interface.h libnm: fix NMVpnConnectionStateReason for glib-mkenums 2021-02-01 09:31:00 +01:00
nm-vpn-editor-plugin.c all: add "libnm-core/nm-default-libnm-core.h" as replacement for "nm-default.h" 2021-02-09 12:38:18 +01:00
nm-vpn-editor-plugin.h all: update deprecated SPDX license identifiers 2021-01-05 09:46:21 +01:00
nm-vpn-plugin-info.c all: add "libnm-core/nm-default-libnm-core.h" as replacement for "nm-default.h" 2021-02-09 12:38:18 +01:00
nm-vpn-plugin-info.h all: update deprecated SPDX license identifiers 2021-01-05 09:46:21 +01:00