mirror of
https://gitlab.freedesktop.org/NetworkManager/NetworkManager.git
synced 2026-06-08 02:18:39 +02:00
I don't think we should do this.
- renamining/dropping configure options is still an annoyance,
because it requires to different ./configure options depending
on the version. The rename from --enable-teamctl to --enable-team
might be theoretically nice, but more annoying then helpful.
- There is no strict dependency between --enable-team and
--enable-json-validation. At most, one could argue that
when enabling the team plugin (--enable-teamctl), then
libnm must also be build with --enable-json-validation.
But in fact, the team plugin will happily work with a
libnm that doesn't link against libjansson.
That is --enable-teamctl --disable-json-validation will work
in practice just fine.
On the other hand, libnm is a client library to create connection
profiles, fully supporting team profiles also makes sense if the
actual plugin is not installed (or build). Thus, --disable-teamctl
--enable-json-validation certainly makes sense.
At this point, one might ask whether libnm is even still complete without
libjansson. Maybe libnm should *require* --enable-json-validation.
But that is not what the patch was doing, and it would also need
some careful consideration before doing so.
This reverts commit
|
||
|---|---|---|
| .. | ||
| .gitignore | ||
| 00-server.conf | ||
| 20-connectivity-fedora.conf | ||
| build.sh | ||
| build_clean.sh | ||
| mockbuild.sh | ||
| NetworkManager.conf | ||
| NetworkManager.spec | ||
| README | ||
# To build RPM packages for Fedora derivates directly from git, just do: # # preparation: # git clone git://anongit.freedesktop.org/NetworkManager/NetworkManager cd NetworkManager git checkout $WHATEVER sudo sh ./contrib/fedora/REQUIRED_PACKAGES # # build the packages. Pass --help for usage help. # ./contrib/fedora/rpm/build_clean.sh # # install # sudo dnf install ./contrib/fedora/rpm/latest/RPMS/x86_64/*rpm # To generate a clean build from git using mock, run: ./contrib/fedora/rpm/mockbuild.sh