mirror of
https://gitlab.freedesktop.org/NetworkManager/NetworkManager.git
synced 2026-01-03 08:10:17 +01:00
b28c6ca30e
Clang 15 ([1], [2]) added
Added the -Wunreachable-code-generic-assoc diagnostic flag (grouped
under the -Wunreachable-code flag) which is enabled by default and warns
the user about _Generic selection associations which are unreachable
because the type specified is an array type or a qualified type.
This causes compiler warnings with various uses of _Generic():
../src/libnm-glib-aux/nm-shared-utils.h:2489:12: error: due to lvalue conversion of the controlling expression, association of type 'const char *const *const' will never be selected becaus
e it is qualified [-Werror,-Wunreachable-code-generic-assoc]
return nm_strv_find_first((const char *const *) strv->pdata, strv->len, str);
^
../src/libnm-glib-aux/nm-shared-utils.h:475:25: note: expanded from macro 'nm_strv_find_first'
_nm_strv_find_first(NM_CAST_STRV_CC(list), (len), (needle))
^
../src/libnm-glib-aux/nm-macros-internal.h:397:22: note: expanded from macro 'NM_CAST_STRV_CC'
const char *const*const: (const char *const*) (value), \
^
Clang is correct.
[1] https://releases.llvm.org/15.0.0/tools/clang/docs/ReleaseNotes.html#improvements-to-clang-s-diagnostics
[2] https://reviews.llvm.org/D125259
47 lines
2.6 KiB
C
47 lines
2.6 KiB
C
/* SPDX-License-Identifier: GPL-2.0-or-later */
|
|
/*
|
|
* Copyright (C) 2014 Red Hat, Inc.
|
|
*/
|
|
|
|
#ifndef __NETWORKMANAGER_DEVICE_LOGGING_H__
|
|
#define __NETWORKMANAGER_DEVICE_LOGGING_H__
|
|
|
|
#include "nm-device.h"
|
|
|
|
#if !_NM_CC_SUPPORT_GENERIC
|
|
#define _NM_DEVICE_CAST(self) ((NMDevice *) (self))
|
|
#elif !defined(_NMLOG_DEVICE_TYPE)
|
|
#define _NM_DEVICE_CAST(self) _Generic((self), NMDevice * : ((NMDevice *) (self)))
|
|
#else
|
|
#define _NM_DEVICE_CAST(self) \
|
|
_Generic((self), _NMLOG_DEVICE_TYPE * \
|
|
: ((NMDevice *) (self)), NMDevice * \
|
|
: ((NMDevice *) (self)))
|
|
#endif
|
|
|
|
#undef _NMLOG_ENABLED
|
|
#define _NMLOG_ENABLED(level, domain) (nm_logging_enabled((level), (domain)))
|
|
#define _NMLOG(level, domain, ...) \
|
|
G_STMT_START \
|
|
{ \
|
|
const NMLogLevel _level = (level); \
|
|
const NMLogDomain _domain = (domain); \
|
|
\
|
|
if (nm_logging_enabled(_level, _domain)) { \
|
|
typeof(*self) *const _self = (self); \
|
|
const char *const _ifname = _nm_device_get_iface(_NM_DEVICE_CAST(_self)); \
|
|
\
|
|
nm_log_obj(_level, \
|
|
_domain, \
|
|
_ifname, \
|
|
NULL, \
|
|
_self, \
|
|
"device", \
|
|
"%s%s%s: " _NM_UTILS_MACRO_FIRST(__VA_ARGS__), \
|
|
NM_PRINT_FMT_QUOTED(_ifname, "(", _ifname, ")", "[null]") \
|
|
_NM_UTILS_MACRO_REST(__VA_ARGS__)); \
|
|
} \
|
|
} \
|
|
G_STMT_END
|
|
|
|
#endif /* __NETWORKMANAGER_DEVICE_LOGGING_H__ */
|