NetworkManager/src
Beniamino Galvani 00525ff9be dhcp: remove l3cds when the lease expires
When the lease is lost, NM tries to get a new by restarting the DHCP
transaction. However, it doesn't delete the existing l3cds (one from
the DHCP client with flag ONLY_FOR_ACD, the other from
NMDevice). Therefore, the l3cfg still tracks the ACD state of the
address as "external-removed", and when NM gets the same address via
DHCP, ACD is considered as failed; as a consequence, NM sends a
DECLINE message to the server.

Moreover, the l3cd added by NMDevice for DHCP has a zero ACD timeout,
and so it's not possible to do ACD again on the same address.

Remove those l3cds when the lease expires, so that any ACD state is
cleared and DHCP can perform ACD again.

Fixes: 240ec7f891 ('dhcp: implement ACD (address collision detection) for DHCPv4')

https://gitlab.freedesktop.org/NetworkManager/NetworkManager/-/merge_requests/1853
(cherry picked from commit a80fef9f37)
(cherry picked from commit fe734c5c11)
2024-03-14 09:03:13 +01:00
..
c-list c-list: re-import git-subtree for 'src/c-list' 2022-07-19 09:02:36 +02:00
c-rbtree c-rbtree: re-import git-subtree for 'src/c-rbtree' 2022-11-23 18:00:31 +01:00
c-siphash c-siphash: re-import git-subtree for 'src/c-siphash' 2022-11-23 18:00:33 +01:00
c-stdaux c-stdaux: re-import git-subtree for 'src/c-stdaux' 2023-03-03 13:40:38 +01:00
contrib all: adjust glib-mkenums annotations for automated formatting 2022-02-08 11:14:01 +01:00
core dhcp: remove l3cds when the lease expires 2024-03-14 09:03:13 +01:00
libnm-base build,core: add a "main.migrate-ifcfg-rh" configuration option 2023-07-25 15:39:06 +02:00
libnm-client-aux-extern all: use nm_random_*() instead of g_random_*() 2023-01-30 10:51:13 +01:00
libnm-client-impl libnm: mark missing "FwMark" for NMDeviceIPTunnel as ignored 2024-03-14 08:52:40 +01:00
libnm-client-public libnm: sort setting headers in NetworkManager.h 2023-06-29 10:15:48 +02:00
libnm-client-test all: use G_SPAWN_CLOEXEC_PIPES with g_spawn_async_with_pipes() 2023-04-04 08:43:20 +02:00
libnm-core-aux-extern dispatch dns-change dispatcher event 2023-10-18 14:24:34 +08:00
libnm-core-aux-intern libnm-core: add internal _nm_ip_route_ref() helper 2023-05-12 12:42:49 +02:00
libnm-core-impl libnm-core: fix mac comparison in _remove_mac_blacklist_item_by_value 2024-03-14 09:02:56 +01:00
libnm-core-intern libnm: use nm_net_devname_infiniband() for virtual interface-name of infiniband 2023-05-30 08:52:34 +02:00
libnm-core-public build/meson: fix gtkdoc dependencies 2024-03-14 08:52:27 +01:00
libnm-crypto doc: replace all (allow-none) annotations by (optional) and/or (nullable) 2023-03-27 11:49:43 +02:00
libnm-glib-aux glib-aux: fix atomic pattern in nm_ref_string_unref() 2024-03-14 09:02:43 +01:00
libnm-lldp glib-aux/prioq: assert for valid index in find_item() of NMPrioq 2023-03-21 15:58:39 +01:00
libnm-log-core log,dhcp: avoid deprecated GTimeVal API and use g_get_real_time() 2023-03-21 10:21:28 +01:00
libnm-log-null all: add some README.md files describing the purpose of our sources 2021-08-19 17:51:11 +02:00
libnm-platform platform: fix handling "weight" for IPv4 routes 2024-03-14 09:00:58 +01:00
libnm-std-aux std-aux: add NM_IFNAMSIZE 2023-05-30 08:51:10 +02:00
libnm-systemd-core systemd: merge branch systemd into main 2023-06-27 09:01:36 -04:00
libnm-systemd-shared systemd/README: improve readme 2023-06-27 19:00:38 +02:00
libnm-udev-aux format: reformat source tree with clang-format 13.0 2021-11-29 09:31:09 +00:00
libnmc-base libnmc-base/utils: Improve qr code bottom border 2023-10-03 14:53:25 +02:00
libnmc-setting libnm: better document IPv4 DAD property 2023-11-21 09:11:56 +01:00
libnmt-newt doc: use "Returns:" annotation instead of deprecated aliases 2023-03-29 11:46:48 +02:00
linux-headers all: add src/nm-compat-headers for patching included system headers 2022-09-23 11:43:33 +02:00
n-acd n-acd: use separate seed state for each probe of the same acd 2023-11-21 09:10:58 +01:00
n-dhcp4 n-dhcp4: re-import git-subtree for 'src/n-dhcp4' 2023-06-12 14:10:08 +02:00
nm-cloud-setup cloud-setup: log a warning when no provider is detected 2023-06-14 16:24:21 +02:00
nm-compat-headers all: add src/nm-compat-headers for patching included system headers 2022-09-23 11:43:33 +02:00
nm-daemon-helper nm-daemon-helper: log to stderr any error from getaddrinfo() 2023-02-21 13:46:55 +01:00
nm-dispatcher dispatch dns-change dispatcher event 2023-10-18 14:24:34 +08:00
nm-initrd-generator initrd: unset dhcp options for static profiles 2023-07-24 11:17:27 +02:00
nm-online clang-format: reformat code with clang-format 15.0.4-1.fc37 2022-11-23 09:17:21 +01:00
nm-priv-helper all: drop redundant includes 2022-05-09 19:20:18 +02:00
nmcli nmcli: don't warn version mismatch with daemon not running 2023-11-21 09:37:18 +01:00
nmtui nmtui: replace occurrences of master/slave with controller/port in internal code 2023-07-25 14:22:25 +02:00
tests test-client: fix warnings about invalid escape sequences 2023-11-21 09:38:23 +01:00
meson.build Squashed 'src/n-dhcp4/' changes from f8fc48dc014d..b2a382ac4500 2023-05-09 08:53:48 +02:00
README.md nm-sudo: rename to nm-priv-helper 2022-01-11 21:46:55 +01:00

src/

Most of the subdirectories are static helper libraries, which get linked into one of the final build artifacts (like libnm, nmcli or NetworkManager). Static libraries are internal API.

The only public API is libnm, which is a shared library provided client implementations.

Our own clients (like nmcli and nmtui) also use libnm, the shared library. But they also use additional static helper libraries.

The daemon statically links against a part of libnm, the part that provides connection profiles. That is libnm-core. libnm-core is thus statically linked with libnm and the daemon. It does not get linked by clients that already link with libnm (like nmtui).

Read the individual README.md files in the subdirectories for details:

Directory Description
core/ the NetworkManager daemon
nmcli/ nmcli application, a command line client for NetworkManager
nmtui/ nmtui application, a text UI client for NetworkManager
nm-cloud-setup/ service to automatically configure NetworkManager in cloud environment
nm-initrd-generator/ generates NetworkManager configuration by parsing kernel command line options for dracut/initrd
nm-dispatcher/ NetworkManager-dispatcher service to run user scripts
nm-online/ application which checks whether NetworkManager is done, for implementing NetworkManager-wait-online.service
nm-priv-helper/ internal service for privileged operations
nm-daemon-helper/ internal helper binary spawned by NetworkManager
libnm-std-aux/ internal helper library for standard C
libnm-glib-aux/ internal helper library for glib
libnm-log-null/ internal helper library with dummy (null) logging backend
libnm-log-core/ internal helper library with logging backend (syslog) used by daemon
libnm-base/ internal helper library with base definitions
libnm-platform/ internal helper library for netlink and other platform/kernel API
libnm-udev-aux/ internal helper library for libudev
libnm-core-public/ public API of libnm (libnm-core part)
libnm-core-intern/ internal API of libnm-core, used by libnm and daemon
libnm-core-impl/ implementation of libnm-core
libnm-core-aux-intern/ internal helper library on top of libnm-core (used by libnm-core itself)
libnm-core-aux-extern/ internal helper library on top of libnm-core (not used by libnm-core)
libnm-client-public/ public API of libnm (NMClient part)
libnm-client-impl/ implementation of libnm (NMClient)
libnm-client-aux-extern/ internal helper library on top of libnm (not used by libnm itself)
libnmc-base/ internal helper library for libnm clients
libnmc-setting/ internal helper library for setting connection profiles (used by nmcli)
libnmt-newt/ internal helper library for libnewt for nmtui
linux-headers/ extra Linux kernel UAPI headers
contrib/ sources that are not used by NetworkManager itself
tests/ unit tests that are not specific to one of the other directories
libnm-client-test/ internal helper library with test utils for libnm
c-list/ fork of c-util helper library for intrusive, doubly linked list
c-rbtree/ fork of c-util helper library for intrusive Red-Black Tree
c-siphash/ fork of c-util helper library for SIPHash24
c-stdaux/ fork of c-util general purpose helpers for standard C
n-acd/ fork of nettools IPv4 ACD library
n-dhcp4/ fork of nettools DHCPv4 library
libnm-systemd-core/ fork of systemd code as network library
libnm-systemd-shared/ fork of systemd code as general purpose library