mirror of
https://gitlab.freedesktop.org/NetworkManager/NetworkManager.git
synced 2026-05-07 13:08:10 +02:00
We use clang-format for automatic formatting of our source files. Since clang-format is actively maintained software, the actual formatting depends on the used version of clang-format. That is unfortunate and painful, but really unavoidable unless clang-format would be strictly bug-compatible. So the version that we must use is from the current Fedora release, which is also tested by our gitlab-ci. Previously, we were using Fedora 34 with clang-tools-extra-12.0.1-1.fc34.x86_64. As Fedora 35 comes along, we need to update our formatting as Fedora 35 comes with version "13.0.0~rc1-1.fc35". An alternative would be to freeze on version 12, but that has different problems (like, it's cumbersome to rebuild clang 12 on Fedora 35 and it would be cumbersome for our developers which are on Fedora 35 to use a clang that they cannot easily install). The (differently painful) solution is to reformat from time to time, as we switch to a new Fedora (and thus clang) version. Usually we would expect that such a reformatting brings minor changes. But this time, the changes are huge. That is mentioned in the release notes [1] as Makes PointerAligment: Right working with AlignConsecutiveDeclarations. (Fixes https://llvm.org/PR27353) [1] https://releases.llvm.org/13.0.0/tools/clang/docs/ReleaseNotes.html#clang-format
200 lines
7.2 KiB
C
200 lines
7.2 KiB
C
/* SPDX-License-Identifier: GPL-2.0-or-later */
|
|
/*
|
|
* Copyright (C) 2016 Red Hat, Inc.
|
|
*/
|
|
/**
|
|
* SECTION:nmt-page-ip_tunnel
|
|
* @short_description: The editor page for IP tunnel connections
|
|
*/
|
|
|
|
#include "libnm-client-aux-extern/nm-default-client.h"
|
|
|
|
#include "nmt-page-ip-tunnel.h"
|
|
|
|
#include "libnm-core-aux-intern/nm-libnm-core-utils.h"
|
|
#include "nmt-device-entry.h"
|
|
#include "nmt-mtu-entry.h"
|
|
|
|
G_DEFINE_TYPE(NmtPageIPTunnel, nmt_page_ip_tunnel, NMT_TYPE_EDITOR_PAGE_DEVICE)
|
|
|
|
#define NMT_PAGE_IP_TUNNEL_GET_PRIVATE(o) \
|
|
(G_TYPE_INSTANCE_GET_PRIVATE((o), NMT_TYPE_PAGE_IP_TUNNEL, NmtPageIPTunnelPrivate))
|
|
|
|
typedef struct {
|
|
NmtNewtEntry *input_key;
|
|
NmtNewtEntry *output_key;
|
|
} NmtPageIPTunnelPrivate;
|
|
|
|
NmtEditorPage *
|
|
nmt_page_ip_tunnel_new(NMConnection *conn, NmtDeviceEntry *deventry)
|
|
{
|
|
return g_object_new(NMT_TYPE_PAGE_IP_TUNNEL,
|
|
"connection",
|
|
conn,
|
|
"device-entry",
|
|
deventry,
|
|
NULL);
|
|
}
|
|
|
|
static void
|
|
nmt_page_ip_tunnel_init(NmtPageIPTunnel *ip_tunnel)
|
|
{}
|
|
|
|
static void
|
|
mode_changed(GObject *object, GParamSpec *pspec, gpointer user_data)
|
|
{
|
|
NMSettingIPTunnel *s_ip_tunnel = NM_SETTING_IP_TUNNEL(object);
|
|
NmtPageIPTunnel *ip_tunnel = NMT_PAGE_IP_TUNNEL(user_data);
|
|
NmtPageIPTunnelPrivate *priv = NMT_PAGE_IP_TUNNEL_GET_PRIVATE(ip_tunnel);
|
|
NMIPTunnelMode mode;
|
|
gboolean enable_keys;
|
|
|
|
mode = nm_setting_ip_tunnel_get_mode(s_ip_tunnel);
|
|
enable_keys = NM_IN_SET(mode, NM_IP_TUNNEL_MODE_GRE, NM_IP_TUNNEL_MODE_IP6GRE);
|
|
nmt_newt_widget_set_visible(NMT_NEWT_WIDGET(priv->input_key), enable_keys);
|
|
nmt_newt_widget_set_visible(NMT_NEWT_WIDGET(priv->output_key), enable_keys);
|
|
|
|
if (!enable_keys) {
|
|
nmt_newt_entry_set_text(priv->input_key, "");
|
|
nmt_newt_entry_set_text(priv->output_key, "");
|
|
}
|
|
}
|
|
|
|
static NmtNewtPopupEntry tunnel_mode[] = {
|
|
/* The order must match the NM_IP_TUNNEL_MODE_* enum */
|
|
{N_("IPIP"), "IPIP"},
|
|
{N_("GRE"), "GRE"},
|
|
{N_("SIT"), "SIT"},
|
|
{N_("ISATAP"), "ISATAP"},
|
|
{N_("VTI"), "VTI"},
|
|
{N_("IP6IP6"), "IP6IP6"},
|
|
{N_("IPIP6"), "IPIP6"},
|
|
{N_("IP6GRE"), "IP6GRE"},
|
|
{N_("VTI6"), "VTI6"},
|
|
{NULL, NULL}};
|
|
|
|
static gboolean
|
|
add_offset(GBinding *binding, const GValue *from_value, GValue *to_value, gpointer user_data)
|
|
{
|
|
guint v;
|
|
int offset = GPOINTER_TO_INT(user_data);
|
|
|
|
g_return_val_if_fail(G_VALUE_HOLDS(from_value, G_TYPE_UINT), FALSE);
|
|
g_return_val_if_fail(G_VALUE_HOLDS(to_value, G_TYPE_UINT), FALSE);
|
|
|
|
v = g_value_get_uint(from_value);
|
|
v += offset;
|
|
|
|
g_value_set_uint(to_value, v);
|
|
|
|
return TRUE;
|
|
}
|
|
|
|
static void
|
|
nmt_page_ip_tunnel_constructed(GObject *object)
|
|
{
|
|
NmtPageIPTunnel *ip_tunnel = NMT_PAGE_IP_TUNNEL(object);
|
|
NmtPageIPTunnelPrivate *priv = NMT_PAGE_IP_TUNNEL_GET_PRIVATE(ip_tunnel);
|
|
NmtEditorSection *section;
|
|
NmtEditorGrid *grid;
|
|
NMSettingIPTunnel *s_ip_tunnel;
|
|
NmtNewtWidget *widget, *parent;
|
|
NMConnection *conn;
|
|
GClosure *s2w, *w2s;
|
|
|
|
conn = nmt_editor_page_get_connection(NMT_EDITOR_PAGE(ip_tunnel));
|
|
s_ip_tunnel = _nm_connection_ensure_setting(conn, NM_TYPE_SETTING_IP_TUNNEL);
|
|
|
|
/* Initialize the mode for new connections */
|
|
if (nm_setting_ip_tunnel_get_mode(s_ip_tunnel) == NM_IP_TUNNEL_MODE_UNKNOWN) {
|
|
g_object_set(s_ip_tunnel, NM_SETTING_IP_TUNNEL_MODE, (guint) NM_IP_TUNNEL_MODE_IPIP, NULL);
|
|
}
|
|
|
|
section = nmt_editor_section_new(_("IP tunnel"), NULL, TRUE);
|
|
grid = nmt_editor_section_get_body(section);
|
|
|
|
/* To convert between widget index (0-based) and setting index (1-based) */
|
|
s2w = g_cclosure_new(G_CALLBACK(add_offset), GINT_TO_POINTER(-1), NULL);
|
|
w2s = g_cclosure_new(G_CALLBACK(add_offset), GINT_TO_POINTER(1), NULL);
|
|
|
|
widget = nmt_newt_popup_new(tunnel_mode);
|
|
g_object_bind_property_with_closures(s_ip_tunnel,
|
|
NM_SETTING_IP_TUNNEL_MODE,
|
|
widget,
|
|
"active",
|
|
G_BINDING_BIDIRECTIONAL | G_BINDING_SYNC_CREATE,
|
|
s2w,
|
|
w2s);
|
|
nmt_editor_grid_append(grid, _("Mode"), widget, NULL);
|
|
|
|
widget = parent = nmt_device_entry_new(_("Parent"), 40, G_TYPE_NONE);
|
|
g_object_bind_property(s_ip_tunnel,
|
|
NM_SETTING_IP_TUNNEL_PARENT,
|
|
widget,
|
|
"interface-name",
|
|
G_BINDING_BIDIRECTIONAL | G_BINDING_SYNC_CREATE);
|
|
nmt_editor_grid_append(grid, NULL, widget, NULL);
|
|
|
|
widget = nmt_newt_entry_new(40, 0);
|
|
nmt_editor_grid_append(grid, _("Local IP"), widget, NULL);
|
|
g_object_bind_property(s_ip_tunnel,
|
|
NM_SETTING_IP_TUNNEL_LOCAL,
|
|
widget,
|
|
"text",
|
|
G_BINDING_SYNC_CREATE | G_BINDING_BIDIRECTIONAL);
|
|
|
|
widget = nmt_newt_entry_new(40, 0);
|
|
nmt_editor_grid_append(grid, _("Remote IP"), widget, NULL);
|
|
g_object_bind_property(s_ip_tunnel,
|
|
NM_SETTING_IP_TUNNEL_REMOTE,
|
|
widget,
|
|
"text",
|
|
G_BINDING_SYNC_CREATE | G_BINDING_BIDIRECTIONAL);
|
|
|
|
widget = nmt_newt_entry_new(40, 0);
|
|
nmt_editor_grid_append(grid, _("Input key"), widget, NULL);
|
|
g_object_bind_property(s_ip_tunnel,
|
|
NM_SETTING_IP_TUNNEL_INPUT_KEY,
|
|
widget,
|
|
"text",
|
|
G_BINDING_SYNC_CREATE | G_BINDING_BIDIRECTIONAL);
|
|
priv->input_key = NMT_NEWT_ENTRY(widget);
|
|
|
|
widget = nmt_newt_entry_new(40, 0);
|
|
nmt_editor_grid_append(grid, _("Output key"), widget, NULL);
|
|
g_object_bind_property(s_ip_tunnel,
|
|
NM_SETTING_IP_TUNNEL_OUTPUT_KEY,
|
|
widget,
|
|
"text",
|
|
G_BINDING_SYNC_CREATE | G_BINDING_BIDIRECTIONAL);
|
|
priv->output_key = NMT_NEWT_ENTRY(widget);
|
|
|
|
widget = nmt_mtu_entry_new();
|
|
g_object_bind_property(s_ip_tunnel,
|
|
NM_SETTING_IP_TUNNEL_MTU,
|
|
widget,
|
|
"mtu",
|
|
G_BINDING_BIDIRECTIONAL | G_BINDING_SYNC_CREATE);
|
|
nmt_editor_grid_append(grid, _("MTU"), widget, NULL);
|
|
|
|
g_signal_connect(s_ip_tunnel,
|
|
"notify::" NM_SETTING_IP_TUNNEL_MODE,
|
|
G_CALLBACK(mode_changed),
|
|
ip_tunnel);
|
|
mode_changed(G_OBJECT(s_ip_tunnel), NULL, ip_tunnel);
|
|
|
|
nmt_editor_page_add_section(NMT_EDITOR_PAGE(ip_tunnel), section);
|
|
|
|
G_OBJECT_CLASS(nmt_page_ip_tunnel_parent_class)->constructed(object);
|
|
}
|
|
|
|
static void
|
|
nmt_page_ip_tunnel_class_init(NmtPageIPTunnelClass *ip_tunnel_class)
|
|
{
|
|
GObjectClass *object_class = G_OBJECT_CLASS(ip_tunnel_class);
|
|
|
|
g_type_class_add_private(ip_tunnel_class, sizeof(NmtPageIPTunnelPrivate));
|
|
|
|
/* virtual methods */
|
|
object_class->constructed = nmt_page_ip_tunnel_constructed;
|
|
}
|