Dan Williams
58088129f7
settings: only use one hint nm_sysconfig_connection_get_secrets()
...
Never used more than one anyway.
2010-12-12 21:29:13 -06:00
Dan Williams
ff101f4946
settings: remove callback from nm_sysconfig_connection_get_secrets()
...
No reason it needs to use the callback pattern anymore.
2010-12-12 21:17:34 -06:00
Dan Williams
cf7cc2492d
logging: LOGD_SYS_SET -> LOGD_SETTINGS
2010-12-10 12:32:22 -06:00
Dan Williams
9d077444a9
settings: remove settings dict from connection 'updated' signal
...
New connections should not be pushed out in the Updated signal
because signals cannot be restricted to particular clients, and
some clients may not have permission to view the connection.
Upon receiving the Updated signal, clients should re-read the
connection using GetSettings to ensure that the client still
has permissions to view the connection, and to get the updated
settings.
2010-12-02 14:34:38 -06:00
Dan Williams
042468a86e
settings: convert more hand-rolled polkit to NMAuthChain
2010-11-18 14:24:58 -06:00
Dan Williams
858fc2c4b8
trivial: remove incorrect comment
2010-11-18 14:21:21 -06:00
Dan Williams
c11ba3ea10
settings: GHashTable isn't a GObject subclass
2010-11-18 14:05:57 -06:00
Dan Williams
a53c31427d
settings: make use of nm_auth_uid_in_acl()
2010-11-18 14:05:33 -06:00
Dan Williams
eccca738aa
core: make nm_auth_get_caller_uid() error description non-const
...
For consistency with the next commit, so we don't need to remember
when to free the description or not.
2010-11-18 13:47:04 -06:00
Dan Williams
c3c9d93b1d
settings: fix session checking for connection operations
2010-11-18 13:04:15 -06:00
Dan Williams
ac2438518d
settings: don't allow addition of invisible connections
...
Ensure that only connections which are visible to the user adding
the connection may be added.
2010-11-18 12:53:24 -06:00
Dan Williams
fe3002d9f1
settings: fix permission checking during add
2010-11-18 12:40:38 -06:00
Dan Williams
9db44c42ee
settings: remove unused variables
2010-11-18 10:55:21 -06:00
Dan Williams
ca063e4d0c
libnm-util: add nm_setting_connection_permissions_has_user()
...
Utility function to determine whether a given username is in the ACL.
2010-11-18 10:36:18 -06:00
Dan Williams
c0f5872b5a
settings: don't accept possible auth as success for saving hostname
...
Since user interaction is allowed when the permission for SaveHostname
is requested, if the user didn't authorize completely when polkit
returns, we don't want to proceed with the request. Otherwise we might
get into a situation where it's possible for the user to authorize,
but they didn't, and previously the code would allow the request.
2010-11-17 17:54:04 -06:00
Dan Williams
1bbc624477
settings: port AddConnection to NMAuthChain
...
More code saved. Yay.
2010-11-17 17:53:37 -06:00
Dan Williams
670da10764
settings: port SaveHostname to NMAuthChain
...
Every line of code we remove can then be spent on
rainbows and kittens.
2010-11-17 17:44:33 -06:00
Dan Williams
02d942320d
core: fix nm_settings_get_connections() result confusion
...
It used to reference items in the list, but no longer does because
that's stupid. Fixes some merge damage and a leak.
2010-11-17 17:42:22 -06:00
Dan Williams
3de9332f09
trivial: be a bit more paranoid about re-exporting connections
2010-11-17 17:33:00 -06:00
Dan Williams
453ea4d5c7
settings: make sure we use a clear error every time
2010-10-29 23:13:57 -05:00
Dan Williams
85db10a13f
settings: fix connection addition
...
Need to make sure we actually export the connection over D-Bus (via
claim_connection()) before we try to return its object path in the
AddConnection reply. Second, we need to send the path as a string
in the reply, not an object, since the return type is an object path.
2010-10-29 22:10:32 -05:00
Dan Williams
9d725be3a9
settings: fix signature of connection updated handler
2010-10-29 22:05:23 -05:00
Dan Williams
37845af954
settings: return new connection object path from AddConnection
...
Finally.
2010-10-29 14:34:33 -05:00
Dan Williams
3f64bf5e36
settings: rename NM_SYSCONFIG_SETTINGS_ERROR -> NM_SETTINGS_ERROR
2010-10-27 20:38:26 -05:00
Dan Williams
83ab4ec2ee
settings: system-settings -> settings
2010-10-27 20:22:14 -05:00
