* gnome/vpn-properties/nm-vpn-properties.c: Implemented the add
dialog in code as is done for the edit dialog and tidied up the
management of the plugin provided widgets. Show all and hide
all are no longer used as they would override the visiblity
behaviour imposed by the plugin. (gnome.org bug #349991).
* gnome/vpn-properties/nm-vpn-properties.glade: Removed add dialog
widgets that are nolonger needed.
git-svn-id: http://svn-archive.gnome.org/svn/NetworkManager/trunk@1947 4912f4e0-d625-0410-9fb7-b9a5a253dbdc
* gnome/applet/applet-dbus-devices.c
gnome/applet/applet-dbus-vpn.c
gnome/applet/applet-dbus.c
gnome/applet/applet-dbus.h
src/nm-dbus-nmi.c
utils/nm-utils.c
utils/nm-utils.h
- Make pending call tracking code generic,
so we can use it in NM as well as the applet
git-svn-id: http://svn-archive.gnome.org/svn/NetworkManager/trunk@1940 4912f4e0-d625-0410-9fb7-b9a5a253dbdc
* gnome/applet/nm-gconf-wso-wpa-eap.c: Don't set the Gconf keys unless
we have a value to set. Gconf generates a warning if `val' is NULL.
* src/nm-ap-security-wpa-eap.c: Don't set the key for an Enterprise AP
unless we actually received a valid private key file passphrase or
password. Otherwise, we don't know to later ask the applet to pull
the key from the keyring.
git-svn-id: http://svn-archive.gnome.org/svn/NetworkManager/trunk@1845 4912f4e0-d625-0410-9fb7-b9a5a253dbdc
* gnome/applet/nm-gconf-wso-wpa-eap.c: Don't set the set unless there
is a non-empty key to set. Elsewhere, pass an empty string via DBUS
if there is no key to pass.
git-svn-id: http://svn-archive.gnome.org/svn/NetworkManager/trunk@1833 4912f4e0-d625-0410-9fb7-b9a5a253dbdc
* gnome/applet/applet-dbus-info.c: Don't set the fallback bit to FALSE
if it is currently set to TRUE. Otherwise, we will reset the value
when we connect normally.
* src/nm-device-802-11-wireless.c: For the roaming code, make sure that
the old BSSID is valid, too. The recently added ESSID check may not be
sufficient (we can remove it?). What we really want to catch is the
case of going from all-zeros to the BSSID of some other network, which
happens on failure.
git-svn-id: http://svn-archive.gnome.org/svn/NetworkManager/trunk@1823 4912f4e0-d625-0410-9fb7-b9a5a253dbdc
Add 'fallback' support. NetworkManager will attempt to brute-force
connect to networks marked as fallback if there are no better wireless
connections available. This is useful as a method of last resort, to
work around driver problems, and for use with hidden networks.
* gnome/applet/applet-dbus-devices.c,
gnome/applet/applet-dbus-devices.h: Add fallback parameter.
* gnome/applet/applet-dbus-info.c: Retrieve fallback bit from Gconf and
pass it on via DBUS.
* gnome/applet/applet.c: No fallback by default.
* gnome/applet/applet.glade, gnome/applet/other-network-dialog.c:
Update other-network-dialog to add UI checkbox toggling fallback.
* src/NetworkManagerAP.c, src/NetworkManagerAP.h: Remove "trusted"
propery from AP object. Add "fallback" property to AP object.
* src/nm-dbus-nm.c: Grab the fallback parameter via DBUS.
* src/nm-dbus-nmi.c: Grab the fallback parameter via DBUS.
* src/nm-device-802-11-wireless.c: Break out blacklist logic into
separate function. Add get_best_fallback_ap() for returning an AP
on which to attempt fallback.
* src/backends/NetworkManagerSuSE.c: Set stored network as fallback.
* test/nm-set-fallback: New file. Sets a given network as fallback.
git-svn-id: http://svn-archive.gnome.org/svn/NetworkManager/trunk@1814 4912f4e0-d625-0410-9fb7-b9a5a253dbdc
* gnome/applet/gconf-helpers.c: Bug fix: nm_gconf_helper_get_bool()
checked that the return type was GCONF_VALUE_STRING, not the correct
GCONF_VALUE_BOOL, and thus it never worked.
* src/NetworkManagerAPList.c: Before concluding that two networks are
identical based on their BSSID, make sure that the BSSID in question
is actually valid. Specifically, an empty or all zero BSSID does not
cut it.
* gnome/applet/applet-dbus-info.c, gnome/applet/other-network-dialog.c,
src/nm-dbus-nmi.c, src/nm-device-802-11-wireless.c: White space and
similar invariant clean up.
git-svn-id: http://svn-archive.gnome.org/svn/NetworkManager/trunk@1811 4912f4e0-d625-0410-9fb7-b9a5a253dbdc
* gnome/vpn-properties/nm-vpn-properties.c
- (find_vpn_ui_by_service_name): protect against NULL service names
- (update_edit_del_sensitivity): protect against NULL service names
git-svn-id: http://svn-archive.gnome.org/svn/NetworkManager/trunk@1777 4912f4e0-d625-0410-9fb7-b9a5a253dbdc
Patch Valentine Sinitsyn <e_val@inbox.ru> to fix GNOME bug #342398:
* configure.in, gnome/Makefile.am, Makefile.am: Add "--without-gnome"
configure flag to disable building of the GNOME-based applet.
git-svn-id: http://svn-archive.gnome.org/svn/NetworkManager/trunk@1765 4912f4e0-d625-0410-9fb7-b9a5a253dbdc
* gnome/applet/nm-device.c, gnome/applet/nm-device.h: Rename function
parameter from link, because it shadows a global variable with some
older versions of glibc. Yes, glibc is now fixed and, yes, glibc
should never have exported to the entire system a common four letter
word. But we here at NetworkManager are team players. Fixes
GNOME bug #336532.
git-svn-id: http://svn-archive.gnome.org/svn/NetworkManager/trunk@1764 4912f4e0-d625-0410-9fb7-b9a5a253dbdc
* examples/python/systray/eggtrayicon.c, gnome/applet/eggtrayicon.c,
gnome/applet/passphrase-dialog.c, gnome/applet/vpn-password-dialog.c,
src/NetworkManager.c: Include <glib/gi18n.h> and not <libintl.h>.
git-svn-id: http://svn-archive.gnome.org/svn/NetworkManager/trunk@1760 4912f4e0-d625-0410-9fb7-b9a5a253dbdc
* gnome/applet/Makefile.am, gnome/vpn-properties/Makefile.am,
libnm-util/Makefile.am, src/Makefile.am,
vpn-daemons/openvpn/auth-dialog/Makefile.am,
vpn-daemons/openvpn/properties/Makefile.am,
vpn-daemons/pptp/auth-dialog/Makefile.am,
vpn-daemons/pptp/properties/Makefile.am,
vpn-daemons/vpnc/auth-dialog/Makefile.am,
vpn-daemons/vpnc/properties/Makefile.am: Do not override what the
user passed for --datadir, if anything, when setting the GNOME locale
directory. It should be a function of the specified datadir and not
the prefix.
git-svn-id: http://svn-archive.gnome.org/svn/NetworkManager/trunk@1759 4912f4e0-d625-0410-9fb7-b9a5a253dbdc
* gnome/applet/main.c, gnome/vpn-properties/nm-vpn-properties.c,
src/NetworkManager.c: Take care to call bindtextdomain with the
location of msgid files.
* src/Makefile.am: Set GNOMELOCALEDIR to the location of GNOME mo
files.
git-svn-id: http://svn-archive.gnome.org/svn/NetworkManager/trunk@1758 4912f4e0-d625-0410-9fb7-b9a5a253dbdc
* gnome/applet/applet.c: Zero out the icon pointers before we set them,
to avoid calling g_object_unref() on stale pointers on error in
nma_icons_free(). This happens because we short-circuit loaded the
icons on the first failure but then free all icons. Normally we have
no issue because the icons were zero'ed out malloc, but we have stale
pointer data after nma_icon_theme_changed().
* gnome/applet/main.c: Return error code if nma_new() failed.
git-svn-id: http://svn-archive.gnome.org/svn/NetworkManager/trunk@1755 4912f4e0-d625-0410-9fb7-b9a5a253dbdc
Functionality to differentiate Ad-Hoc networks from infrastructure
networks in the applet, by displaying a special icon:
* gnome/applet/applet-dbus-devices.c: Set the mode for new networks.
* gnome/applet/applet.c: Pass 'applet' to network_menu_item_update().
* gnome/applet/menu-items.c: Set a special icon in the scan list for
ad-hoc networks. TODO: Add a third icon representing "encrypted and
Ad-Hoc". Right now, we display the same icon for all Ad-Hoc wireless
networks, encrypted or not.
* gnome/applet/wireless-network.c, gnome/applet/wireless-network.h: New
accessor functions to get and set the mode of a given network,
wireless_network_get_mode() and wireless_network_set_mode().
git-svn-id: http://svn-archive.gnome.org/svn/NetworkManager/trunk@1741 4912f4e0-d625-0410-9fb7-b9a5a253dbdc
Functionality to automatically add BSSIDs to the allowed-MAC list as
one roams from access point to access point on a given network:
* src/NetworkManagerUtils.c: Add nm_ethernet_addresses_are_equal(),
helper function to compare two ether_addr structures and return TRUE
if they contain the same MAC address.
* src/NetworkManagerUtils.h: Add nm_ethernet_addresses_are_equal()
prototype.
* src/nm-device-802-11-wireless.c: New function to update the BSSID
stored with the current AP. If the BSSID has indeed changed, we
send it out to the applet, allowing the allowed-MAC list to grow
automatically in response to roaming.
git-svn-id: http://svn-archive.gnome.org/svn/NetworkManager/trunk@1739 4912f4e0-d625-0410-9fb7-b9a5a253dbdc
* gnome/applet/nm-gconf-wso-wpa-eap.c: Fix FIXME: Save the WPA EAP
private certificate passphrase, if any, in the GNOME Keyring.
* libnm-utils/dbus-helpers.c: Update.
git-svn-id: http://svn-archive.gnome.org/svn/NetworkManager/trunk@1723 4912f4e0-d625-0410-9fb7-b9a5a253dbdc
* gnome/libnm_glib/libnm_glib.c
- Don't suck CPU when dbus isn't around by scheduling idle handlers
to reconnect; instead wait a bit more with each reconnect attempt
up to a max of one minute.
git-svn-id: http://svn-archive.gnome.org/svn/NetworkManager/trunk@1718 4912f4e0-d625-0410-9fb7-b9a5a253dbdc
* gnome/applet/passphrase-dialog.c (update_button_cb): Get the SSID of
the WirelessNetwork structure using the proper function instead of
just casting it directly to (const char *) (gnome.org #336991)
git-svn-id: http://svn-archive.gnome.org/svn/NetworkManager/trunk@1717 4912f4e0-d625-0410-9fb7-b9a5a253dbdc
Fix bug where hidden ESSID's would not show up in the applet, even
if NMI provided a BSSID -> ESSID mapping from Gconf. This occurred
because nm_policy_device_list_update_from_allowed_list() would merge
the data, putting a name to the hidden networks, but never notify NMI
of the changes. Simple fix is to invoke the function
nm_dbus_signal_wireless_network_change() if we make a mapping.
* src/NetworkManagerAPList.c: Call the function
nm_dbus_signal_wireless_network_change() if we made a successful
BSSID to ESSID mapping, notifying the applet of the "new" network.
* src/NetworkManagerAPList.h: Update the prototypes for both
nm_ap_list_copy_essids_by_address() and
nm_ap_list_copy_one_essid_by_address().
git-svn-id: http://svn-archive.gnome.org/svn/NetworkManager/trunk@1700 4912f4e0-d625-0410-9fb7-b9a5a253dbdc
* gnome/vpn-properties/nm-vpn-properties.c: Satisfy TODO: Ensure that
only one copy of nm-vpn-properties is running at a time via the 'ol
X selection trick. This prevents the user from opening two "VPN
Connections" windows from within the applet, which leads to mass
hysteria.
* clipboard.c: New file, implementing simple X selection logic.
* clipboard.h: New file.
* gnome/vpn-properties/Makefile.am: Add clipboard.{c,h}
git-svn-id: http://svn-archive.gnome.org/svn/NetworkManager/trunk@1695 4912f4e0-d625-0410-9fb7-b9a5a253dbdc
* gnome/vpn-properties/nm-vpn-properties.c: Intercept and short-circuit
the "delete_event" signal on the druid's parent window and handle it
our way, lest using the WM to close the druid results in a series of
bloody and ultimately lethal errors.
git-svn-id: http://svn-archive.gnome.org/svn/NetworkManager/trunk@1677 4912f4e0-d625-0410-9fb7-b9a5a253dbdc
* gnome/vpn-properties/nm-vpn-properties.c: Validate VPN settings on
'Back' too or else the 'Forward' option is initially disabled despite
valid input.
git-svn-id: http://svn-archive.gnome.org/svn/NetworkManager/trunk@1676 4912f4e0-d625-0410-9fb7-b9a5a253dbdc
* gnome/applet/applet.c: Remove the 'Remove' option that I added to the
applet. It just confuses the crap out of people and does not make a
lot of sense, as the daemon still runs.
git-svn-id: http://svn-archive.gnome.org/svn/NetworkManager/trunk@1671 4912f4e0-d625-0410-9fb7-b9a5a253dbdc
* gnome/applet/other-network-dialog.c: Do not allow the user to try to
create WPA-EAP Ad-Hoc networks because such an action makes no sense.
git-svn-id: http://svn-archive.gnome.org/svn/NetworkManager/trunk@1642 4912f4e0-d625-0410-9fb7-b9a5a253dbdc
Patch by Jon Escombe <list@dresco.co.uk>:
* gnome/applet/nm-gconf-wso.c: Add missing NM_AUTH_TYPE_WPA_EAP case.
* gnome/applet/nm-gconf-wso-wpa-eap.c: If retrieving the gconf values
fail, don't bail out. We don't expect all of the various WPA-EAP
values to be present.
* src/nm-ap-security.c: We need to match all capabilities for each
encryption type, not any one of them.
git-svn-id: http://svn-archive.gnome.org/svn/NetworkManager/trunk@1640 4912f4e0-d625-0410-9fb7-b9a5a253dbdc
* gnome/applet/applet-notifications.c:
When displaying a notification, make sure to get rid of the
previous notification so as to not have competing bubbles,
and stop leaking the old one.
* gnome/applet/applet.c:
* gnome/applet/applet.h:
Add a new 'notification' member to the applet, and zero it out
and free it appropriately.
git-svn-id: http://svn-archive.gnome.org/svn/NetworkManager/trunk@1635 4912f4e0-d625-0410-9fb7-b9a5a253dbdc
Patch by j <j@bootlab.org>:
* gnome/applet/applet.glade: Don't set the invisible_char property,
which simply overrides the GTK default. By and by, this behavior
ought to be fixed in Glade.
git-svn-id: http://svn-archive.gnome.org/svn/NetworkManager/trunk@1633 4912f4e0-d625-0410-9fb7-b9a5a253dbdc
Bug fix by Timo Hoenig <thoenig@suse.de>:
* gnome/applet/applet-dbus.c: Let the applet reconnect to DBUS on
disconnect. Otherwise, we have the daemon surviving DBUS restarts
and the applet going AWOL.
git-svn-id: http://svn-archive.gnome.org/svn/NetworkManager/trunk@1630 4912f4e0-d625-0410-9fb7-b9a5a253dbdc
Implement "Dynamic WEP", which is basically WPA authentication and WEP
key exchange via WPA, ostensibly providing good security without
requiring hardware that supports full WPA. Also, add UI elements to
allow the user to select the pairwise & group cipher for WPA Enterprise
networks, too:
* gnome/applet/applet.glade: Update glade file.
* gnome/applet/nm-gconf-wso-wpa-eap.c: Serialize and deserialize the
key type, too, to and from gconf.
* gnome/applet/wireless-security-option.c: Add "wpa_eap" parameter to
wso_wpa_create_key_type_model(), noting whether we are handling PSK
or EAP configuration, and in the latter case add in "Dynamic WEP" if
the capabilities match.
* gnome/applet/wso-private.h: Update wso_wpa_create_key_type_model()'s
prototype.
* gnome/applet/wso-wpa-eap.c: Manage UI elements for the key type and
serialize from UI to DBUS.
* gnome/applet/wso-wpa-psk.c: Cannot fail and always returns at least
one element.
* libnm-util/dbus-helpers.c: Update nmu_security_serialize_wpa_eap(),
nmu_security_serialize_wpa_eap_with_cipher(), and
nmu_security_deserialize_wpa_eap() to take a "key_type" parameter and
serialize/deserialize the key type via DBUS as the new third DBUS
parameter.
* libnm-util/dbus-helpers.h: Update prototypes.
* src/nm-ap-security-wpa-eap.c: Deserialize the key type from DBUS,
too. If the key type is WEP104, do Dynamic WEP, which means
"IEEE8021X" for "key_mgmt". Also add support for user-specified
pairwise and group ciphers (fixes a FIXME).
git-svn-id: http://svn-archive.gnome.org/svn/NetworkManager/trunk@1628 4912f4e0-d625-0410-9fb7-b9a5a253dbdc
