Commit graph

1518 commits

Author SHA1 Message Date
Dan Williams
dc09f62e2e wifi: fix AP flags for user-created Ad-Hoc and hidden Infrastructure networks
Fake APs created in nm_ap_new_fake_from_connection() didn't get the
right flags due to wrong interpretation of # WPA protos; no protos really
means "all ciphers".  Thus the applet wouldn't ask for the right type of
security info if the connection failed; for hidden WPA networks, the applet
would instead ask for WEP keys.

Clean up addition of flags for 'fake' WPA APs in general; pairwise
shouldn't ever include WEP ciphers, and if the connection didn't
include any pairwise or group ciphers, default to "all" as is
expected.  Also fix flags for WPA Ad-Hoc networks, since they have
special limitations imposed by the supplicant and drivers.
2009-03-04 17:18:33 -05:00
Dan Williams
c59eb16817 wifi: remove user-created Ad-Hoc APs from the scan list when no longer used (bgo #569241)
The first fix didn't cover creating a new adhoc network while already joined
to an existing adhoc network; thus clearing the 'fake' flag wouldn't necessarily
drop the old adhoc network from the scan list, because NM doesn't scan in adhoc
mode, and thus the scan list culling function wouldn't run.

Even if the AP being removed isn't adhoc, it was never found from a scan anyway
(if it had, the fake flag would have been reset) and thus we don't care about
it anymore.
2009-03-04 17:18:28 -05:00
Dan Williams
9e0ebf36ac wifi: ensure user-created Ad-Hoc APs disappear when no longer used (bgo #569241)
Since NM doesn't scan while associated with an Ad-Hoc BSS (since
scanning in adhoc mode makes most driver quite angry and doesn't
work well anyway) the user-created BSS was never found in the scan
list, and the 'fake' flag wasn't cleared.  Thus the BSS stuck
around in NM's scan list forever.

Additionally, ensure that set_current_ap() maintains a reference
to the old AP until after setting the new AP, just in case the same
AP is being set again.

Third, handle IBSS coalescing by always updating the current AP's
address (if it's an Ad-Hoc AP) with the BSSID reported by the card.
The joined Ad-Hoc networks' BSSID will change if the card
coalesces with other stations in the same IBSS, which would make
NM fail to find the currently joined network in the scan list, and
lead to "roamed to (none)" messages and inability to find the
current AP.
2009-03-04 09:03:17 -05:00
Dan Williams
7028eb0969 wifi: fix longstanding bug where scan list gets duplicated
Obviously, two APs with exactly the same flags are compatible.
2009-03-04 09:02:52 -05:00
Dan Williams
857a073d88 wifi: add NM_ACTIVE_AP_DEBUG to help debug active ap issues 2009-03-03 07:22:37 -05:00
Dan Williams
f648c269bc core: ensure superclass' finalize method is called
Fixes a crash with PropertyChanged signals (triggered when using wifi + vpn and
rmmod-ing the driver) where properties_changed_info_destroy() wouldn't get
called on object destruction becuase the GObject finalize method never got
called for the DHCP4Config and IP4Config objects.
2009-02-25 13:53:24 -05:00
Dan Williams
25c030ef2e core: use IFF_LOWER_UP instead of IFF_RUNNING for carrier (lp #332064)
We really have wanted to use IFF_LOWER_UP since 2.6.17 for carrier
status, since that's tied to netif_carrier_ok()/netif_carrier_on() in
the kernel.  See kernel commit b00055aacdb172c05067612278ba27265fcd05ce
for the introduction of IFF_LOWER_UP.
2009-02-20 09:43:27 -05:00
Dan Williams
0393d4fa56 802.1x: allow explicitly specifying PEAP version to either 0 or 1
Previously requiring only v1 was possible, but there are apparently
so many different implementations of v1 that sometimes you have to force
v0 instead.
2009-02-19 13:06:56 -05:00
Dan Williams
27a1b1607f core: clean up initial device messages 2009-02-18 14:21:02 -05:00
Dan Williams
68ca77cdb5 dhcp: always clean up DHCP client watch callback when stopping DHCP
Also fix a bug where failure to start the DHCP client wouldn't be
handled.
2009-02-18 09:57:33 -05:00
Dan Williams
3888405134 dbus: final dbus policy fixes (bgo #563730)
Keep explicit denials, consolidate stuff, ensure that when denying
send_interface it's almost always matched with send_destination.
2009-02-17 10:43:53 -05:00
Dan Williams
f33b7627fe core: sync with NETWORKMANAGER_0_7 branch device creation changes
Reduce the diff between head and the 0.7 stable branch.  Shouldn't
result in any functional changes.
2009-02-16 18:47:03 -05:00
Dan Williams
73659e724c makefile cleanups
0.7 requires dbus 1.1 or greater (for system bus activation), so make that
explicit, and remove compat code for D-Bus 0.6 and earlier.  Consolidate
the various glib pkgconfig checks into one, since most anything will require
gthread, glib, and gobject anyway.  Fixup the docs makefile to be more
automake-compatible and let 'make clean' actually work correctly when
docs are built.
2009-02-15 11:20:25 -05:00
Dan Williams
c100d0d779 dbus: clean up reconnection
The reconnection timeout would never be canceled, and get rid of the
"disconnected by the system bus" message on exit, which while
technically true was useless due to the pending exit.
2009-02-15 10:17:53 -05:00
Dan Williams
64a11d9e2b core: log when exiting 2009-02-15 10:14:34 -05:00
Dan Williams
f0b6da5fe8 core: fix error reporting from replace_default_ip4_route() (rh #477916) 2009-02-13 07:00:34 -05:00
Dan Williams
050a31e50d core: increase SSID buffer size to fix 32-character SSIDs (rh #485312, lp281755) 2009-02-12 16:25:19 -05:00
Dan Williams
ed274df7c7 rfkill: rework to handle new dynamic HAL killswitches
Requires HAL 0.5.12 as of 2008-11-19 and kernel 2.6.27 or later; if
any dynamic killswitches are found, polled killswitches are ignored.
This is half the fix; the other half is to do something intelligent
with the rfkill state instead of taking the wifi devices down.
2009-02-10 23:06:24 -05:00
Dan Williams
2445f78e07 core: remove stray semi-colon 2009-02-10 18:30:59 -05:00
Tambet Ingo
614d1c7712 Use the correct signature for DeviceAdded and DeviceRemoved MM signals. 2009-02-10 15:34:21 +02:00
Dan Williams
555dfd35e6 core: allow uid 0 to activate user connections
Previously, uid 0 was not permitted to activate user connections,
but in some cases this is desired.
2009-02-10 06:31:50 -05:00
Tambet Ingo
a772546212 Convert MM errors to NM state reasons. 2009-02-09 11:01:35 +02:00
Tambet Ingo
c4b10085c9 Use the existing dbus-glib macros. 2009-02-09 11:01:35 +02:00
Tambet Ingo
eaa93b0387 Remove HSO and MBM modem implementations and replace them with generic code. 2009-02-09 11:01:35 +02:00
Tambet Ingo
10784dd1b6 Use the 'Simple' modem interface. 2009-02-09 11:01:35 +02:00
Tambet Ingo
9c0d6b468d Share some utility helper functions to send hash tables containing GValues over dbus. 2009-02-09 11:01:35 +02:00
Tambet Ingo
e4398a88c8 Use ModemManager. 2009-02-09 11:01:35 +02:00
Dan Williams
ce3473dc90 clear pending activation checks on device removal
Found by Drew Moseley <dmoseley@mvista.com>
2009-02-06 15:38:09 -05:00
Dan Williams
675a01ab9a fix dbus conf file broken by 7c3063faea 2009-02-05 07:15:04 -05:00
Dan Williams
7c3063faea ppp: don't require separate bus name for pppd plugin communication
Not actually needed, and actually makes securing the daemon harder
from a D-Bus perspective, since both bus names resolve to the same
unique name anyway, and the unique name is what actually gets
matched on inside dbus.  Suggestion from Colin Walters.
2009-02-05 06:05:10 -05:00
Dan Williams
718debc2cd fix distcheck for real 2009-02-02 01:36:43 -05:00
Michael Biebl
8a2393ade2 vpn: ignore VPN service files that don't end in .name 2009-01-30 00:00:12 -05:00
Dan Williams
468ca67a1f ppp: always use 'noauth'
Since NM is really only a client of the provider's PPP server, and since NM
doesn't have any authentication information to authenticate the remote
peer anyway.  Some providers don't set up their servers to allow clients to
ask for authentication from the remote peer either.
2009-01-28 11:49:28 -05:00
Dan Williams
4a7bfefeec ppp: honor MTU from PPP setting 2009-01-26 16:10:19 -05:00
Dan Williams
d7e671ddad make distcheck happier (but still not completely happy) 2009-01-22 19:38:53 -05:00
Przemysław Grzegorczyk
bac45aa0d5 clean up glib includes (bgo #564376)
Only <glib.h> and <gtk/gtk.h> need to be included.
2009-01-19 00:16:40 -05:00
Dan Williams
f2e8870338 dhcp: handle classless static routes (bgo #567246)
Based on patches by Johan Bilien <jobi@via.ecp.fr>,
nick loeve <trickie@gmail.com>, and Roy Marples <roy@marples.name>
with significant changes for dhclient formatting and test cases.

Note that dhclient needs help before it can actually parse
classless static routes by adding the following to the
dhclient.conf file:

option rfc3442-classless-static-routes code 121 = array of unsigned integer 8;
2009-01-18 23:19:09 -05:00
Dan Williams
f06a136a99 move nm_utils_ip4_addr_to_nl_addr() to nm-ip4-config.c
Since that's the only place it's used.
2009-01-18 20:04:14 -05:00
Dan Williams
4aab9ff556 gsm: add init string for USBModem by MobileStream for Palm devices 2009-01-16 16:41:54 -05:00
Sjoerd Simons
c96333de17 gsm: handle different modem init sequences more elegantly
Change the encoding on the channel to binary too, since modems usually don't
send UTF-8.
2009-01-16 16:40:59 -05:00
Dan Williams
0400af7d03 Clarify variable name 2009-01-12 10:44:00 -05:00
Dan Williams
a10775c928 Merge branch wins-in-ip4-config 2009-01-04 19:15:03 -05:00
Jan Kantert
4ca66db721 Use g_timeout_add_seconds() to reduce wakeups
(and refine the older glib compat mechanism, by Dan)
2008-12-31 18:57:36 -05:00
Dan Williams
3f907cb9e3 License header and FSF address update 2008-12-20 09:46:41 -05:00
Michael Biebl
c733dbf6d0 Remove .cvsignore file, they are obsolete 2008-12-19 21:23:08 -05:00
Dan Williams
a020ed21da Re-add WINS support to the IPv4 config
Don't do anything with WINS servers (dispatcher scripts installed with
samba could certainly update samba's idea of WINS servers), but at least
provide them so that the VPNs that can get upstream WINS servers can
at least make other stuff aware of them.
2008-12-19 17:01:06 -05:00
Dan Williams
706118b9db Use correct dhclient leasefile location for Debian systems
Patch by Michael Biebl <mbiebl@debian.org>
2008-12-16 15:24:38 -05:00
Dan Williams
948ee274da 2008-12-09 Dan Williams <dcbw@redhat.com>
* libnm-util/libnm-util.ver
	  libnm-util/nm-setting-ip4-config.c
	  libnm-util/nm-setting-ip4-config.h
		- Add 'never-default' property, which when true indicates that a
			connection should never be the default connection

	* src/nm-ip4-config.c
	  src/nm-ip4-config.h
		- (nm_ip4_config_get_never_default, nm_ip4_config_set_never_default):
			Add never-default helpers

	* src/NetworkManagerUtils.c
		- (nm_utils_merge_ip4_config): update never-default when merging the
			IP4 setting to the IP4 config

	* src/NetworkManagerSystem.c
		- (nm_system_apply_ip4_config): if the connection is never-default,
			don't add routes without a gateway

	* src/NetworkManagerPolicy.c
		- (get_best_device): don't let never-default connections be the best
		- (update_routing_and_dns): handle never-default for VPN connections

	* system-settings/plugins/ifcfg-rh/reader.c
		- (make_ip4_setting): handle never-default by checking GATEWAYDEV



git-svn-id: http://svn-archive.gnome.org/svn/NetworkManager/branches/NETWORKMANAGER_0_7@4378 4912f4e0-d625-0410-9fb7-b9a5a253dbdc
2008-12-09 20:01:49 +00:00
Dan Williams
6bfade3227 2008-12-08 Dan Williams <dcbw@redhat.com>
* src/vpn-manager/nm-vpn-connection.c
		- (plugin_state_changed): clear secrets before setting the connection
			state to FAILED, since doing so may destroy the connection itself,
			since the NMVPNService owning this NMVPNConnection will unref it
			when the NMVPNConnection is failed or stopped



git-svn-id: http://svn-archive.gnome.org/svn/NetworkManager/branches/NETWORKMANAGER_0_7@4374 4912f4e0-d625-0410-9fb7-b9a5a253dbdc
2008-12-08 15:24:38 +00:00
Dan Williams
82d598cdee Fix literal error message
git-svn-id: http://svn-archive.gnome.org/svn/NetworkManager/branches/NETWORKMANAGER_0_7@4361 4912f4e0-d625-0410-9fb7-b9a5a253dbdc
2008-12-03 23:14:59 +00:00