Thomas Haller
7b73951b1b
build: buld nm-dhcp-manager.c as part of libNetworkMangerBase
...
NetworkManager and nm-iface-helper compiled nm-dhcp-manager.c twice,
the latter with setting -DNM_DHCP_INTERNAL_ONLY to only enable the
internal plugin.
Change that to compile nm-dhcp-manager.c once for both users
by putting it into libNetworkManagerBase.
2016-10-22 17:55:15 +02:00
Thomas Haller
002f17c25d
src: drop generated nm-src-enum-types.h
...
We only needed proper glib enum types for having properties
and signal arguments. These got all converted to plain int,
so no longer generate such an enum type.
2016-10-22 17:16:17 +02:00
Thomas Haller
3bbc55fd9c
core: don't use generated glib enum for platform types
2016-10-22 17:16:17 +02:00
Thomas Haller
931a5b4f1c
core: don't use generated glib enum for NMAuthSubjectType
2016-10-22 17:16:17 +02:00
Thomas Haller
548a5440e9
ifcfg-rh: fix signature of link_changed() callback
...
Depending on how arguments are passed to the called function,
this could lead to a crash.
Maybe not on 32 bit machines where the size of the pointer is
the size of an int.
Maybe not on x86_64, where the arguments are passed in registers.
Fixes: b88c309167
2016-10-22 16:12:58 +02:00
Thomas Haller
7bf4a15504
build: merge "src/tests/Makefile.am" into toplevel Makefile
2016-10-21 17:04:06 +02:00
Thomas Haller
1d8934e705
build: merge "src/tests/config/Makefile.am" into toplevel Makefile
2016-10-21 17:04:06 +02:00
Thomas Haller
a0bb990f39
build: merge "src/supplicant-manager/tests/Makefile.am" into toplevel Makefile
2016-10-21 17:04:06 +02:00
Thomas Haller
e52a5e1146
build: merge "src/rdisc/tests/Makefile.am" into toplevel Makefile
2016-10-21 17:04:06 +02:00
Thomas Haller
f3437707e3
build: merge "src/devices/tests/Makefile.am" into toplevel Makefile
2016-10-21 17:04:06 +02:00
Thomas Haller
04eb0afd28
build: merge "src/platform/tests/Makefile.am" into toplevel Makefile
2016-10-21 17:04:06 +02:00
Thomas Haller
123b66b9f4
build: merge "src/dnsmasq-manager/tests/Makefile.am" into toplevel Makefile
2016-10-21 17:04:06 +02:00
Thomas Haller
ecb9f140cf
build: merge "src/devices/team/Makefile.am" into toplevel Makefile
2016-10-21 17:04:06 +02:00
Thomas Haller
eecd05b5bf
build: merge "src/devices/wifi/tests/Makefile.am" into toplevel Makefile
2016-10-21 17:04:06 +02:00
Thomas Haller
da006929dd
build: merge "src/devices/wifi/Makefile.am" into toplevel Makefile
2016-10-21 17:04:06 +02:00
Thomas Haller
ee601ff296
build: merge "src/devices/bluetooth/Makefile.am" into toplevel Makefile
2016-10-21 17:04:06 +02:00
Thomas Haller
72d53e4b69
build: merge "src/devices/wwan/Makefile.am" into toplevel Makefile
2016-10-21 17:04:06 +02:00
Thomas Haller
ca7f59d332
build: merge "src/devices/adsl/Makefile.am" into toplevel Makefile
2016-10-21 17:04:06 +02:00
Thomas Haller
b48b56c499
build: merge "src/settings/plugins/ifnet/tests/Makefile.am" into toplevel Makefile
2016-10-21 17:04:05 +02:00
Thomas Haller
b2d4180787
build: merge "src/settings/plugins/ifnet/Makefile.am" into toplevel Makefile
2016-10-21 16:47:03 +02:00
Thomas Haller
b661b17687
build: merge "src/settings/plugins/ifupdown/tests/Makefile.am" into toplevel Makefile
2016-10-21 16:47:03 +02:00
Thomas Haller
4128d837ac
build: merge "src/settings/plugins/ifupdown/Makefile.am" into toplevel Makefile
2016-10-21 16:47:03 +02:00
Thomas Haller
2169a09f07
build: merge "src/settings/plugins/ifcfg-rh/tests/Makefile.am" into toplevel Makefile
2016-10-21 16:47:02 +02:00
Thomas Haller
181dfe17d8
build: merge "src/settings/plugins/ifcfg-rh/Makefile.am" into toplevel Makefile
2016-10-19 17:16:08 +02:00
Thomas Haller
f87d153f8a
build: merge "src/settings/plugins/ibft/Makefile.am" into toplevel Makefile
2016-10-19 17:16:08 +02:00
Thomas Haller
541f543451
build: merge "src/settings/plugins/keyfile/Makefile.am" into toplevel Makefile
2016-10-19 17:16:08 +02:00
Thomas Haller
48058ff21f
build: merge "src/ppp-manager/Makefile.am" into toplevel Makefile
2016-10-19 17:16:08 +02:00
Thomas Haller
815624bf24
build: merge "src/dhcp-manager/tests/Makefile.am" into toplevel Makefile
2016-10-19 17:16:08 +02:00
Thomas Haller
481d2165e9
build: merge "src/dhcp-manager/Makefile.am" into toplevel Makefile
2016-10-19 17:16:08 +02:00
Thomas Haller
b219eb19f1
build: merge "src/Makefile.am" into toplevel Makefile
...
Had to rename "nm-enum-types.h" because it works badly with
"libnm/nm-enum-types.h". Maybe I could fix that differently,
but duplicate names is anyway error prone.
Note that "nm-core-enum-types.h" is already taken too, so
"nm-src-enum-types.h" it is.
2016-10-19 17:16:08 +02:00
Thomas Haller
274de2555b
build/trivial: rename VALGRIND_RULES in Makefile.am to NM_LOG_COMPILER
2016-10-19 15:26:30 +02:00
Thomas Haller
5424e3a063
keyfile: disable permission checks of keyfile for tests
...
The tests were checking that the keyfiles had permission
0600 and there was a check-local target to prepare the permissons
of the tests.
That is inconvenient, and it is unexpected to have a check-local
target for such a case.
Also, the tests were not testing that keyfile reader would
bail out on invalid permissions. So just skip the check for
testing.
2016-10-19 15:26:30 +02:00
Thomas Haller
068dd41df9
platform/tests: relax assertion in software_add
...
Avoid failure
NMPlatformSignalAssert: test-link.c:146, software_add(): failure to accept signal one time: link-changed-changed ifindex 15 (2 times received)
2016-10-19 15:23:49 +02:00
Beniamino Galvani
956f0be2f9
platform: fix lifetime check
2016-10-18 16:48:27 +02:00
Beniamino Galvani
628cc8a057
arping: fix error handling when starting probe
...
We didn't check the return value of g_spawn_async() and added a watch
on a potentially zero pid.
2016-10-18 16:48:27 +02:00
Lubomir Rintel
2c43862b2d
platform/tests: don't attempt to mount anything to /sys/devices
...
More recent kernels won't allow that in userns when /sys itself
is read-only.
2016-10-17 15:45:59 +02:00
Lubomir Rintel
0acdcc348c
Revert "platform/tests: skip root tests when we can't mount /sys/devices"
...
This was plain stupid. We don't care about sysfs being writable or
anything *before* entering the namespace.
This reverts commit 15a26d6192
2016-10-17 15:45:59 +02:00
Beniamino Galvani
a67bdbc331
core: handle the autoconnect-retries property
2016-10-16 12:56:09 +02:00
Beniamino Galvani
f63e28b147
ifcfg-rh: support the autoconnect-retries property
2016-10-16 12:56:09 +02:00
Beniamino Galvani
92a8cfac69
core: introduce default logging macros
2016-10-14 15:57:43 +02:00
Beniamino Galvani
89bcf50f61
platform: avoid unaligned access to link stats on 64bit architectures
...
The undefined behavior sanitizer complains with:
platform/nm-linux-platform.c:1482:31: runtime error: member access within misaligned address 0x61a000016fac for type 'struct rtnl_link_stats64', which requires 8 byte alignment
0x61a000016fac: note: pointer points here
bc 00 17 00 bf 05 00 00 00 00 00 00 bf 05 00 00 00 00 00 00 b5 68 02 00 00 00 00 00 b5 68 02 00
^
platform/nm-linux-platform.c:1483:29: runtime error: member access within misaligned address 0x61a000016fac for type 'struct rtnl_link_stats64', which requires 8 byte alignment
0x61a000016fac: note: pointer points here
bc 00 17 00 bf 05 00 00 00 00 00 00 bf 05 00 00 00 00 00 00 b5 68 02 00 00 00 00 00 b5 68 02 00
^
platform/nm-linux-platform.c:1484:31: runtime error: member access within misaligned address 0x61a000016fac for type 'struct rtnl_link_stats64', which requires 8 byte alignment
0x61a000016fac: note: pointer points here
bc 00 17 00 bf 05 00 00 00 00 00 00 bf 05 00 00 00 00 00 00 b5 68 02 00 00 00 00 00 b5 68 02 00
^
platform/nm-linux-platform.c:1485:29: runtime error: member access within misaligned address 0x61a000016fac for type 'struct rtnl_link_stats64', which requires 8 byte alignment
0x61a000016fac: note: pointer points here
bc 00 17 00 bf 05 00 00 00 00 00 00 bf 05 00 00 00 00 00 00 b5 68 02 00 00 00 00 00 b5 68 02 00
^
That's because the pointer returned by nla_data() is only
32bit-aligned and using it to access structure members can cause
issues on some 64bit architectures.
Use the unaligned_read_ne64() macro to access the structure members.
https://bugzilla.gnome.org/show_bug.cgi?id=772605
2016-10-14 11:16:13 +02:00
Thomas Haller
c7853a1415
build: add extra dependencies for linker-version-script for NetworkManager and libnm.so
2016-10-14 10:33:30 +02:00
Beniamino Galvani
0539725aef
supplicant: fix cancellation of interface association
...
The @assoc_cancellable was never initialized and thus ineffective; fix
this.
Furthermore, we only cancel it in nm_supplicant_interface_disconnect()
as we expect that clients call the function before destroying the
interface. Don't assume this and also cancel it in dispose().
https://bugzilla.redhat.com/show_bug.cgi?id=1383628
2016-10-14 09:32:48 +02:00
Thomas Haller
510626bf74
ip-config: cleanup integer types for nm_ip4_config_get_num_*()
2016-10-14 06:18:43 +02:00
Thomas Haller
5253ab0d0d
dns/resolved: don't repeatedly call nm_ip4_config_get_num_*() to iterate config
2016-10-14 06:09:11 +02:00
Thomas Haller
878ed77c6b
dns/resolved: fix style issues
2016-10-14 05:55:31 +02:00
Sjoerd Simons
c4864ba63f
dns/resolved: adjust link domain settings
...
Make link domain settings more conventional. If an IP Config only has no
search entries, use domains for search instead otherwise ignore domains.
Also on connections which are never the default, setup the
search/domains as routing-only meaning that only dns queries for those
domains will be done on this link. Prevents quering DNS information for
on-vpn host with other namservers and using the VPN DNS server for host
not on the VPN.
This is also fixes issues with a recent change in systemd-resolved where
links with a routing domain will only be used for those domains, which
meant that the previous strategry with a typical ip configuration (no
search only domains) resulted in no usable name resolution.
Signed-off-by: Sjoerd Simons <sjoerd.simons@collabora.co.uk>
https://bugzilla.gnome.org/show_bug.cgi?id=772343
2016-10-14 05:40:53 +02:00
Thomas Haller
92f4185575
devices/build: use one linker-script-devices.ver for all device plugins
2016-10-13 21:36:06 +02:00
Thomas Haller
757d06800e
dhcp/build: add linker version script for nm-dhcp-helper binary
2016-10-13 21:33:33 +02:00
Thomas Haller
569d28f573
iface-helper/build: don't link nm-iface-helper with -rdynamic / -export-dynamic
...
Since nm-iface-helper doesn't dlopen any library, it seems not necessary
to link with -rdynamic.
2016-10-13 21:33:33 +02:00
