Patch from Lorenzo Colitti <lorenzo@colitti.com> gnome.org #344825
* src/nm-device-802-11-wireless.c
- (nm_device_802_11_wireless_set_essid): only wait for orinoco cards
or ones where the driver is unknown
- (supplicant_exec): don't wait for supplicant startup here
- (supplicant_interface_init): finer grained polling for supplicant
startup
git-svn-id: http://svn-archive.gnome.org/svn/NetworkManager/trunk@1825 4912f4e0-d625-0410-9fb7-b9a5a253dbdc
* gnome/applet/applet-dbus-info.c: Don't set the fallback bit to FALSE
if it is currently set to TRUE. Otherwise, we will reset the value
when we connect normally.
* src/nm-device-802-11-wireless.c: For the roaming code, make sure that
the old BSSID is valid, too. The recently added ESSID check may not be
sufficient (we can remove it?). What we really want to catch is the
case of going from all-zeros to the BSSID of some other network, which
happens on failure.
git-svn-id: http://svn-archive.gnome.org/svn/NetworkManager/trunk@1823 4912f4e0-d625-0410-9fb7-b9a5a253dbdc
Patch from Peter Jones:
* src/nm-device-802-11-wireless.c
- (nm_device_802_11_wireless_update_bssid): make sure that the
SSID hasn't changed from what we expect before automatically
updating the saved BSSID from a new AP
git-svn-id: http://svn-archive.gnome.org/svn/NetworkManager/trunk@1816 4912f4e0-d625-0410-9fb7-b9a5a253dbdc
Add 'fallback' support. NetworkManager will attempt to brute-force
connect to networks marked as fallback if there are no better wireless
connections available. This is useful as a method of last resort, to
work around driver problems, and for use with hidden networks.
* gnome/applet/applet-dbus-devices.c,
gnome/applet/applet-dbus-devices.h: Add fallback parameter.
* gnome/applet/applet-dbus-info.c: Retrieve fallback bit from Gconf and
pass it on via DBUS.
* gnome/applet/applet.c: No fallback by default.
* gnome/applet/applet.glade, gnome/applet/other-network-dialog.c:
Update other-network-dialog to add UI checkbox toggling fallback.
* src/NetworkManagerAP.c, src/NetworkManagerAP.h: Remove "trusted"
propery from AP object. Add "fallback" property to AP object.
* src/nm-dbus-nm.c: Grab the fallback parameter via DBUS.
* src/nm-dbus-nmi.c: Grab the fallback parameter via DBUS.
* src/nm-device-802-11-wireless.c: Break out blacklist logic into
separate function. Add get_best_fallback_ap() for returning an AP
on which to attempt fallback.
* src/backends/NetworkManagerSuSE.c: Set stored network as fallback.
* test/nm-set-fallback: New file. Sets a given network as fallback.
git-svn-id: http://svn-archive.gnome.org/svn/NetworkManager/trunk@1814 4912f4e0-d625-0410-9fb7-b9a5a253dbdc
* gnome/applet/gconf-helpers.c: Bug fix: nm_gconf_helper_get_bool()
checked that the return type was GCONF_VALUE_STRING, not the correct
GCONF_VALUE_BOOL, and thus it never worked.
* src/NetworkManagerAPList.c: Before concluding that two networks are
identical based on their BSSID, make sure that the BSSID in question
is actually valid. Specifically, an empty or all zero BSSID does not
cut it.
* gnome/applet/applet-dbus-info.c, gnome/applet/other-network-dialog.c,
src/nm-dbus-nmi.c, src/nm-device-802-11-wireless.c: White space and
similar invariant clean up.
git-svn-id: http://svn-archive.gnome.org/svn/NetworkManager/trunk@1811 4912f4e0-d625-0410-9fb7-b9a5a253dbdc
* gnome/vpn-properties/nm-vpn-properties.c
- (find_vpn_ui_by_service_name): protect against NULL service names
- (update_edit_del_sensitivity): protect against NULL service names
git-svn-id: http://svn-archive.gnome.org/svn/NetworkManager/trunk@1777 4912f4e0-d625-0410-9fb7-b9a5a253dbdc
Patch from Chris Fuller <crf@grandecom.net>:
* src/nm-device-802-11-wireless.c
- (nm_device_802_11_wireless_dispose): add a is_initialized member and
don't dispose of wireless-specific stuff unless it is actually
initialized. Gnome.org #341263
git-svn-id: http://svn-archive.gnome.org/svn/NetworkManager/trunk@1776 4912f4e0-d625-0410-9fb7-b9a5a253dbdc
* src/NetworkManagerPolicy.c
- (nm_policy_device_change_check): don't switch devices if the "best"
AP is essentially the same as the current activation request, but
the current activation request isn't done activating yet. Fixes
multiple requests for keyring password on startup for Gnome applet.
git-svn-id: http://svn-archive.gnome.org/svn/NetworkManager/trunk@1775 4912f4e0-d625-0410-9fb7-b9a5a253dbdc
* src/NetworkManager.c: use GOptions instead of getopt
* configure.in: bump glib required version to >= 2.6 for GOption
support
git-svn-id: http://svn-archive.gnome.org/svn/NetworkManager/trunk@1771 4912f4e0-d625-0410-9fb7-b9a5a253dbdc
* src/nm-device.h: Introduce nm_ioctl_info(), which defines to
nm_info() if IOCTL_DEBUG is set and a no-op if not. We can use this
instead of dumping ifdef's throughout the code.
* src/NetworkManagerSystem.c, src/nm-device-802-11-wireless.c,
src/nm-device-802-3-ethernet.c, src/nm-device.c: Remove ifdef's and
use nm_ioctl_info() in lieu.
git-svn-id: http://svn-archive.gnome.org/svn/NetworkManager/trunk@1768 4912f4e0-d625-0410-9fb7-b9a5a253dbdc
Patch Valentine Sinitsyn <e_val@inbox.ru> to fix GNOME bug #342400:
* libnm-util/Makefile.am: Only build gnome-keyring-md5.{c,h} if we are
not using gcrypt. Otherwise, we get a linker error.
git-svn-id: http://svn-archive.gnome.org/svn/NetworkManager/trunk@1766 4912f4e0-d625-0410-9fb7-b9a5a253dbdc
Patch Valentine Sinitsyn <e_val@inbox.ru> to fix GNOME bug #342398:
* configure.in, gnome/Makefile.am, Makefile.am: Add "--without-gnome"
configure flag to disable building of the GNOME-based applet.
git-svn-id: http://svn-archive.gnome.org/svn/NetworkManager/trunk@1765 4912f4e0-d625-0410-9fb7-b9a5a253dbdc
* gnome/applet/nm-device.c, gnome/applet/nm-device.h: Rename function
parameter from link, because it shadows a global variable with some
older versions of glibc. Yes, glibc is now fixed and, yes, glibc
should never have exported to the entire system a common four letter
word. But we here at NetworkManager are team players. Fixes
GNOME bug #336532.
git-svn-id: http://svn-archive.gnome.org/svn/NetworkManager/trunk@1764 4912f4e0-d625-0410-9fb7-b9a5a253dbdc
* examples/python/systray/eggtrayicon.c, gnome/applet/eggtrayicon.c,
gnome/applet/passphrase-dialog.c, gnome/applet/vpn-password-dialog.c,
src/NetworkManager.c: Include <glib/gi18n.h> and not <libintl.h>.
git-svn-id: http://svn-archive.gnome.org/svn/NetworkManager/trunk@1760 4912f4e0-d625-0410-9fb7-b9a5a253dbdc
* gnome/applet/Makefile.am, gnome/vpn-properties/Makefile.am,
libnm-util/Makefile.am, src/Makefile.am,
vpn-daemons/openvpn/auth-dialog/Makefile.am,
vpn-daemons/openvpn/properties/Makefile.am,
vpn-daemons/pptp/auth-dialog/Makefile.am,
vpn-daemons/pptp/properties/Makefile.am,
vpn-daemons/vpnc/auth-dialog/Makefile.am,
vpn-daemons/vpnc/properties/Makefile.am: Do not override what the
user passed for --datadir, if anything, when setting the GNOME locale
directory. It should be a function of the specified datadir and not
the prefix.
git-svn-id: http://svn-archive.gnome.org/svn/NetworkManager/trunk@1759 4912f4e0-d625-0410-9fb7-b9a5a253dbdc
* gnome/applet/main.c, gnome/vpn-properties/nm-vpn-properties.c,
src/NetworkManager.c: Take care to call bindtextdomain with the
location of msgid files.
* src/Makefile.am: Set GNOMELOCALEDIR to the location of GNOME mo
files.
git-svn-id: http://svn-archive.gnome.org/svn/NetworkManager/trunk@1758 4912f4e0-d625-0410-9fb7-b9a5a253dbdc
* src/nm-device-802-11-wireless.c: Don't chain up to the parent's
stage4_timeout on failure unless the wireless network is Ad-Hoc.
99% of the time there is a real problem with wireless, and a
seemingly successful connection via Zeroconf just confuses the user.
And that 1% of the time the network is probably Ad-Hoc, anyhow.
git-svn-id: http://svn-archive.gnome.org/svn/NetworkManager/trunk@1757 4912f4e0-d625-0410-9fb7-b9a5a253dbdc
* src/backends/NetworkManagerSuSE.c: Reload, do not restart, ypbind and
autofs on interface up if NIS is configured. On interface down, do
nothing.
git-svn-id: http://svn-archive.gnome.org/svn/NetworkManager/trunk@1756 4912f4e0-d625-0410-9fb7-b9a5a253dbdc
* gnome/applet/applet.c: Zero out the icon pointers before we set them,
to avoid calling g_object_unref() on stale pointers on error in
nma_icons_free(). This happens because we short-circuit loaded the
icons on the first failure but then free all icons. Normally we have
no issue because the icons were zero'ed out malloc, but we have stale
pointer data after nma_icon_theme_changed().
* gnome/applet/main.c: Return error code if nma_new() failed.
git-svn-id: http://svn-archive.gnome.org/svn/NetworkManager/trunk@1755 4912f4e0-d625-0410-9fb7-b9a5a253dbdc
Fix gnome.org #330832 based on patch from Crispin Flowerday <crispin@gnome.org>
* src/NetworkManagerDbus.[ch]
- nm_dbus_get_device_from_object_path -> nm_dbus_get_device_from_escaped_object_path:
clarify that function's argument should be an escaped dbus object
path, and look for path segment end before returning a match
* src/nm-dbus-nm.c:
- Fix up users of nm_dbus_get_device_from_escaped_object_path()
git-svn-id: http://svn-archive.gnome.org/svn/NetworkManager/trunk@1749 4912f4e0-d625-0410-9fb7-b9a5a253dbdc
Functionality to differentiate Ad-Hoc networks from infrastructure
networks in the applet, by displaying a special icon:
* gnome/applet/applet-dbus-devices.c: Set the mode for new networks.
* gnome/applet/applet.c: Pass 'applet' to network_menu_item_update().
* gnome/applet/menu-items.c: Set a special icon in the scan list for
ad-hoc networks. TODO: Add a third icon representing "encrypted and
Ad-Hoc". Right now, we display the same icon for all Ad-Hoc wireless
networks, encrypted or not.
* gnome/applet/wireless-network.c, gnome/applet/wireless-network.h: New
accessor functions to get and set the mode of a given network,
wireless_network_get_mode() and wireless_network_set_mode().
git-svn-id: http://svn-archive.gnome.org/svn/NetworkManager/trunk@1741 4912f4e0-d625-0410-9fb7-b9a5a253dbdc
Functionality to automatically add BSSIDs to the allowed-MAC list as
one roams from access point to access point on a given network:
* src/NetworkManagerUtils.c: Add nm_ethernet_addresses_are_equal(),
helper function to compare two ether_addr structures and return TRUE
if they contain the same MAC address.
* src/NetworkManagerUtils.h: Add nm_ethernet_addresses_are_equal()
prototype.
* src/nm-device-802-11-wireless.c: New function to update the BSSID
stored with the current AP. If the BSSID has indeed changed, we
send it out to the applet, allowing the allowed-MAC list to grow
automatically in response to roaming.
git-svn-id: http://svn-archive.gnome.org/svn/NetworkManager/trunk@1739 4912f4e0-d625-0410-9fb7-b9a5a253dbdc
* gnome/applet/nm-gconf-wso-wpa-eap.c: Fix FIXME: Save the WPA EAP
private certificate passphrase, if any, in the GNOME Keyring.
* libnm-utils/dbus-helpers.c: Update.
git-svn-id: http://svn-archive.gnome.org/svn/NetworkManager/trunk@1723 4912f4e0-d625-0410-9fb7-b9a5a253dbdc
* src/nm-device-802-11-wireless.c
- (nm_device_802_11_wireless_set_wep_enc_key): convert to
nm_device_802_11_wireless_disable_encryption() since that's all
we use it for anymore; we don't ever set WEP keys ourselves.
- (real_deactivate_quickly): reset SSID and encryption keys
- (real_deactivate): move SSID and encryption key reset to
real_deactivate_quickly(), which gets run before us anyway
git-svn-id: http://svn-archive.gnome.org/svn/NetworkManager/trunk@1721 4912f4e0-d625-0410-9fb7-b9a5a253dbdc
* src/NetworkManager.c: Set the umask to 0022 when daemonizing, in case
root has a wacky default of its own (or, more common, a user has a
bad umask and uses su/sudo to restart NetworkManager). Anything other
than 0022 does not do what we want with, for example, resolv.conf. This
problem is amplified by our judicious use of fopen(), which uses mode
0666 -- implying that the only way to get the permissions we want is
with a umask of 0022.
git-svn-id: http://svn-archive.gnome.org/svn/NetworkManager/trunk@1719 4912f4e0-d625-0410-9fb7-b9a5a253dbdc
* gnome/libnm_glib/libnm_glib.c
- Don't suck CPU when dbus isn't around by scheduling idle handlers
to reconnect; instead wait a bit more with each reconnect attempt
up to a max of one minute.
git-svn-id: http://svn-archive.gnome.org/svn/NetworkManager/trunk@1718 4912f4e0-d625-0410-9fb7-b9a5a253dbdc
* gnome/applet/passphrase-dialog.c (update_button_cb): Get the SSID of
the WirelessNetwork structure using the proper function instead of
just casting it directly to (const char *) (gnome.org #336991)
git-svn-id: http://svn-archive.gnome.org/svn/NetworkManager/trunk@1717 4912f4e0-d625-0410-9fb7-b9a5a253dbdc
* src/backends/NetworkManagerSuSE.c: Respect the variable
dhcp:DHCLIENT_MODIFY_RESOLV_CONF, not
config:MODIFY_RESOLV_CONF_DYNAMICALLY, when deciding whether or not
to dynamically update /etc/resolv.conf.
git-svn-id: http://svn-archive.gnome.org/svn/NetworkManager/trunk@1716 4912f4e0-d625-0410-9fb7-b9a5a253dbdc
Patch by Timo Hoenig;
* tests/nm-online.c: Print pretty status indicator as timeout winds
down. Also fix possible race between DBUS startup and failure
return.
git-svn-id: http://svn-archive.gnome.org/svn/NetworkManager/trunk@1714 4912f4e0-d625-0410-9fb7-b9a5a253dbdc
