* src/dhcp-manager/nm-dhcp-manager.c
- (get_ip4_string, get_ip4_uint32s): have the caller pass
the dbus connection and the device object path rather than
constructing it inside both functions. Saves a bit of memory
and clarifies a failure path.
- (nm_dhcp_manager_get_ip4_config): grab the dbus connection
and allocate device path here rather than each of the two
functions above.
git-svn-id: http://svn-archive.gnome.org/svn/NetworkManager/trunk@2065 4912f4e0-d625-0410-9fb7-b9a5a253dbdc
* src/NetworkManager.c
- (nm_name_owner_changed_handler): handle NMI coming and going,
this somehow droppout in the refactor
git-svn-id: http://svn-archive.gnome.org/svn/NetworkManager/trunk@2064 4912f4e0-d625-0410-9fb7-b9a5a253dbdc
* Huge DBus refactor:
- Create a "DBus Manager" object which manages the connection and
sends signals on NameOwnerChanged and connection/disconnection events,
handles reconnection to the bus if NM gets kicked off, and abstracts
signal handling
- Remove DBusConnection members from places where they are no
longer needed due to the refactor, like the dbus-connection
property of the named manager, and from NMData
- Reformats a bunch of the code to gnome style
(8-space tabs, braces on same line as statement, 80-col width).
Consider it open season to reformat any bits to gnome style.
style that aren't already.
git-svn-id: http://svn-archive.gnome.org/svn/NetworkManager/trunk@2061 4912f4e0-d625-0410-9fb7-b9a5a253dbdc
* src/vpn-manager/nm-vpn-manager.c
- (nm_vpn_manager_load_services): split and clean up
for readability and correctness. Restrict VPN service
files to ending in ".name", as was meant from the
beginning (but not coded in). Better error reporting.
git-svn-id: http://svn-archive.gnome.org/svn/NetworkManager/trunk@2044 4912f4e0-d625-0410-9fb7-b9a5a253dbdc
* src/backends/NetworkManagerSuSE.c: Do not restart ypbind; our ypbind
package is now DBUS-enabled and listens for the NM signals.
git-svn-id: http://svn-archive.gnome.org/svn/NetworkManager/trunk@1969 4912f4e0-d625-0410-9fb7-b9a5a253dbdc
Patch from Alex Smith <alex.extreme2@gmail.com>
* configure.in
src/backends/Makefile.am
src/backends/NetworkManagerFrugalware.c
- Add support for Frugalware
git-svn-id: http://svn-archive.gnome.org/svn/NetworkManager/trunk@1958 4912f4e0-d625-0410-9fb7-b9a5a253dbdc
Patch from Valentine Sinitsyn <e_val@inbox.ru>
* src/nm-ap-security.c
src/nm-ap-security.h
- Add authentication_required bits for subclasses to specify whether
or not real authentication is required for connections, i.e. whether
the AP rejects us when an encryption key is wrong or not.
* src/nm-ap-security-wep.c
src/nm-ap-security-wpa-eap.c
src/nm-ap-security-wpa-psk.c
src/nm-ap-security-leap.c
- Implement authentication_required appropriately for each method
* src/nm-device-802-11-wireless.c
- Be smarter about when to request a key; for example, using a wrong key
in WEP shared key mode previously just timed out and did not request
a new key
git-svn-id: http://svn-archive.gnome.org/svn/NetworkManager/trunk@1954 4912f4e0-d625-0410-9fb7-b9a5a253dbdc
* src/vpn-manager/nm-vpn-service.c
- Simplify print_vpn_config() arguments
Patch from Antony J Mee <A.J.Mee@ncl.ac.uk>
* src/vpn-manager/Makefile.am
src/vpn-manager/nm-vpn-service.c
- Add new API for passing VPN config options as a dict
git-svn-id: http://svn-archive.gnome.org/svn/NetworkManager/trunk@1944 4912f4e0-d625-0410-9fb7-b9a5a253dbdc
* gnome/applet/applet-dbus-devices.c
gnome/applet/applet-dbus-vpn.c
gnome/applet/applet-dbus.c
gnome/applet/applet-dbus.h
src/nm-dbus-nmi.c
utils/nm-utils.c
utils/nm-utils.h
- Make pending call tracking code generic,
so we can use it in NM as well as the applet
git-svn-id: http://svn-archive.gnome.org/svn/NetworkManager/trunk@1940 4912f4e0-d625-0410-9fb7-b9a5a253dbdc
* src/NetworkManagerAP.c
- Clarify usage of user_created
* src/nm-ap-security-wep.c
src/nm-ap-security-wpa-eap.c
src/nm-ap-security-wpa-psk.c
src/nm-ap-security.c
src/nm-ap-security.h
- s/user_created/adhoc, because we really do mean adhoc
Patch from Bernard Blackham <bernard@blackham.com.au>
* src/nm-device-802-11-wireless.c
- (supplicant_send_network_config): instead of user_created,
use adhoc, and do AP_SCAN 2 for adhoc networks
git-svn-id: http://svn-archive.gnome.org/svn/NetworkManager/trunk@1846 4912f4e0-d625-0410-9fb7-b9a5a253dbdc
* gnome/applet/nm-gconf-wso-wpa-eap.c: Don't set the Gconf keys unless
we have a value to set. Gconf generates a warning if `val' is NULL.
* src/nm-ap-security-wpa-eap.c: Don't set the key for an Enterprise AP
unless we actually received a valid private key file passphrase or
password. Otherwise, we don't know to later ask the applet to pull
the key from the keyring.
git-svn-id: http://svn-archive.gnome.org/svn/NetworkManager/trunk@1845 4912f4e0-d625-0410-9fb7-b9a5a253dbdc
Patch from Lorenzo Colitti <lorenzo@colitti.com> gnome.org #344825
* src/nm-device-802-11-wireless.c
- (nm_device_802_11_wireless_set_essid): only wait for orinoco cards
or ones where the driver is unknown
- (supplicant_exec): don't wait for supplicant startup here
- (supplicant_interface_init): finer grained polling for supplicant
startup
git-svn-id: http://svn-archive.gnome.org/svn/NetworkManager/trunk@1825 4912f4e0-d625-0410-9fb7-b9a5a253dbdc
* gnome/applet/applet-dbus-info.c: Don't set the fallback bit to FALSE
if it is currently set to TRUE. Otherwise, we will reset the value
when we connect normally.
* src/nm-device-802-11-wireless.c: For the roaming code, make sure that
the old BSSID is valid, too. The recently added ESSID check may not be
sufficient (we can remove it?). What we really want to catch is the
case of going from all-zeros to the BSSID of some other network, which
happens on failure.
git-svn-id: http://svn-archive.gnome.org/svn/NetworkManager/trunk@1823 4912f4e0-d625-0410-9fb7-b9a5a253dbdc
Patch from Peter Jones:
* src/nm-device-802-11-wireless.c
- (nm_device_802_11_wireless_update_bssid): make sure that the
SSID hasn't changed from what we expect before automatically
updating the saved BSSID from a new AP
git-svn-id: http://svn-archive.gnome.org/svn/NetworkManager/trunk@1816 4912f4e0-d625-0410-9fb7-b9a5a253dbdc
Add 'fallback' support. NetworkManager will attempt to brute-force
connect to networks marked as fallback if there are no better wireless
connections available. This is useful as a method of last resort, to
work around driver problems, and for use with hidden networks.
* gnome/applet/applet-dbus-devices.c,
gnome/applet/applet-dbus-devices.h: Add fallback parameter.
* gnome/applet/applet-dbus-info.c: Retrieve fallback bit from Gconf and
pass it on via DBUS.
* gnome/applet/applet.c: No fallback by default.
* gnome/applet/applet.glade, gnome/applet/other-network-dialog.c:
Update other-network-dialog to add UI checkbox toggling fallback.
* src/NetworkManagerAP.c, src/NetworkManagerAP.h: Remove "trusted"
propery from AP object. Add "fallback" property to AP object.
* src/nm-dbus-nm.c: Grab the fallback parameter via DBUS.
* src/nm-dbus-nmi.c: Grab the fallback parameter via DBUS.
* src/nm-device-802-11-wireless.c: Break out blacklist logic into
separate function. Add get_best_fallback_ap() for returning an AP
on which to attempt fallback.
* src/backends/NetworkManagerSuSE.c: Set stored network as fallback.
* test/nm-set-fallback: New file. Sets a given network as fallback.
git-svn-id: http://svn-archive.gnome.org/svn/NetworkManager/trunk@1814 4912f4e0-d625-0410-9fb7-b9a5a253dbdc
* gnome/applet/gconf-helpers.c: Bug fix: nm_gconf_helper_get_bool()
checked that the return type was GCONF_VALUE_STRING, not the correct
GCONF_VALUE_BOOL, and thus it never worked.
* src/NetworkManagerAPList.c: Before concluding that two networks are
identical based on their BSSID, make sure that the BSSID in question
is actually valid. Specifically, an empty or all zero BSSID does not
cut it.
* gnome/applet/applet-dbus-info.c, gnome/applet/other-network-dialog.c,
src/nm-dbus-nmi.c, src/nm-device-802-11-wireless.c: White space and
similar invariant clean up.
git-svn-id: http://svn-archive.gnome.org/svn/NetworkManager/trunk@1811 4912f4e0-d625-0410-9fb7-b9a5a253dbdc
Patch from Chris Fuller <crf@grandecom.net>:
* src/nm-device-802-11-wireless.c
- (nm_device_802_11_wireless_dispose): add a is_initialized member and
don't dispose of wireless-specific stuff unless it is actually
initialized. Gnome.org #341263
git-svn-id: http://svn-archive.gnome.org/svn/NetworkManager/trunk@1776 4912f4e0-d625-0410-9fb7-b9a5a253dbdc
* src/NetworkManagerPolicy.c
- (nm_policy_device_change_check): don't switch devices if the "best"
AP is essentially the same as the current activation request, but
the current activation request isn't done activating yet. Fixes
multiple requests for keyring password on startup for Gnome applet.
git-svn-id: http://svn-archive.gnome.org/svn/NetworkManager/trunk@1775 4912f4e0-d625-0410-9fb7-b9a5a253dbdc
* src/NetworkManager.c: use GOptions instead of getopt
* configure.in: bump glib required version to >= 2.6 for GOption
support
git-svn-id: http://svn-archive.gnome.org/svn/NetworkManager/trunk@1771 4912f4e0-d625-0410-9fb7-b9a5a253dbdc
* src/nm-device.h: Introduce nm_ioctl_info(), which defines to
nm_info() if IOCTL_DEBUG is set and a no-op if not. We can use this
instead of dumping ifdef's throughout the code.
* src/NetworkManagerSystem.c, src/nm-device-802-11-wireless.c,
src/nm-device-802-3-ethernet.c, src/nm-device.c: Remove ifdef's and
use nm_ioctl_info() in lieu.
git-svn-id: http://svn-archive.gnome.org/svn/NetworkManager/trunk@1768 4912f4e0-d625-0410-9fb7-b9a5a253dbdc
* examples/python/systray/eggtrayicon.c, gnome/applet/eggtrayicon.c,
gnome/applet/passphrase-dialog.c, gnome/applet/vpn-password-dialog.c,
src/NetworkManager.c: Include <glib/gi18n.h> and not <libintl.h>.
git-svn-id: http://svn-archive.gnome.org/svn/NetworkManager/trunk@1760 4912f4e0-d625-0410-9fb7-b9a5a253dbdc
* gnome/applet/Makefile.am, gnome/vpn-properties/Makefile.am,
libnm-util/Makefile.am, src/Makefile.am,
vpn-daemons/openvpn/auth-dialog/Makefile.am,
vpn-daemons/openvpn/properties/Makefile.am,
vpn-daemons/pptp/auth-dialog/Makefile.am,
vpn-daemons/pptp/properties/Makefile.am,
vpn-daemons/vpnc/auth-dialog/Makefile.am,
vpn-daemons/vpnc/properties/Makefile.am: Do not override what the
user passed for --datadir, if anything, when setting the GNOME locale
directory. It should be a function of the specified datadir and not
the prefix.
git-svn-id: http://svn-archive.gnome.org/svn/NetworkManager/trunk@1759 4912f4e0-d625-0410-9fb7-b9a5a253dbdc
* gnome/applet/main.c, gnome/vpn-properties/nm-vpn-properties.c,
src/NetworkManager.c: Take care to call bindtextdomain with the
location of msgid files.
* src/Makefile.am: Set GNOMELOCALEDIR to the location of GNOME mo
files.
git-svn-id: http://svn-archive.gnome.org/svn/NetworkManager/trunk@1758 4912f4e0-d625-0410-9fb7-b9a5a253dbdc
* src/nm-device-802-11-wireless.c: Don't chain up to the parent's
stage4_timeout on failure unless the wireless network is Ad-Hoc.
99% of the time there is a real problem with wireless, and a
seemingly successful connection via Zeroconf just confuses the user.
And that 1% of the time the network is probably Ad-Hoc, anyhow.
git-svn-id: http://svn-archive.gnome.org/svn/NetworkManager/trunk@1757 4912f4e0-d625-0410-9fb7-b9a5a253dbdc