From fff56e231614da358095cc28343c6191d72627d1 Mon Sep 17 00:00:00 2001 From: Thomas Haller Date: Wed, 22 Nov 2017 20:09:47 +0100 Subject: [PATCH] policy: don't log GError code Our GError codes are mostly meaningless, only the message is interesting. And our messages should anyway be unique, so that one could understand which was the corresponding error code (by inspecting the source code). While at it, use gs_free_error. (cherry picked from commit 3d118f5b4921e538e6885162af73fd4a67c40f3c) --- src/nm-policy.c | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/src/nm-policy.c b/src/nm-policy.c index edd10d41d8..ec70aea7a9 100644 --- a/src/nm-policy.c +++ b/src/nm-policy.c @@ -1191,7 +1191,7 @@ auto_activate_device (NMPolicy *self, gs_free char *specific_object = NULL; gs_free NMSettingsConnection **connections = NULL; guint i, len; - GError *error = NULL; + gs_free_error GError *error = NULL; NMAuthSubject *subject; NMActiveConnection *ac; @@ -1256,11 +1256,9 @@ auto_activate_device (NMPolicy *self, NM_ACTIVATION_TYPE_MANAGED, &error); if (!ac) { - _LOGI (LOGD_DEVICE, "connection '%s' auto-activation failed: (%d) %s", + _LOGI (LOGD_DEVICE, "connection '%s' auto-activation failed: %s", nm_settings_connection_get_id (best_connection), - error->code, error->message); - g_error_free (error); nm_settings_connection_autoconnect_blocked_reason_set (best_connection, NM_SETTINGS_AUTO_CONNECT_BLOCKED_REASON_FAILED); schedule_activate_check (self, device);