fdo-mirrors/NetworkManager
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/NetworkManager/NetworkManager.git synced 2026-03-05 03:00:39 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

policy: don't log GError code

Browse source 
Our GError codes are mostly meaningless, only the message is interesting.
And our messages should anyway be unique, so that one could understand
which was the corresponding error code (by inspecting the source code).

While at it, use gs_free_error.

(cherry picked from commit 3d118f5b49)
This commit is contained in:
Thomas Haller 2017-11-22 20:09:47 +01:00
parent e6d1931fe7
commit fff56e2316
1 changed files with 2 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

6
src/nm-policy.c
View file

@ -1191,7 +1191,7 @@ auto_activate_device (NMPolicy *self,
gs_free char *specific_object = NULL;
gs_free NMSettingsConnection **connections = NULL;
guint i, len;
GError *error = NULL;
gs_free_error GError *error = NULL;
NMAuthSubject *subject;
NMActiveConnection *ac;
@ -1256,11 +1256,9 @@ auto_activate_device (NMPolicy *self,
NM_ACTIVATION_TYPE_MANAGED,
&error);
if (!ac) {
_LOGI (LOGD_DEVICE, "connection '%s' auto-activation failed: (%d) %s",
_LOGI (LOGD_DEVICE, "connection '%s' auto-activation failed: %s",
nm_settings_connection_get_id (best_connection),
error->code,
error->message);
g_error_free (error);
nm_settings_connection_autoconnect_blocked_reason_set (best_connection,
NM_SETTINGS_AUTO_CONNECT_BLOCKED_REASON_FAILED);
schedule_activate_check (self, device);