fdo-mirrors/NetworkManager
1
0
Fork 0
mirror of https://gitlab.freedesktop.org/NetworkManager/NetworkManager.git synced 2026-01-25 17:20:23 +01:00
Code Issues Projects Releases Packages Wiki Activity Actions

device: minor cleanup of NMDeviceEthernet:get_link_speed()

Browse source 
A better name is link_speed_update(), because it re-reads and
sets the speed value.

Also, move _notfiy() after logging. It doesn't matter in this
case, but we should first log, and then do actions that have potentially
complex side-effects.
This commit is contained in:
Thomas Haller 2017-06-02 16:30:43 +02:00
parent 158e852604
commit fe9c61239a
1 changed files with 3 additions and 4 deletions
Show stats Download patch file Download diff file Expand all files Collapse all files

7
src/devices/nm-device-ethernet.c
View file

@ -1560,7 +1560,7 @@ update_connection (NMDevice *device, NMConnection *connection)
}
static void
get_link_speed (NMDevice *device)
link_speed_update (NMDevice *device)
{
NMDeviceEthernet *self = NM_DEVICE_ETHERNET (device);
NMDeviceEthernetPrivate *priv = NM_DEVICE_ETHERNET_GET_PRIVATE (self);
@ -1572,9 +1572,8 @@ get_link_speed (NMDevice *device)
return;
priv->speed = speed;
_notify (self, PROP_SPEED);
_LOGD (LOGD_PLATFORM | LOGD_ETHER, "speed is now %d Mb/s", speed);
_notify (self, PROP_SPEED);
}
static void
@ -1593,7 +1592,7 @@ carrier_changed_notify (NMDevice *device, gboolean carrier)
}
if (carrier)
get_link_speed (device);
link_speed_update (device);
NM_DEVICE_CLASS (nm_device_ethernet_parent_class)->carrier_changed_notify (device, carrier);
}