From fde46d7e65af555963920873a975f87e715839ef Mon Sep 17 00:00:00 2001 From: poma Date: Wed, 30 Nov 2016 16:49:36 +0100 Subject: [PATCH] libnm-core/man: add a warning on static link negotiation parameters When disabling link autonegotiation and setting speed and duplex manually, the user is alone: no check is performed against supplied values. So, the user is supposed to check that the device supports those values. Explicit this in nm-settings man page. [fgiudici@redhat.com: added the commit message] --- libnm-core/nm-setting-wired.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libnm-core/nm-setting-wired.c b/libnm-core/nm-setting-wired.c index 08b0b3450f..3d47cb6966 100644 --- a/libnm-core/nm-setting-wired.c +++ b/libnm-core/nm-setting-wired.c @@ -1035,6 +1035,7 @@ nm_setting_wired_class_init (NMSettingWiredClass *setting_wired_class) * In that case, statically configures the device to use that specified speed. * In Mbit/s, ie 100 == 100Mbit/s. * Must be set together with the "duplex" property when non-zero. + * Before specifying a speed value be sure your device supports it. **/ /* ---ifcfg-rh--- * property: speed @@ -1057,6 +1058,7 @@ nm_setting_wired_class_init (NMSettingWiredClass *setting_wired_class) * Can be specified only when "auto-negotiate" is "off". In that case, statically * configures the device to use that specified duplex mode, either "half" or "full". * Must be set together with the "speed" property if specified. + * Before specifying a duplex mode be sure your device supports it. **/ /* ---ifcfg-rh--- * property: duplex