From fc052494d1d76d7b3a39f0ba358666e5d3aeef05 Mon Sep 17 00:00:00 2001 From: Thomas Haller Date: Sat, 29 Dec 2018 16:03:41 +0100 Subject: [PATCH] checkpatch: warn about suspicious gtk-doc annotations It's (allow-none): and (transfer none): That's confusing enough. Add a check. --- contrib/scripts/checkpatch.pl | 1 + 1 file changed, 1 insertion(+) diff --git a/contrib/scripts/checkpatch.pl b/contrib/scripts/checkpatch.pl index 2ac931c2bc..d0b59b5f22 100755 --- a/contrib/scripts/checkpatch.pl +++ b/contrib/scripts/checkpatch.pl @@ -142,6 +142,7 @@ complain ("Please use LGPL2+ for new files") if $is_patch and $line =~ /under th complain ("Don't use space inside elvis operator ?:") if $line =~ /\?[\t ]+:/; complain ("Don't add Emacs editor formatting hints to source files") if $line_no == 1 and $line =~ /-\*-.+-\*-/; complain ("XXX marker are reserved for development while work-in-progress. Use TODO or FIXME comment instead?") if $line =~ /\bXXX\b/; +complain ("This gtk-doc annotation looks wrong") if $line =~ /\*.*\( *(transfer-(none|container|full)|allow none) *\) *(:|\()/; new_hunk if $_ eq ''; my ($this_indent) = /^(\s*)/;