From fb6fecc036f466f569a7d05ed0d499164e032f15 Mon Sep 17 00:00:00 2001 From: Thomas Haller Date: Thu, 12 Oct 2017 16:05:40 +0200 Subject: [PATCH] dhcp: use nm_utils_random_bytes() for generating random DUID --- src/dhcp/nm-dhcp-client.c | 7 +------ 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/src/dhcp/nm-dhcp-client.c b/src/dhcp/nm-dhcp-client.c index b9d4ce72fe..59845c8c7a 100644 --- a/src/dhcp/nm-dhcp-client.c +++ b/src/dhcp/nm-dhcp-client.c @@ -481,8 +481,6 @@ generate_duid_from_machine_id (void) gsize sumlen = sizeof (buffer); const guint16 duid_type = g_htons (4); uuid_t uuid; - GRand *generator; - guint i; gs_free char *machine_id_s = NULL; gs_free char *str = NULL; @@ -498,10 +496,7 @@ generate_duid_from_machine_id (void) "or " LOCALSTATEDIR "/lib/dbus/machine-id to generate " "DHCPv6 DUID; creating non-persistent random DUID."); - generator = g_rand_new (); - for (i = 0; i < sizeof (buffer) / sizeof (guint32); i++) - ((guint32 *) buffer)[i] = g_rand_int (generator); - g_rand_free (generator); + nm_utils_random_bytes (buffer, sizeof (buffer)); } /* Generate a DHCP Unique Identifier for DHCPv6 using the