From fa14406dc7b194b981f360f09254ab0f3e04bbb4 Mon Sep 17 00:00:00 2001 From: Antonio Cardace Date: Mon, 11 Jan 2021 15:26:11 +0100 Subject: [PATCH] wifi: always require PMF when using WPA-EAP-SUITE-B-192 The default value is `optional' so the current check in place is actually wrong and blocks NM from connecting to WPA3 networks. Overall the check is not that useful as WPA3 Enterprise always requires PMF to be 'required' so let's always force it instead. Signed-off-by: Antonio Cardace Fixes: e874ccc9177c ('wifi: add WPA-EAP-SUITE-B-192 support') --- src/supplicant/nm-supplicant-config.c | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/src/supplicant/nm-supplicant-config.c b/src/supplicant/nm-supplicant-config.c index e9bc27b991..1c4b3753ed 100644 --- a/src/supplicant/nm-supplicant-config.c +++ b/src/supplicant/nm-supplicant-config.c @@ -870,16 +870,6 @@ nm_supplicant_config_add_setting_wireless_security(NMSupplicantConfig * if (_get_capability(priv, NM_SUPPL_CAP_TYPE_FT)) g_string_append(key_mgmt_conf, " ft-sae"); } else if (nm_streq(key_mgmt, "wpa-eap-suite-b-192")) { - if (!NM_IN_SET(pmf, - NM_SETTING_WIRELESS_SECURITY_PMF_DEFAULT, - NM_SETTING_WIRELESS_SECURITY_PMF_REQUIRED)) { - g_set_error(error, - NM_SUPPLICANT_ERROR, - NM_SUPPLICANT_ERROR_CONFIG, - "PMF must be set to 'required'"); - return FALSE; - } - pmf = NM_SETTING_WIRELESS_SECURITY_PMF_REQUIRED; if (!nm_supplicant_config_add_option(self, "pairwise", "GCMP-256", -1, NULL, error) || !nm_supplicant_config_add_option(self, "group", "GCMP-256", -1, NULL, error))