From f903d3b7b8b77a4c3764801db77b9dc24886cf5c Mon Sep 17 00:00:00 2001 From: Thomas Haller Date: Thu, 27 May 2021 09:04:58 +0200 Subject: [PATCH] platform: drop unnecessary check in _vlan_xgress_qos_mappings_cpy() For one, "src_n_map" must always be greater than zero at this point. lgtm.com warns about that, and the point of this patch is to avoid that warning. Still, the check really isn't needed, also because nm_memdup() explicitly handles buffers sizes of zero. --- src/libnm-platform/nmp-object.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/src/libnm-platform/nmp-object.c b/src/libnm-platform/nmp-object.c index 378f1874f4..9c7e8c6902 100644 --- a/src/libnm-platform/nmp-object.c +++ b/src/libnm-platform/nmp-object.c @@ -540,8 +540,7 @@ _vlan_xgress_qos_mappings_cpy(guint * dst_n_map, || _vlan_xgress_qos_mappings_cmp(src_n_map, *dst_map, src_map) != 0) { nm_clear_g_free(dst_map); *dst_n_map = src_n_map; - if (src_n_map > 0) - *dst_map = nm_memdup(src_map, sizeof(*src_map) * src_n_map); + *dst_map = nm_memdup(src_map, sizeof(*src_map) * src_n_map); } }